)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"a79440c1b725c03f5eb1b2996accd7d1ab70458a","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Do not send compression as acceptable encoding"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When a BMC can compress a response, the internal server... or any"},{"line_number":10,"context_line":"intermediate proxy may change a \"Strong\" ETag to a \"Weak\" ETag, as"},{"line_number":11,"context_line":"the strength of the ETag represents the byte-by-byte consistency of the"},{"line_number":12,"context_line":"response body."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"2c48b070_c28ebc54","line":9,"updated":"2022-08-04 09:43:16.000000000","message":"nit: description not wrapped at 72 chars","commit_id":"99c5fe967a3644b24672f1ae634d3a8718a0c3d0"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"51e204ae90cf93aec2ac3eef8d221f2fe0c05d0b","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Do not send compression as acceptable encoding"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When a BMC can compress a response, the internal server... or any"},{"line_number":10,"context_line":"intermediate proxy may change a \"Strong\" ETag to a \"Weak\" ETag, as"},{"line_number":11,"context_line":"the strength of the ETag represents the byte-by-byte consistency of the"},{"line_number":12,"context_line":"response body."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"14995700_fdccce8c","line":9,"in_reply_to":"0b927b9c_41634683","updated":"2022-08-10 08:42:36.000000000","message":"I remember seeing discussions about only code to be increased from 80 chars and there were reasons for it. AFAIR it was decided to keep 80 limit.\n\nNot sure if you are suggesting to increase limit for commit messages to 80(?) and what would be the reason. I only bring this up because in Gerrit UI the message is severely ragged and harder to read. And there are commit message guidelines defined, though not enforced automatically :(.","commit_id":"99c5fe967a3644b24672f1ae634d3a8718a0c3d0"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"a0ce3d961cd2903f52ae8753c3b6beb453ccc4aa","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Do not send compression as acceptable encoding"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When a BMC can compress a response, the internal server... or any"},{"line_number":10,"context_line":"intermediate proxy may change a \"Strong\" ETag to a \"Weak\" ETag, as"},{"line_number":11,"context_line":"the strength of the ETag represents the byte-by-byte consistency of the"},{"line_number":12,"context_line":"response body."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"0b927b9c_41634683","line":9,"in_reply_to":"2c48b070_c28ebc54","updated":"2022-08-08 14:27:05.000000000","message":"FWIW, There is a whole argument that comes up in the wider community about removing the wrap rules.","commit_id":"99c5fe967a3644b24672f1ae634d3a8718a0c3d0"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"118734b62a0e209b1d9575d31583c3ca7250b62e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"4a4695a8_f20e07ef","updated":"2022-07-20 17:10:22.000000000","message":"Greetings folks! Based on the recent etags discussion, and some research, I think this is the right path forward. Naturally we need to proceed carefully.","commit_id":"c83f9a553f4568a50ff607cc4c4f45e2f34e8e37"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"1325c65ebade180a8b96df0e2d8897cb191cd888","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"fbfa2bbf_1e70a0bc","updated":"2022-07-20 17:08:50.000000000","message":"Marking WF-1 until we\u0027ve seen testing from this pan out.","commit_id":"c83f9a553f4568a50ff607cc4c4f45e2f34e8e37"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"a79440c1b725c03f5eb1b2996accd7d1ab70458a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"7a7d9176_e809696a","updated":"2022-08-04 09:43:16.000000000","message":"LGTM","commit_id":"99c5fe967a3644b24672f1ae634d3a8718a0c3d0"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"5477f43982443328b3c129bbd1a129d123268f2b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"020f96e0_27d25c26","updated":"2022-08-05 10:12:06.000000000","message":"Relaying feedback from Rhys:\n\nTested on an ThinkEdge-SE450 with latest firmware (1.10 USX304W 2022-04-20), unfortunately the patch isn\u0027t sufficient to successfully provision the machine. Similarly to the previous revision, we get an error message indicating a failed attempt to PATCH /redfish/v1/Systems/1/Pending.\n\nHaving said that, that may or may not be a completely separate issue...","commit_id":"99c5fe967a3644b24672f1ae634d3a8718a0c3d0"},{"author":{"_account_id":29296,"name":"Uemit Seren","email":"uemit.seren@gmail.com","username":"timeu"},"change_message_id":"1d07601fbdc95c9378be61b981ca316a5a86323f","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"16bc0204_fbbb4dc7","updated":"2022-08-04 20:38:09.000000000","message":"Tested on SD530 Lenovo machine with old (4.60) and newest (5.20) firmware with the latest patchset (identity) and I can confirm that it fixes the Etag issue on both of them","commit_id":"99c5fe967a3644b24672f1ae634d3a8718a0c3d0"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"1bdbf07ef390b5574a2eb24b953878e17c01e878","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"c3f801e4_a3bb692a","updated":"2022-08-08 14:20:18.000000000","message":"The /Pending issue if about the incorrect Settings object, not sure what to do about it.","commit_id":"99c5fe967a3644b24672f1ae634d3a8718a0c3d0"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"aee877f3ce29a2a1e96a069a309265738e621621","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"7a46ce79_1220cf36","updated":"2022-08-10 08:20:00.000000000","message":"I\u0027ve only fixed typos in the release notes. LGTM.","commit_id":"51dacf272f4d0f3e346c69e94786da2b7ee7c935"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"af234e78e5d58e24d6e2753613d72e4f7f863c88","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"57ed4116_41571fba","updated":"2022-08-10 10:29:03.000000000","message":"We got 2 people confirming this change on hardware, so I hope it\u0027s fine to continue.","commit_id":"51dacf272f4d0f3e346c69e94786da2b7ee7c935"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"51e204ae90cf93aec2ac3eef8d221f2fe0c05d0b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"0047464a_2c382c6e","updated":"2022-08-10 08:42:36.000000000","message":"thanks Dmitry, LGTM.\n\nI\u0027m OK with W+1 unless someone else still wants to review this with their hardware.","commit_id":"51dacf272f4d0f3e346c69e94786da2b7ee7c935"}],"releasenotes/notes/do-not-offer-compression-encoding-884ca8a7458cb096.yaml":[{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"a79440c1b725c03f5eb1b2996accd7d1ab70458a","unresolved":true,"context_lines":[{"line_number":5,"context_line":"    opportunistic use of compressed responses may cause the BMC to change"},{"line_number":6,"context_line":"    an ETag response to \"Weak\", which is to be expected as an ETag represents"},{"line_number":7,"context_line":"    an absolute byte-by-byte response consistency, and compression cannot"},{"line_number":8,"context_line":"    reliable honor that contract. Introduction of a client percieving a"},{"line_number":9,"context_line":"    \"Weak\" ETag may not be expected by the server, and the server may reject"},{"line_number":10,"context_line":"    responses because the ETag is not a \"Strong\" ETag when we respond or"},{"line_number":11,"context_line":"    interact with a resource."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9eae699e_18c8be87","line":8,"range":{"start_line":8,"start_character":59,"end_line":8,"end_character":70},"updated":"2022-08-04 09:43:16.000000000","message":"perceiving","commit_id":"99c5fe967a3644b24672f1ae634d3a8718a0c3d0"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"a79440c1b725c03f5eb1b2996accd7d1ab70458a","unresolved":true,"context_lines":[{"line_number":5,"context_line":"    opportunistic use of compressed responses may cause the BMC to change"},{"line_number":6,"context_line":"    an ETag response to \"Weak\", which is to be expected as an ETag represents"},{"line_number":7,"context_line":"    an absolute byte-by-byte response consistency, and compression cannot"},{"line_number":8,"context_line":"    reliable honor that contract. Introduction of a client percieving a"},{"line_number":9,"context_line":"    \"Weak\" ETag may not be expected by the server, and the server may reject"},{"line_number":10,"context_line":"    responses because the ETag is not a \"Strong\" ETag when we respond or"},{"line_number":11,"context_line":"    interact with a resource."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"6046ceb8_479b8ce1","line":8,"range":{"start_line":8,"start_character":4,"end_line":8,"end_character":13},"updated":"2022-08-04 09:43:16.000000000","message":"reliably?","commit_id":"99c5fe967a3644b24672f1ae634d3a8718a0c3d0"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"c06f4a54a56df543e956df741012209715050958","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    opportunistic use of compressed responses may cause the BMC to change"},{"line_number":6,"context_line":"    an ETag response to \"Weak\", which is to be expected as an ETag represents"},{"line_number":7,"context_line":"    an absolute byte-by-byte response consistency, and compression cannot"},{"line_number":8,"context_line":"    reliable honor that contract. Introduction of a client percieving a"},{"line_number":9,"context_line":"    \"Weak\" ETag may not be expected by the server, and the server may reject"},{"line_number":10,"context_line":"    responses because the ETag is not a \"Strong\" ETag when we respond or"},{"line_number":11,"context_line":"    interact with a resource."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"ad179d9d_b9db3c8c","line":8,"range":{"start_line":8,"start_character":4,"end_line":8,"end_character":13},"in_reply_to":"6046ceb8_479b8ce1","updated":"2022-08-10 08:19:45.000000000","message":"Done","commit_id":"99c5fe967a3644b24672f1ae634d3a8718a0c3d0"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"c06f4a54a56df543e956df741012209715050958","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    opportunistic use of compressed responses may cause the BMC to change"},{"line_number":6,"context_line":"    an ETag response to \"Weak\", which is to be expected as an ETag represents"},{"line_number":7,"context_line":"    an absolute byte-by-byte response consistency, and compression cannot"},{"line_number":8,"context_line":"    reliable honor that contract. Introduction of a client percieving a"},{"line_number":9,"context_line":"    \"Weak\" ETag may not be expected by the server, and the server may reject"},{"line_number":10,"context_line":"    responses because the ETag is not a \"Strong\" ETag when we respond or"},{"line_number":11,"context_line":"    interact with a resource."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9260ea13_82fbf09c","line":8,"range":{"start_line":8,"start_character":59,"end_line":8,"end_character":70},"in_reply_to":"9eae699e_18c8be87","updated":"2022-08-10 08:19:45.000000000","message":"Done","commit_id":"99c5fe967a3644b24672f1ae634d3a8718a0c3d0"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"a79440c1b725c03f5eb1b2996accd7d1ab70458a","unresolved":true,"context_lines":[{"line_number":10,"context_line":"    responses because the ETag is not a \"Strong\" ETag when we respond or"},{"line_number":11,"context_line":"    interact with a resource."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"    As a result, requests are no longer offer oppurtunistic compression"},{"line_number":14,"context_line":"    of responses as an acceptable possibility, which overall has minimal"},{"line_number":15,"context_line":"    impact, espescially when compared to the value of consistent BMC"},{"line_number":16,"context_line":"    behavior and interaction."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"f14b8760_92d32aa9","line":13,"range":{"start_line":13,"start_character":17,"end_line":13,"end_character":45},"updated":"2022-08-04 09:43:16.000000000","message":"no longer offer / are no longer offering","commit_id":"99c5fe967a3644b24672f1ae634d3a8718a0c3d0"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"c06f4a54a56df543e956df741012209715050958","unresolved":false,"context_lines":[{"line_number":10,"context_line":"    responses because the ETag is not a \"Strong\" ETag when we respond or"},{"line_number":11,"context_line":"    interact with a resource."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"    As a result, requests are no longer offer oppurtunistic compression"},{"line_number":14,"context_line":"    of responses as an acceptable possibility, which overall has minimal"},{"line_number":15,"context_line":"    impact, espescially when compared to the value of consistent BMC"},{"line_number":16,"context_line":"    behavior and interaction."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3948dab8_2a74c5f1","line":13,"range":{"start_line":13,"start_character":17,"end_line":13,"end_character":45},"in_reply_to":"f14b8760_92d32aa9","updated":"2022-08-10 08:19:45.000000000","message":"Done","commit_id":"99c5fe967a3644b24672f1ae634d3a8718a0c3d0"}],"sushy/connector.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"f558da50e41dc29bb4ce1ec15b4878f18ba712e3","unresolved":true,"context_lines":[{"line_number":56,"context_line":"        # body content *may* not be a byte for byte match given compression."},{"line_number":57,"context_line":"        # Overall, the value of compression is less than the value of concise"},{"line_number":58,"context_line":"        # interaction with the BMC."},{"line_number":59,"context_line":"        self._session.headers.pop(\u0027Accept-Encoding\u0027, None)"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"        if username or password:"},{"line_number":62,"context_line":"            LOG.warning(\u0027Passing username and password to Connector is \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"fd69dd20_e32bf336","line":59,"updated":"2022-08-02 08:49:40.000000000","message":"Maybe even explicitly send\n\n Accept-Encoding: identity\n \n?","commit_id":"4e2a3ac71a0748afececea1bae3682c541f1bf98"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"eacf9f448120dc7f8cf8146c144a09d2242783ed","unresolved":true,"context_lines":[{"line_number":56,"context_line":"        # body content *may* not be a byte for byte match given compression."},{"line_number":57,"context_line":"        # Overall, the value of compression is less than the value of concise"},{"line_number":58,"context_line":"        # interaction with the BMC."},{"line_number":59,"context_line":"        self._session.headers.pop(\u0027Accept-Encoding\u0027, None)"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"        if username or password:"},{"line_number":62,"context_line":"            LOG.warning(\u0027Passing username and password to Connector is \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"49d6c301_b2158ca0","line":59,"in_reply_to":"fd69dd20_e32bf336","updated":"2022-08-03 15:46:38.000000000","message":"I think that is likely better, in the grand scheme of things.\n\nThe Redfish spec document says the BMC shall respond with a 406 if it cannot handle a non-compressed response.... And if the header is omitted, it *should* not respond with compressed contents. Sending identity should force us into an specific pattern of behavior.","commit_id":"4e2a3ac71a0748afececea1bae3682c541f1bf98"}]}