)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"716c256ee47945c8365b61077aec297ad0ee3b0d","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix volume deletion on newer iDRACs"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Handles failure of volume.delete while deleting volumes arises"},{"line_number":10,"context_line":"during verification of operation apply time variable on unsupported"},{"line_number":11,"context_line":"iDRAC BMC firmware."},{"line_number":12,"context_line":"It fixes \u0027Unsupported parameter name @Redfish.OperationApplyTime\u0027"},{"line_number":13,"context_line":"General error on iDRAC firmware version 6.00.02.00 or newer when"},{"line_number":14,"context_line":"deleting volumes."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"6236f599_66e4ecaa","line":11,"range":{"start_line":9,"start_character":0,"end_line":11,"end_character":19},"updated":"2022-11-21 14:01:32.000000000","message":"Something does not read right in this sentence. Suggesting reshuffle and update all commit message to:\n\n\u003e Fixes \u0027Unsupported parameter name @Redfish.OperationApplyTime\u0027 General error on iDRAC firmware version 6.00.02.00 or newer when deleting volumes.\n\n\u003e Handles the failure of volume.delete by retrying without operation apply time. In older iDRAC firmware versions operation apply time was silently ignored, but now in newer iDRAC firmware versions it is returning 501 Not Implemented error.","commit_id":"e834edf36a624a224cb4236a320929dbcdf77f94"},{"author":{"_account_id":33244,"name":"kamlesh chauvhan","email":"kamlesh.chauvhan@gmail.com","username":"kamlesh.chauvhan"},"change_message_id":"f3bec071873f953cbf5f33b8b86ce1dbbd98a1d2","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix volume deletion on newer iDRACs"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Handles failure of volume.delete while deleting volumes arises"},{"line_number":10,"context_line":"during verification of operation apply time variable on unsupported"},{"line_number":11,"context_line":"iDRAC BMC firmware."},{"line_number":12,"context_line":"It fixes \u0027Unsupported parameter name @Redfish.OperationApplyTime\u0027"},{"line_number":13,"context_line":"General error on iDRAC firmware version 6.00.02.00 or newer when"},{"line_number":14,"context_line":"deleting volumes."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"8a00ae0c_7466526b","line":11,"range":{"start_line":9,"start_character":0,"end_line":11,"end_character":19},"in_reply_to":"6236f599_66e4ecaa","updated":"2022-11-22 09:28:26.000000000","message":"Incorporated.","commit_id":"e834edf36a624a224cb4236a320929dbcdf77f94"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"716c256ee47945c8365b61077aec297ad0ee3b0d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"619c807d_47f7ef0a","updated":"2022-11-21 14:01:32.000000000","message":"Thanks, some suggestions inline.","commit_id":"e834edf36a624a224cb4236a320929dbcdf77f94"},{"author":{"_account_id":33244,"name":"kamlesh chauvhan","email":"kamlesh.chauvhan@gmail.com","username":"kamlesh.chauvhan"},"change_message_id":"f3bec071873f953cbf5f33b8b86ce1dbbd98a1d2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"68aa9e80_a4fd624d","updated":"2022-11-22 09:28:26.000000000","message":"Thanks for review Comments. Incorporated Suggested Changes. ","commit_id":"036503ff64a6c5d555467e288eb12decf7994507"},{"author":{"_account_id":17686,"name":"Fedor Tarasenko","email":"ftarasenko@itkey.com","username":"ftarasenko"},"change_message_id":"5a04767a5f2ea642469e20c385640f12382020fc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"8073ca11_fe770e6a","updated":"2022-12-07 08:20:28.000000000","message":"Thank you!","commit_id":"1d08f0d16027d3cbbb568aae16b2596d278494b5"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"9ce285781d81af9fba0bc742b98912085633d09a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"b208a7ca_9345c27a","updated":"2022-12-13 09:23:49.000000000","message":"Thanks, updating while Kamelsh is away.","commit_id":"74f95b1dd511cbbf36b0e85a596212d96047e345"}],"sushy/resources/system/storage/volume.py":[{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"716c256ee47945c8365b61077aec297ad0ee3b0d","unresolved":true,"context_lines":[{"line_number":140,"context_line":"            r \u003d self._conn.delete(self._path, data\u003dpayload,"},{"line_number":141,"context_line":"                                  blocking\u003dblocking, timeout\u003dtimeout)"},{"line_number":142,"context_line":"        except exceptions.ServerSideError as exc:"},{"line_number":143,"context_line":"            if (\u0027Unsupported parameter name @Redfish.OperationApplyTime\u0027"},{"line_number":144,"context_line":"                    in str(exc.message)):"},{"line_number":145,"context_line":"                # retry without apply time property"},{"line_number":146,"context_line":"                payload.pop(_OAT_PROP)"}],"source_content_type":"text/x-python","patch_set":1,"id":"a7ac2c95_6563eb68","line":143,"range":{"start_line":143,"start_character":17,"end_line":143,"end_character":71},"updated":"2022-11-21 14:01:32.000000000","message":"I\u0027m thinking that the message could be translated and not contain English words \"Unsupported parameter name\" or it could change with time. Maybe leave only \u0027@Redfish.OperationApplyTime\u0027. Also - what\u0027s the error code here? Could use that in addition to \u0027@Redfish.OperationApplyTime\u0027.","commit_id":"e834edf36a624a224cb4236a320929dbcdf77f94"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"33b75e3fafeffd196107df9abf5f4246a16b37cc","unresolved":true,"context_lines":[{"line_number":140,"context_line":"            r \u003d self._conn.delete(self._path, data\u003dpayload,"},{"line_number":141,"context_line":"                                  blocking\u003dblocking, timeout\u003dtimeout)"},{"line_number":142,"context_line":"        except exceptions.ServerSideError as exc:"},{"line_number":143,"context_line":"            if (\u0027Unsupported parameter name @Redfish.OperationApplyTime\u0027"},{"line_number":144,"context_line":"                    in str(exc.message)):"},{"line_number":145,"context_line":"                # retry without apply time property"},{"line_number":146,"context_line":"                payload.pop(_OAT_PROP)"}],"source_content_type":"text/x-python","patch_set":1,"id":"e0ba2748_2f6b24db","line":143,"range":{"start_line":143,"start_character":17,"end_line":143,"end_character":71},"in_reply_to":"a7ac2c95_6563eb68","updated":"2022-11-21 18:43:53.000000000","message":"I agree with the concern, I do *believe* the idrac does have translated replies on some endpoints. I do think changing the match to align with \"@Redfish.OperationApplyTime\" makes the most sense.","commit_id":"e834edf36a624a224cb4236a320929dbcdf77f94"},{"author":{"_account_id":33244,"name":"kamlesh chauvhan","email":"kamlesh.chauvhan@gmail.com","username":"kamlesh.chauvhan"},"change_message_id":"f3bec071873f953cbf5f33b8b86ce1dbbd98a1d2","unresolved":false,"context_lines":[{"line_number":140,"context_line":"            r \u003d self._conn.delete(self._path, data\u003dpayload,"},{"line_number":141,"context_line":"                                  blocking\u003dblocking, timeout\u003dtimeout)"},{"line_number":142,"context_line":"        except exceptions.ServerSideError as exc:"},{"line_number":143,"context_line":"            if (\u0027Unsupported parameter name @Redfish.OperationApplyTime\u0027"},{"line_number":144,"context_line":"                    in str(exc.message)):"},{"line_number":145,"context_line":"                # retry without apply time property"},{"line_number":146,"context_line":"                payload.pop(_OAT_PROP)"}],"source_content_type":"text/x-python","patch_set":1,"id":"4ffd8f35_12a6d7e3","line":143,"range":{"start_line":143,"start_character":17,"end_line":143,"end_character":71},"in_reply_to":"e0ba2748_2f6b24db","updated":"2022-11-22 09:28:26.000000000","message":"Incorporated.","commit_id":"e834edf36a624a224cb4236a320929dbcdf77f94"},{"author":{"_account_id":17686,"name":"Fedor Tarasenko","email":"ftarasenko@itkey.com","username":"ftarasenko"},"change_message_id":"b377e9f52845220ade0c3368ddefe4cd71f2fe2c","unresolved":true,"context_lines":[{"line_number":140,"context_line":"            r \u003d self._conn.delete(self._path, data\u003dpayload,"},{"line_number":141,"context_line":"                                  blocking\u003dblocking, timeout\u003dtimeout)"},{"line_number":142,"context_line":"        except exceptions.ServerSideError as exc:"},{"line_number":143,"context_line":"            if ((\u0027@Redfish.OperationApplyTime\u0027 and \u0027SYS029\u0027)"},{"line_number":144,"context_line":"                    in str(exc.message)):"},{"line_number":145,"context_line":"                # retry without apply time property"},{"line_number":146,"context_line":"                payload.pop(_OAT_PROP)"}],"source_content_type":"text/x-python","patch_set":2,"id":"827d8038_442f8f61","line":143,"updated":"2022-12-07 06:32:27.000000000","message":"This condition does not make sense cause it always equals to \u0027@SYS029\u0027. \nDid you mean something like \u0027@Redfish.OperationApplyTime\u0027 in str(exc.message) and \u0027SYS029\u0027 in str(exc.message) ?\n\n\u003e\u003e\u003e (\u0027@Redfish.OperationApplyTime\u0027 and \u0027SYS029\u0027)\n\u0027SYS029\u0027","commit_id":"036503ff64a6c5d555467e288eb12decf7994507"},{"author":{"_account_id":17686,"name":"Fedor Tarasenko","email":"ftarasenko@itkey.com","username":"ftarasenko"},"change_message_id":"5a04767a5f2ea642469e20c385640f12382020fc","unresolved":false,"context_lines":[{"line_number":140,"context_line":"            r \u003d self._conn.delete(self._path, data\u003dpayload,"},{"line_number":141,"context_line":"                                  blocking\u003dblocking, timeout\u003dtimeout)"},{"line_number":142,"context_line":"        except exceptions.ServerSideError as exc:"},{"line_number":143,"context_line":"            if ((\u0027@Redfish.OperationApplyTime\u0027 and \u0027SYS029\u0027)"},{"line_number":144,"context_line":"                    in str(exc.message)):"},{"line_number":145,"context_line":"                # retry without apply time property"},{"line_number":146,"context_line":"                payload.pop(_OAT_PROP)"}],"source_content_type":"text/x-python","patch_set":2,"id":"97c735a4_0030639e","line":143,"in_reply_to":"5640d3d0_375c30fd","updated":"2022-12-07 08:20:28.000000000","message":"Done","commit_id":"036503ff64a6c5d555467e288eb12decf7994507"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"4d7daba0d20e42ed93f25b72b8e2fc45308ca32d","unresolved":true,"context_lines":[{"line_number":140,"context_line":"            r \u003d self._conn.delete(self._path, data\u003dpayload,"},{"line_number":141,"context_line":"                                  blocking\u003dblocking, timeout\u003dtimeout)"},{"line_number":142,"context_line":"        except exceptions.ServerSideError as exc:"},{"line_number":143,"context_line":"            if ((\u0027@Redfish.OperationApplyTime\u0027 and \u0027SYS029\u0027)"},{"line_number":144,"context_line":"                    in str(exc.message)):"},{"line_number":145,"context_line":"                # retry without apply time property"},{"line_number":146,"context_line":"                payload.pop(_OAT_PROP)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5640d3d0_375c30fd","line":143,"in_reply_to":"827d8038_442f8f61","updated":"2022-12-07 07:58:20.000000000","message":"Nice catch, thanks. In reality SYS029 should be sufficient, I\u0027m not aware of any other property returning SYS029 for this call, but checking OperationApplyTime for additional constraint.\n\nWhile Kamlesh is away, fixed and added another unit test to catch this.","commit_id":"036503ff64a6c5d555467e288eb12decf7994507"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"a35a8309facf89b72830ebeea60df77ae8cbc195","unresolved":false,"context_lines":[{"line_number":142,"context_line":"        except exceptions.ServerSideError as exc:"},{"line_number":143,"context_line":"            if (\u0027@Redfish.OperationApplyTime\u0027 in str(exc.message)"},{"line_number":144,"context_line":"                    and \u0027SYS029\u0027 in str(exc.message)):"},{"line_number":145,"context_line":"                # retry without apply time property"},{"line_number":146,"context_line":"                payload.pop(_OAT_PROP)"},{"line_number":147,"context_line":"                r \u003d self._conn.delete(self._path, data\u003dpayload,"},{"line_number":148,"context_line":"                                      blocking\u003dblocking, timeout\u003dtimeout)"}],"source_content_type":"text/x-python","patch_set":3,"id":"b53f5e9a_08664505","line":145,"updated":"2022-12-12 16:21:36.000000000","message":"Please add logging here (see other workarounds for examples)","commit_id":"1d08f0d16027d3cbbb568aae16b2596d278494b5"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"9ce285781d81af9fba0bc742b98912085633d09a","unresolved":false,"context_lines":[{"line_number":142,"context_line":"        except exceptions.ServerSideError as exc:"},{"line_number":143,"context_line":"            if (\u0027@Redfish.OperationApplyTime\u0027 in str(exc.message)"},{"line_number":144,"context_line":"                    and \u0027SYS029\u0027 in str(exc.message)):"},{"line_number":145,"context_line":"                # retry without apply time property"},{"line_number":146,"context_line":"                payload.pop(_OAT_PROP)"},{"line_number":147,"context_line":"                r \u003d self._conn.delete(self._path, data\u003dpayload,"},{"line_number":148,"context_line":"                                      blocking\u003dblocking, timeout\u003dtimeout)"}],"source_content_type":"text/x-python","patch_set":3,"id":"c58d85f8_f5aa04bd","line":145,"in_reply_to":"b53f5e9a_08664505","updated":"2022-12-13 09:23:49.000000000","message":"Done","commit_id":"1d08f0d16027d3cbbb568aae16b2596d278494b5"}]}