)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"353215ab56e72a178ea6d0fb1e6b39f960006412","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"233ce2f3_be70091e","updated":"2022-11-21 14:01:10.000000000","message":"Thanks, LGTM.","commit_id":"7ac7faee5731fd2ea029fb65b3a8b29cb4bac7c8"},{"author":{"_account_id":33244,"name":"kamlesh chauvhan","email":"kamlesh.chauvhan@gmail.com","username":"kamlesh.chauvhan"},"change_message_id":"a3ecd1d8d1c75699d969f510ee67499072f9c597","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"5dc49d93_29aa67c3","updated":"2022-12-01 11:06:10.000000000","message":"Thanks for review Comment. As suggested, made changes. Please help to re-review.","commit_id":"2b760a6c9ef23ca2a9f736ca6a6c8c146490f1c3"}],"sushy/connector.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"725fca22eaa453d834da96d9269353d1cb8eb981","unresolved":true,"context_lines":[{"line_number":198,"context_line":"                raise"},{"line_number":199,"context_line":"        except exceptions.ServerSideError as e:"},{"line_number":200,"context_line":"            if ((method.lower() \u003d\u003d \u0027get\u0027"},{"line_number":201,"context_line":"                    or \u0027SYS518\u0027 in str(e.message))"},{"line_number":202,"context_line":"                    and self._server_side_retries \u003e 0):"},{"line_number":203,"context_line":"                LOG.warning(\u0027Got server side error %s in response to a \u0027"},{"line_number":204,"context_line":"                            \u0027GET request, retrying after %d seconds\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"eeedf0ae_e7c1a672","line":201,"range":{"start_line":201,"start_character":20,"end_line":201,"end_character":50},"updated":"2022-11-21 18:45:39.000000000","message":"Is there any other way that doesn\u0027t involve hard coding a dell error into connection handling logic?","commit_id":"7ac7faee5731fd2ea029fb65b3a8b29cb4bac7c8"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"6d3ab2948ec697d3a7bc76d05aac30d946556730","unresolved":true,"context_lines":[{"line_number":198,"context_line":"                raise"},{"line_number":199,"context_line":"        except exceptions.ServerSideError as e:"},{"line_number":200,"context_line":"            if ((method.lower() \u003d\u003d \u0027get\u0027"},{"line_number":201,"context_line":"                    or \u0027SYS518\u0027 in str(e.message))"},{"line_number":202,"context_line":"                    and self._server_side_retries \u003e 0):"},{"line_number":203,"context_line":"                LOG.warning(\u0027Got server side error %s in response to a \u0027"},{"line_number":204,"context_line":"                            \u0027GET request, retrying after %d seconds\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"f9ee9f51_430482c2","line":201,"range":{"start_line":201,"start_character":20,"end_line":201,"end_character":50},"in_reply_to":"eeedf0ae_e7c1a672","updated":"2022-11-22 07:37:02.000000000","message":"Not that I can think of. It returns HTTP 500 error with message details in response body, but we don\u0027t want to retry on any HTTP 500 thus checking for the error code. \n\nDo you have better idea?","commit_id":"7ac7faee5731fd2ea029fb65b3a8b29cb4bac7c8"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"b56b15f90734731bb5e66965019e1bbc89455285","unresolved":false,"context_lines":[{"line_number":198,"context_line":"                raise"},{"line_number":199,"context_line":"        except exceptions.ServerSideError as e:"},{"line_number":200,"context_line":"            if ((method.lower() \u003d\u003d \u0027get\u0027"},{"line_number":201,"context_line":"                    or \u0027SYS518\u0027 in str(e.message))"},{"line_number":202,"context_line":"                    and self._server_side_retries \u003e 0):"},{"line_number":203,"context_line":"                LOG.warning(\u0027Got server side error %s in response to a \u0027"},{"line_number":204,"context_line":"                            \u0027GET request, retrying after %d seconds\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"900a9053_7584018e","line":201,"range":{"start_line":201,"start_character":20,"end_line":201,"end_character":50},"in_reply_to":"f56e8d1e_4caddb5b","updated":"2022-12-06 15:21:49.000000000","message":"Julia, can you elaborate on the \"method which can be overriden\" - how, where? Otherwise updates LGTM.","commit_id":"7ac7faee5731fd2ea029fb65b3a8b29cb4bac7c8"},{"author":{"_account_id":33244,"name":"kamlesh chauvhan","email":"kamlesh.chauvhan@gmail.com","username":"kamlesh.chauvhan"},"change_message_id":"a3ecd1d8d1c75699d969f510ee67499072f9c597","unresolved":false,"context_lines":[{"line_number":198,"context_line":"                raise"},{"line_number":199,"context_line":"        except exceptions.ServerSideError as e:"},{"line_number":200,"context_line":"            if ((method.lower() \u003d\u003d \u0027get\u0027"},{"line_number":201,"context_line":"                    or \u0027SYS518\u0027 in str(e.message))"},{"line_number":202,"context_line":"                    and self._server_side_retries \u003e 0):"},{"line_number":203,"context_line":"                LOG.warning(\u0027Got server side error %s in response to a \u0027"},{"line_number":204,"context_line":"                            \u0027GET request, retrying after %d seconds\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"f56e8d1e_4caddb5b","line":201,"range":{"start_line":201,"start_character":20,"end_line":201,"end_character":50},"in_reply_to":"f8e68c0d_8945ea7a","updated":"2022-12-01 11:06:10.000000000","message":"Incorporated.","commit_id":"7ac7faee5731fd2ea029fb65b3a8b29cb4bac7c8"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"b3e6895bade055d036c01da472e31c474b8dc7c9","unresolved":true,"context_lines":[{"line_number":198,"context_line":"                raise"},{"line_number":199,"context_line":"        except exceptions.ServerSideError as e:"},{"line_number":200,"context_line":"            if ((method.lower() \u003d\u003d \u0027get\u0027"},{"line_number":201,"context_line":"                    or \u0027SYS518\u0027 in str(e.message))"},{"line_number":202,"context_line":"                    and self._server_side_retries \u003e 0):"},{"line_number":203,"context_line":"                LOG.warning(\u0027Got server side error %s in response to a \u0027"},{"line_number":204,"context_line":"                            \u0027GET request, retrying after %d seconds\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"f8e68c0d_8945ea7a","line":201,"range":{"start_line":201,"start_character":20,"end_line":201,"end_character":50},"in_reply_to":"f9ee9f51_430482c2","updated":"2022-11-29 19:26:49.000000000","message":"Lets create a method which can be overridden, which gets stored elsewhere (outside of this method), where we can pass the exception output into, and get a true or false out of the method to determine if we need to retry. In that method, we should likely explicitly log why we are retrying along with the error encountered, so we can figure out why we retried when looking at someone\u0027s logs.","commit_id":"7ac7faee5731fd2ea029fb65b3a8b29cb4bac7c8"}]}