)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"980b6d4bbb95891372bc7e58a9e6dc312a9f2cbd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5c92b530_d81374cd","updated":"2023-02-15 18:02:17.000000000","message":"This is what I was thinking. Unit tests and a release note and I *think* you\u0027ll be good.","commit_id":"a093b6c0c6d94819036e674c76bd103d12c12f56"}],"releasenotes/notes/non-default-language-registries-f73bdecc98ba2cc8.yaml":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"914c776e43d14a77f48407d2ba48b44ca1a946eb","unresolved":false,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    In some cases registries might not be available because the"},{"line_number":5,"context_line":"    our check for the registry language was too restrict."},{"line_number":6,"context_line":"    The logic was simplified to consider if the registry language"},{"line_number":7,"context_line":"    starts with the language that sushy requested."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"db22961d_11301c76","line":5,"updated":"2023-02-28 15:44:40.000000000","message":"s/restrict/strict/ or better \"did not account for a possible country suffix\"","commit_id":"29d040eb881457638dd7d3beb5ea2285d9045fa0"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"798b11e0ab7ac4a143a8229d5db97de51721e3b8","unresolved":false,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    In some cases registries might not be available because the"},{"line_number":5,"context_line":"    our check for the registry language was too restrict."},{"line_number":6,"context_line":"    The logic was simplified to consider if the registry language"},{"line_number":7,"context_line":"    starts with the language that sushy requested."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3d64b132_5e4bb145","line":5,"in_reply_to":"db22961d_11301c76","updated":"2023-02-28 15:59:23.000000000","message":"ack","commit_id":"29d040eb881457638dd7d3beb5ea2285d9045fa0"}],"sushy/resources/base.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"bf321142864c49a4c3ed4dc8b601bfe6268d886d","unresolved":true,"context_lines":[{"line_number":597,"context_line":"                if language.lower() !\u003d registry.language.lower():"},{"line_number":598,"context_line":"                    # NOTE(iurygregory): some registries may have \"en-US\""},{"line_number":599,"context_line":"                    # as their language, in this case we can check if the"},{"line_number":600,"context_line":"                    # registry language starts with the requested language."},{"line_number":601,"context_line":"                    if registry.language.lower().startswith(language.lower()):"},{"line_number":602,"context_line":"                        return registry"},{"line_number":603,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"30dc0098_30de8a00","line":600,"updated":"2023-02-27 11:37:42.000000000","message":"Maybe it\u0027s a bit more robust to split on \"-\"?","commit_id":"f5b0aa4656e51cd6ee7924f84fcfa63f2f896023"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"f7e6e51cea66923d8481e9e70e797c181fb625b7","unresolved":false,"context_lines":[{"line_number":597,"context_line":"                if language.lower() !\u003d registry.language.lower():"},{"line_number":598,"context_line":"                    # NOTE(iurygregory): some registries may have \"en-US\""},{"line_number":599,"context_line":"                    # as their language, in this case we can check if the"},{"line_number":600,"context_line":"                    # registry language starts with the requested language."},{"line_number":601,"context_line":"                    if registry.language.lower().startswith(language.lower()):"},{"line_number":602,"context_line":"                        return registry"},{"line_number":603,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"76c49f8d_e8ee0df0","line":600,"in_reply_to":"30dc0098_30de8a00","updated":"2023-02-27 11:45:17.000000000","message":"yeah splitting by \"-\" would it make match the language, I\u0027m ok with doing this, going to update the patch","commit_id":"f5b0aa4656e51cd6ee7924f84fcfa63f2f896023"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"914c776e43d14a77f48407d2ba48b44ca1a946eb","unresolved":false,"context_lines":[{"line_number":597,"context_line":"                # NOTE(iurygregory): some registries may have \"en-US\""},{"line_number":598,"context_line":"                # as their language, in this case we can check if the"},{"line_number":599,"context_line":"                # registry language starts with the requested language."},{"line_number":600,"context_line":"                registry_language \u003d registry.language.lower().split(\u0027-\u0027, 1)[0]"},{"line_number":601,"context_line":"                if language.lower() !\u003d registry_language:"},{"line_number":602,"context_line":"                    LOG.debug(\u0027Found %(descr)s but its language %(reg_lang)s \u0027"},{"line_number":603,"context_line":"                              \u0027does not match the requested %(lang)s\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"5c9d41d2_03b23b76","line":600,"updated":"2023-02-28 15:44:40.000000000","message":"Sorry, I did not realize this initially.. but now we\u0027re breaking the cause of people requesting e.g. ru-RU explicilty. Maybe we really have to\n\n if language !\u003d registry.language and language.lower() !\u003d registry_language\n\nor something similar","commit_id":"29d040eb881457638dd7d3beb5ea2285d9045fa0"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"798b11e0ab7ac4a143a8229d5db97de51721e3b8","unresolved":false,"context_lines":[{"line_number":597,"context_line":"                # NOTE(iurygregory): some registries may have \"en-US\""},{"line_number":598,"context_line":"                # as their language, in this case we can check if the"},{"line_number":599,"context_line":"                # registry language starts with the requested language."},{"line_number":600,"context_line":"                registry_language \u003d registry.language.lower().split(\u0027-\u0027, 1)[0]"},{"line_number":601,"context_line":"                if language.lower() !\u003d registry_language:"},{"line_number":602,"context_line":"                    LOG.debug(\u0027Found %(descr)s but its language %(reg_lang)s \u0027"},{"line_number":603,"context_line":"                              \u0027does not match the requested %(lang)s\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"6dc7fcdb_c5abda57","line":600,"in_reply_to":"5c9d41d2_03b23b76","updated":"2023-02-28 15:59:23.000000000","message":"Done","commit_id":"29d040eb881457638dd7d3beb5ea2285d9045fa0"}],"sushy/resources/registry/message_registry_file.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"bf321142864c49a4c3ed4dc8b601bfe6268d886d","unresolved":true,"context_lines":[{"line_number":123,"context_line":"        # language, in this case we can check if the registry language"},{"line_number":124,"context_line":"        # starts with the requested language."},{"line_number":125,"context_line":"        locations \u003d ["},{"line_number":126,"context_line":"            l for l in self.location if l.language.lower().startswith(language)"},{"line_number":127,"context_line":"        ]"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"        locations +\u003d ["}],"source_content_type":"text/x-python","patch_set":2,"id":"058dd6f4_4756bc1d","line":126,"updated":"2023-02-27 11:37:42.000000000","message":"same (basically you need language.lower().split(\u0027-\u0027, 1)[0])","commit_id":"f5b0aa4656e51cd6ee7924f84fcfa63f2f896023"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"388b82102f4e4529ec5294d7f0c8564d65075e53","unresolved":false,"context_lines":[{"line_number":123,"context_line":"        # language, in this case we can check if the registry language"},{"line_number":124,"context_line":"        # starts with the requested language."},{"line_number":125,"context_line":"        locations \u003d ["},{"line_number":126,"context_line":"            l for l in self.location if l.language.lower().startswith(language)"},{"line_number":127,"context_line":"        ]"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"        locations +\u003d ["}],"source_content_type":"text/x-python","patch_set":2,"id":"2981d666_e635c99c","line":126,"in_reply_to":"058dd6f4_4756bc1d","updated":"2023-02-28 00:07:36.000000000","message":"Done","commit_id":"f5b0aa4656e51cd6ee7924f84fcfa63f2f896023"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"29c174eeebd3a0a23c3154ed8706cff97b74f7bc","unresolved":false,"context_lines":[{"line_number":124,"context_line":"        # starts with the requested language."},{"line_number":125,"context_line":"        locations \u003d ["},{"line_number":126,"context_line":"            l for l in self.location"},{"line_number":127,"context_line":"            if l.language.lower().split(\u0027-\u0027, 1)[0] \u003d\u003d language"},{"line_number":128,"context_line":"        ]"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"        locations +\u003d ["}],"source_content_type":"text/x-python","patch_set":4,"id":"053709a2_3b2b2b42","line":127,"updated":"2023-03-01 11:23:00.000000000","message":"here as well (or l.language \u003d\u003d language)","commit_id":"bf12d67b333f03e1d8c622af3c61ee9c898d1d2f"}],"sushy/tests/unit/json_samples/bios_attribute_registry_zthardware.json":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"bf321142864c49a4c3ed4dc8b601bfe6268d886d","unresolved":true,"context_lines":[{"line_number":10062,"context_line":"  \"@odata.etag\": \"\\\"1627746301\\\"\","},{"line_number":10063,"context_line":"  \"Id\": \"BiosAttributeRegistryProt0.208.208.0\","},{"line_number":10064,"context_line":"  \"Description\": \"This registry defines a representation of BIOS Attribute instances\""},{"line_number":10065,"context_line":"}"}],"source_content_type":"application/json","patch_set":2,"id":"6d5f2076_fa44b69e","line":10065,"updated":"2023-02-27 11:37:42.000000000","message":"I suggest we don\u0027t commit 10k lines to the repo. We can trim it to a few interesting items of different types.","commit_id":"f5b0aa4656e51cd6ee7924f84fcfa63f2f896023"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"f7e6e51cea66923d8481e9e70e797c181fb625b7","unresolved":false,"context_lines":[{"line_number":10062,"context_line":"  \"@odata.etag\": \"\\\"1627746301\\\"\","},{"line_number":10063,"context_line":"  \"Id\": \"BiosAttributeRegistryProt0.208.208.0\","},{"line_number":10064,"context_line":"  \"Description\": \"This registry defines a representation of BIOS Attribute instances\""},{"line_number":10065,"context_line":"}"}],"source_content_type":"application/json","patch_set":2,"id":"2a9c361a_e59a79be","line":10065,"in_reply_to":"6d5f2076_fa44b69e","updated":"2023-02-27 11:45:17.000000000","message":"ack, I will remove most of the nested items to make it smaller","commit_id":"f5b0aa4656e51cd6ee7924f84fcfa63f2f896023"}]}