)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"9c64a39ecbbed6be7e6cd45e1f8313919a60b03b","unresolved":true,"context_lines":[{"line_number":9,"context_line":"virtualmedia mount on nvidia fails if a username and password"},{"line_number":10,"context_line":"is not provided(even if not required)."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Bug: 2071945"},{"line_number":13,"context_line":"Change-Id: I15d035357c775d422b9b1165b32a51453b4b907f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"6e193bb4_aa6bffaa","line":12,"updated":"2024-07-05 02:08:13.000000000","message":"The syntax should be Closes-Bug: #2071945","commit_id":"fa4aa032a3b82480422999010addc2cb41f0b1d7"},{"author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"change_message_id":"ef56731841dd301717323d02a9d0a74ba00eddba","unresolved":false,"context_lines":[{"line_number":9,"context_line":"virtualmedia mount on nvidia fails if a username and password"},{"line_number":10,"context_line":"is not provided(even if not required)."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Bug: 2071945"},{"line_number":13,"context_line":"Change-Id: I15d035357c775d422b9b1165b32a51453b4b907f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"a7b624bb_50dfc96f","line":12,"in_reply_to":"6e193bb4_aa6bffaa","updated":"2024-10-24 16:32:41.000000000","message":"Done","commit_id":"fa4aa032a3b82480422999010addc2cb41f0b1d7"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":1926,"name":"Derek Higgins","email":"derekh@redhat.com","username":"derekh"},"change_message_id":"3f2a2fbb43ddf0621f6c662062694271cd1ea14a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"cdee19b9_12a51d48","updated":"2024-07-04 14:28:58.000000000","message":"Holding until verified on the HW.","commit_id":"b892f914c2ee5f6772717ead0f50dcef06a06c31"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"f5f64e1ebaf9b1216796e283f4634c3091592a3c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"36928a8b_85e11cb8","updated":"2024-07-04 14:56:00.000000000","message":"thanks Derek, can you please move the bug to launchpad?","commit_id":"b892f914c2ee5f6772717ead0f50dcef06a06c31"},{"author":{"_account_id":1926,"name":"Derek Higgins","email":"derekh@redhat.com","username":"derekh"},"change_message_id":"66288874fe45e69ce5d13966aa5e87e3fbc280ab","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3b75fd02_949fa8ee","in_reply_to":"36928a8b_85e11cb8","updated":"2024-07-04 16:12:07.000000000","message":"Done, I am not able to close the storyboard version can you? \nhttps://storyboard.openstack.org/#!/story/2011167","commit_id":"b892f914c2ee5f6772717ead0f50dcef06a06c31"},{"author":{"_account_id":1926,"name":"Derek Higgins","email":"derekh@redhat.com","username":"derekh"},"change_message_id":"6844233fbcac573175be8be3d81d3265ed383b05","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"47414cb0_fbb51ad3","updated":"2024-07-05 08:03:27.000000000","message":"Holding until confirmed on HW","commit_id":"fa4aa032a3b82480422999010addc2cb41f0b1d7"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"9c64a39ecbbed6be7e6cd45e1f8313919a60b03b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"1fc3e194_c4453472","updated":"2024-07-05 02:08:13.000000000","message":"LGTM","commit_id":"fa4aa032a3b82480422999010addc2cb41f0b1d7"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"a24f422031d93062616aff2c2335c5b481525bd2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"f77ab4d9_d27adcb4","updated":"2024-09-24 07:28:53.000000000","message":"I think this is worth a release note","commit_id":"9a645f876fc61e2d4fb8901a67d0c41570efe803"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"df1962c02aec887e58e6e24bbe29f327da3d65b3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"5e9b7bf9_1b1a7e11","updated":"2024-10-22 16:38:22.000000000","message":"Please add release note. Please add requested comment about hardware this is working around (or reference bug number, that\u0027s OK too)","commit_id":"9a645f876fc61e2d4fb8901a67d0c41570efe803"},{"author":{"_account_id":1926,"name":"Derek Higgins","email":"derekh@redhat.com","username":"derekh"},"change_message_id":"29234ce5efea3b3d495d82bfb865e471251f3f20","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"cb32ce7c_bfe82faf","updated":"2024-09-10 13:13:20.000000000","message":"Removing the -1 \n\nThe patch has been tested with a nvidia dgx, logs show 3 InsertMedia requests each time adding new params to the payload\n\n2024-09-09 16:27:58.521 1 DEBUG sushy.connector [None req-b5d5b93b-8040-4f41-a262-5618f025a94a - - - - - -] HTTP request: POST https://mgmt-p42-h07-000-dgx.rdu3.labs.perfscale.redhat.com/redfish/v1/Managers/BMC/VirtualMedia/CD1/Actions/VirtualMedia.InsertMedia; headers: {\u0027Content-Type\u0027: \u0027application/json\u0027, \u0027OData-Version\u0027: \u00274.0\u0027, \u0027Accept-Encoding\u0027: \u0027identity\u0027}; body: {\u0027Image\u0027: \u0027https://10.10.129.59:6183/redfish/boot-df523443-914e-4076-bd94-4502d2a13571.iso\u0027}; blocking: False; timeout: 60; session arguments: {}; _op /usr/lib/python3.9/site-packages/sushy/connector.py:154\n2024-09-09 16:27:58.941 1 DEBUG sushy.connector [None req-b5d5b93b-8040-4f41-a262-5618f025a94a - - - - - -] HTTP request: POST https://mgmt-p42-h07-000-dgx.rdu3.labs.perfscale.redhat.com/redfish/v1/Managers/BMC/VirtualMedia/CD1/Actions/VirtualMedia.InsertMedia; headers: {\u0027Content-Type\u0027: \u0027application/json\u0027, \u0027OData-Version\u0027: \u00274.0\u0027, \u0027Accept-Encoding\u0027: \u0027identity\u0027}; body: {\u0027Image\u0027: \u0027https://10.10.129.59:6183/redfish/boot-df523443-914e-4076-bd94-4502d2a13571.iso\u0027, \u0027TransferProtocolType\u0027: \u0027HTTPS\u0027}; blocking: False; timeout: 60; session arguments: {}; _op /usr/lib/python3.9/site-packages/sushy/connector.py:154\n2024-09-09 16:27:59.413 1 DEBUG sushy.connector [None req-b5d5b93b-8040-4f41-a262-5618f025a94a - - - - - -] HTTP request: POST https://mgmt-p42-h07-000-dgx.rdu3.labs.perfscale.redhat.com/redfish/v1/Managers/BMC/VirtualMedia/CD1/Actions/VirtualMedia.InsertMedia; headers: {\u0027Content-Type\u0027: \u0027application/json\u0027, \u0027OData-Version\u0027: \u00274.0\u0027, \u0027Accept-Encoding\u0027: \u0027identity\u0027}; body: {\u0027Image\u0027: \u0027https://10.10.129.59:6183/redfish/boot-df523443-914e-4076-bd94-4502d2a13571.iso\u0027, \u0027TransferProtocolType\u0027: \u0027HTTPS\u0027, \u0027UserName\u0027: \u0027none\u0027, \u0027Password\u0027: \u0027***\u0027}; blocking: False; timeout: 60; session arguments: {}; _op /usr/lib/python3.9/site-packages/sushy/connector.py:154\n2024-09-09 16:28:00.064 1 INFO ironic.drivers.modules.redfish.boot [None req-b5d5b93b-8040-4f41-a262-5618f025a94a - - - - - -] Inserted boot media https://10.10.129.59:6183/redfish/boot-df523443-914e-4076-bd94-4502d2a13571.iso into VirtualMediaType.CD for node df523443-914e-4076-bd94-4502d2a13571ESC[00m","commit_id":"9a645f876fc61e2d4fb8901a67d0c41570efe803"},{"author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"change_message_id":"ef56731841dd301717323d02a9d0a74ba00eddba","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"c0bc3223_4ffb6d51","updated":"2024-10-24 16:32:41.000000000","message":"I think since this fixes an issue with real hardware it would be a backport candidate.","commit_id":"13bbed34e0279fdf957dbcfcfaf16f76f0c4d559"}],"sushy/resources/manager/virtual_media.py":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"7d8e7c8c43bf59614b290c4b93317c8c7710d0d9","unresolved":true,"context_lines":[{"line_number":132,"context_line":"            return True"},{"line_number":133,"context_line":"        return False"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"    def is_credentiasls_required(self, error\u003dNone):"},{"line_number":136,"context_line":"        \"\"\"Check the response code and body and in case of failure"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"        Try to determine if it happened due to missing Credentials"}],"source_content_type":"text/x-python","patch_set":2,"id":"48d43a35_db9f6678","line":135,"updated":"2024-07-04 15:56:33.000000000","message":"nit: spelling","commit_id":"9f4ef050ba833820188875935a6c36b91e727ef5"},{"author":{"_account_id":1926,"name":"Derek Higgins","email":"derekh@redhat.com","username":"derekh"},"change_message_id":"86daaafc05c1646a72e2122a5a50ae86af45b4f8","unresolved":false,"context_lines":[{"line_number":132,"context_line":"            return True"},{"line_number":133,"context_line":"        return False"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"    def is_credentiasls_required(self, error\u003dNone):"},{"line_number":136,"context_line":"        \"\"\"Check the response code and body and in case of failure"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"        Try to determine if it happened due to missing Credentials"}],"source_content_type":"text/x-python","patch_set":2,"id":"45523b2e_eabd5c07","line":135,"in_reply_to":"0f5505a1_547c01a4","updated":"2024-08-16 09:01:20.000000000","message":"Done","commit_id":"9f4ef050ba833820188875935a6c36b91e727ef5"},{"author":{"_account_id":1926,"name":"Derek Higgins","email":"derekh@redhat.com","username":"derekh"},"change_message_id":"66288874fe45e69ce5d13966aa5e87e3fbc280ab","unresolved":true,"context_lines":[{"line_number":132,"context_line":"            return True"},{"line_number":133,"context_line":"        return False"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"    def is_credentiasls_required(self, error\u003dNone):"},{"line_number":136,"context_line":"        \"\"\"Check the response code and body and in case of failure"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"        Try to determine if it happened due to missing Credentials"}],"source_content_type":"text/x-python","patch_set":2,"id":"0f5505a1_547c01a4","line":135,"in_reply_to":"48d43a35_db9f6678","updated":"2024-07-04 16:12:07.000000000","message":"thanks","commit_id":"9f4ef050ba833820188875935a6c36b91e727ef5"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"7d8e7c8c43bf59614b290c4b93317c8c7710d0d9","unresolved":true,"context_lines":[{"line_number":225,"context_line":"                    if payload.get(\u0027UserName\u0027) is None and \\"},{"line_number":226,"context_line":"                            self.is_credentiasls_required(error):"},{"line_number":227,"context_line":"                        payload[\u0027UserName\u0027] \u003d \"none\""},{"line_number":228,"context_line":"                        payload[\u0027Password\u0027] \u003d \"none\""},{"line_number":229,"context_line":"                        continue"},{"line_number":230,"context_line":"                    raise"},{"line_number":231,"context_line":"        self.invalidate()"}],"source_content_type":"text/x-python","patch_set":2,"id":"95229c9d_1aad4c35","line":228,"updated":"2024-07-04 15:56:33.000000000","message":"This is going to end up doing *both* the TransferMethod *and* Credentials workaround, is that desired behavior?","commit_id":"9f4ef050ba833820188875935a6c36b91e727ef5"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"9c64a39ecbbed6be7e6cd45e1f8313919a60b03b","unresolved":true,"context_lines":[{"line_number":225,"context_line":"                    if payload.get(\u0027UserName\u0027) is None and \\"},{"line_number":226,"context_line":"                            self.is_credentiasls_required(error):"},{"line_number":227,"context_line":"                        payload[\u0027UserName\u0027] \u003d \"none\""},{"line_number":228,"context_line":"                        payload[\u0027Password\u0027] \u003d \"none\""},{"line_number":229,"context_line":"                        continue"},{"line_number":230,"context_line":"                    raise"},{"line_number":231,"context_line":"        self.invalidate()"}],"source_content_type":"text/x-python","patch_set":2,"id":"ae09f8fa_e2cdd8e1","line":228,"in_reply_to":"463519a0_8666a8a6","updated":"2024-07-05 02:08:13.000000000","message":"which is a bit unlikely to happen, but who knows 😂","commit_id":"9f4ef050ba833820188875935a6c36b91e727ef5"},{"author":{"_account_id":1926,"name":"Derek Higgins","email":"derekh@redhat.com","username":"derekh"},"change_message_id":"66288874fe45e69ce5d13966aa5e87e3fbc280ab","unresolved":true,"context_lines":[{"line_number":225,"context_line":"                    if payload.get(\u0027UserName\u0027) is None and \\"},{"line_number":226,"context_line":"                            self.is_credentiasls_required(error):"},{"line_number":227,"context_line":"                        payload[\u0027UserName\u0027] \u003d \"none\""},{"line_number":228,"context_line":"                        payload[\u0027Password\u0027] \u003d \"none\""},{"line_number":229,"context_line":"                        continue"},{"line_number":230,"context_line":"                    raise"},{"line_number":231,"context_line":"        self.invalidate()"}],"source_content_type":"text/x-python","patch_set":2,"id":"463519a0_8666a8a6","line":228,"in_reply_to":"95229c9d_1aad4c35","updated":"2024-07-04 16:12:07.000000000","message":"It would only add both if the error matched is_transfer_method_required, and then on a 2nd attempt the error matched self.self.is_credentials_required\n\nit could potentially make a total of 4 attempts to attach the vmedia each one dealing with the previous error(if all 3 error conditions occurred)","commit_id":"9f4ef050ba833820188875935a6c36b91e727ef5"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"8832574a856dfdba3e9be00724722753b7f156fc","unresolved":true,"context_lines":[{"line_number":197,"context_line":"                payload[\u0027Inserted\u0027] \u003d False"},{"line_number":198,"context_line":"            if not write_protected:"},{"line_number":199,"context_line":"                payload[\u0027WriteProtected\u0027] \u003d False"},{"line_number":200,"context_line":"            while True:"},{"line_number":201,"context_line":"                try:"},{"line_number":202,"context_line":"                    self._conn.post(target_uri, data\u003dpayload)"},{"line_number":203,"context_line":"                    break"}],"source_content_type":"text/x-python","patch_set":4,"id":"9b9afaab_14a2a97c","line":200,"updated":"2024-08-15 18:47:51.000000000","message":"The while loop makes me very nervous since basically this becomes a \"keep trying until success\" loop. Shouldn\u0027t we limit that?","commit_id":"e6bc338010078322ff04df96cbf4913b4441ded8"},{"author":{"_account_id":1926,"name":"Derek Higgins","email":"derekh@redhat.com","username":"derekh"},"change_message_id":"86daaafc05c1646a72e2122a5a50ae86af45b4f8","unresolved":false,"context_lines":[{"line_number":197,"context_line":"                payload[\u0027Inserted\u0027] \u003d False"},{"line_number":198,"context_line":"            if not write_protected:"},{"line_number":199,"context_line":"                payload[\u0027WriteProtected\u0027] \u003d False"},{"line_number":200,"context_line":"            while True:"},{"line_number":201,"context_line":"                try:"},{"line_number":202,"context_line":"                    self._conn.post(target_uri, data\u003dpayload)"},{"line_number":203,"context_line":"                    break"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a77e90f_909f45a3","line":200,"in_reply_to":"9b9afaab_14a2a97c","updated":"2024-08-16 09:01:20.000000000","message":"It shouldn\u0027t because each error handler condition with only get applied if it didn\u0027t happen in previous loops regardless I\u0027ve limited it to 4 just in case.","commit_id":"e6bc338010078322ff04df96cbf4913b4441ded8"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"df1962c02aec887e58e6e24bbe29f327da3d65b3","unresolved":true,"context_lines":[{"line_number":222,"context_line":"                        continue"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"                    # NOTE (derekh) we try to handle the case where"},{"line_number":225,"context_line":"                    # Credentials are required in the payload."},{"line_number":226,"context_line":"                    if payload.get(\u0027UserName\u0027) is None and \\"},{"line_number":227,"context_line":"                            self.is_credentials_required(error):"},{"line_number":228,"context_line":"                        payload[\u0027UserName\u0027] \u003d \"none\""}],"source_content_type":"text/x-python","patch_set":5,"id":"5ed0a171_35574e1f","line":225,"updated":"2024-10-22 16:38:22.000000000","message":"Can we explicitly note that this is a workaround for nvidia or reference the bug? This may help seed future efforts around OEM+Redfish","commit_id":"9a645f876fc61e2d4fb8901a67d0c41570efe803"},{"author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"change_message_id":"ef56731841dd301717323d02a9d0a74ba00eddba","unresolved":false,"context_lines":[{"line_number":222,"context_line":"                        continue"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"                    # NOTE (derekh) we try to handle the case where"},{"line_number":225,"context_line":"                    # Credentials are required in the payload."},{"line_number":226,"context_line":"                    if payload.get(\u0027UserName\u0027) is None and \\"},{"line_number":227,"context_line":"                            self.is_credentials_required(error):"},{"line_number":228,"context_line":"                        payload[\u0027UserName\u0027] \u003d \"none\""}],"source_content_type":"text/x-python","patch_set":5,"id":"97328691_17f76318","line":225,"in_reply_to":"5ed0a171_35574e1f","updated":"2024-10-24 16:32:41.000000000","message":"Done","commit_id":"9a645f876fc61e2d4fb8901a67d0c41570efe803"}]}