)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"3dc7a7f601d9b4f380641bd1a65c21f0df83fbaf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"6976edc6_8b2edab1","updated":"2024-10-22 16:45:34.000000000","message":"Removed ironic-week-prio as this is W-1 with requested changes pending","commit_id":"b134aa991490820b35855f0b4ab9187f07c99c54"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"25aa4a07d3eb2ace7e3a6a0258538511ddc04915","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"59979305_bc2939b0","updated":"2024-07-11 23:36:11.000000000","message":"Still in progress since I need to get some answers from the reporter regarding the error when other properties are missing and how it handles EjectMedia","commit_id":"b134aa991490820b35855f0b4ab9187f07c99c54"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"69192b07604988526efdee0a0a00f093e263b60c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"cec5d094_e84457b5","updated":"2024-07-16 11:49:47.000000000","message":"Thank you for the patch Iury, one question in-line","commit_id":"b134aa991490820b35855f0b4ab9187f07c99c54"}],"sushy/resources/manager/virtual_media.py":[{"author":{"_account_id":35929,"name":"Mahnoor Asghar","display_name":"Mahnoor Asghar","email":"masghar@redhat.com","username":"mahnoorasghar"},"change_message_id":"08c9c12978ad745f4b286a78f21ccb9b6eccd1b1","unresolved":true,"context_lines":[{"line_number":136,"context_line":"        \"\"\"Check if the hardware requires other mandatory properties"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"        Some hardware requires multiple properties to insert the virtual media"},{"line_number":139,"context_line":"        such as: WriteProtected, Inserted, TransferMethod and TransferProtocol"},{"line_number":140,"context_line":"        \"\"\""},{"line_number":141,"context_line":"        message \u003d \"Mandatory properties are: Image, TransferProtocolType, \" \\"},{"line_number":142,"context_line":"            \"Inserted, TransferMethod and WriteProtected\""}],"source_content_type":"text/x-python","patch_set":1,"id":"42d522e4_1ba8322f","line":139,"updated":"2024-09-27 17:25:57.000000000","message":"TransferProtocolType instead of TransferProtocol?","commit_id":"b134aa991490820b35855f0b4ab9187f07c99c54"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"c9e2a70a1e4ce4a0dfab2998ecb06647c32ca2c7","unresolved":true,"context_lines":[{"line_number":136,"context_line":"        \"\"\"Check if the hardware requires other mandatory properties"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"        Some hardware requires multiple properties to insert the virtual media"},{"line_number":139,"context_line":"        such as: WriteProtected, Inserted, TransferMethod and TransferProtocol"},{"line_number":140,"context_line":"        \"\"\""},{"line_number":141,"context_line":"        message \u003d \"Mandatory properties are: Image, TransferProtocolType, \" \\"},{"line_number":142,"context_line":"            \"Inserted, TransferMethod and WriteProtected\""}],"source_content_type":"text/x-python","patch_set":1,"id":"88973df8_1a92ec4b","line":139,"in_reply_to":"42d522e4_1ba8322f","updated":"2024-09-27 17:37:20.000000000","message":"right, I missed this in the docstring, tks Mahnoor!","commit_id":"b134aa991490820b35855f0b4ab9187f07c99c54"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"69192b07604988526efdee0a0a00f093e263b60c","unresolved":true,"context_lines":[{"line_number":221,"context_line":"                        else:"},{"line_number":222,"context_line":"                            raise"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"                elif self.hardware_requires_mandatory_properties(error):"},{"line_number":225,"context_line":"                    payload[\u0027WriteProtected\u0027] \u003d True"},{"line_number":226,"context_line":"                    payload[\u0027Inserted\u0027] \u003d True"},{"line_number":227,"context_line":"                    payload[\u0027TransferMethod\u0027] \u003d ("},{"line_number":228,"context_line":"                        \"Stream\" if transfer_method is None"},{"line_number":229,"context_line":"                        else transfer_method)"},{"line_number":230,"context_line":"                    payload[\u0027TransferProtocolType\u0027] \u003d ("},{"line_number":231,"context_line":"                        \"HTTPS\" if payload[\u0027Image\u0027].startswith(\u0027https://\u0027)"},{"line_number":232,"context_line":"                        else \"HTTP\")"},{"line_number":233,"context_line":"                else:"},{"line_number":234,"context_line":"                    raise"},{"line_number":235,"context_line":"        self.invalidate()"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f6b0566_314a06cf","line":232,"range":{"start_line":224,"start_character":0,"end_line":232,"end_character":36},"updated":"2024-07-16 11:49:47.000000000","message":"do we need send another POST request after adjusting payload, like we do in L216 and L220?","commit_id":"b134aa991490820b35855f0b4ab9187f07c99c54"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"3cf5f07cb666787e5f5eed5d0fbbebdc70488150","unresolved":true,"context_lines":[{"line_number":221,"context_line":"                        else:"},{"line_number":222,"context_line":"                            raise"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"                elif self.hardware_requires_mandatory_properties(error):"},{"line_number":225,"context_line":"                    payload[\u0027WriteProtected\u0027] \u003d True"},{"line_number":226,"context_line":"                    payload[\u0027Inserted\u0027] \u003d True"},{"line_number":227,"context_line":"                    payload[\u0027TransferMethod\u0027] \u003d ("},{"line_number":228,"context_line":"                        \"Stream\" if transfer_method is None"},{"line_number":229,"context_line":"                        else transfer_method)"},{"line_number":230,"context_line":"                    payload[\u0027TransferProtocolType\u0027] \u003d ("},{"line_number":231,"context_line":"                        \"HTTPS\" if payload[\u0027Image\u0027].startswith(\u0027https://\u0027)"},{"line_number":232,"context_line":"                        else \"HTTP\")"},{"line_number":233,"context_line":"                else:"},{"line_number":234,"context_line":"                    raise"},{"line_number":235,"context_line":"        self.invalidate()"}],"source_content_type":"text/x-python","patch_set":1,"id":"6a0a7043_4d6396e6","line":232,"range":{"start_line":224,"start_character":0,"end_line":232,"end_character":36},"in_reply_to":"1f6b0566_314a06cf","updated":"2024-07-23 12:45:18.000000000","message":"yeah we would need something like that, I will see if i can improve the whole logic above, so we don\u0027t end doing multiple requests","commit_id":"b134aa991490820b35855f0b4ab9187f07c99c54"}]}