)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"9305c2e7d6f93f567c4b57d15f3d1a1fed6a46d9","unresolved":true,"context_lines":[{"line_number":10,"context_line":"Managers attribute is used instead. This change enables sushy to detect"},{"line_number":11,"context_line":"this condition and retry the request, allowing sushy to support such"},{"line_number":12,"context_line":"hardware."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Ibc81e64b8ac0533024c203ea48003aea764901c3"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"0f54779b_0134a410","line":13,"updated":"2024-08-15 03:27:02.000000000","message":"can you please open a bug on launchpad with details about the problem?","commit_id":"178b7f72d9990295981d9eda7e59b2443420b1ef"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"44fa70d2e89e251aa4cf54e30bc7a640b5e8fc97","unresolved":false,"context_lines":[{"line_number":10,"context_line":"Managers attribute is used instead. This change enables sushy to detect"},{"line_number":11,"context_line":"this condition and retry the request, allowing sushy to support such"},{"line_number":12,"context_line":"hardware."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Ibc81e64b8ac0533024c203ea48003aea764901c3"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"bd2c5049_c7f9fc84","line":13,"in_reply_to":"0f54779b_0134a410","updated":"2024-08-15 06:00:00.000000000","message":"Done:\nhttps://bugs.launchpad.net/sushy/+bug/2077050\nHow to link it to change (I\u0027ve done Storyboard but not Launchpad bugs I think)?","commit_id":"178b7f72d9990295981d9eda7e59b2443420b1ef"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"44fa70d2e89e251aa4cf54e30bc7a640b5e8fc97","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"1f21159a_56e1cc35","updated":"2024-08-15 06:00:00.000000000","message":"Thank you for your review Iury, I addressed your comments in the new revision and/or inline.","commit_id":"178b7f72d9990295981d9eda7e59b2443420b1ef"}],"sushy/resources/system/system.py":[{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"9305c2e7d6f93f567c4b57d15f3d1a1fed6a46d9","unresolved":true,"context_lines":[{"line_number":521,"context_line":"                          \u0027System %s, aborting\u0027, self.identity)"},{"line_number":522,"context_line":"                # NOTE(janders) last_error may record only Managers and not"},{"line_number":523,"context_line":"                # ManagedBy MissingAttributeError with this approach"},{"line_number":524,"context_line":"                raise"},{"line_number":525,"context_line":"        return [manager.Manager(self._conn, path,"},{"line_number":526,"context_line":"                                redfish_version\u003dself.redfish_version,"},{"line_number":527,"context_line":"                                registries\u003dself.registries, root\u003dself.root)"}],"source_content_type":"text/x-python","patch_set":2,"id":"cf0f4a22_c2ef862c","line":524,"updated":"2024-08-15 03:27:02.000000000","message":"Worth adding two new unit tests\n1- Without ManagedBy and with Managers..\n2- Without ManagedBy and without Managers (just to be sure we will raise the exception)","commit_id":"178b7f72d9990295981d9eda7e59b2443420b1ef"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"44fa70d2e89e251aa4cf54e30bc7a640b5e8fc97","unresolved":false,"context_lines":[{"line_number":521,"context_line":"                          \u0027System %s, aborting\u0027, self.identity)"},{"line_number":522,"context_line":"                # NOTE(janders) last_error may record only Managers and not"},{"line_number":523,"context_line":"                # ManagedBy MissingAttributeError with this approach"},{"line_number":524,"context_line":"                raise"},{"line_number":525,"context_line":"        return [manager.Manager(self._conn, path,"},{"line_number":526,"context_line":"                                redfish_version\u003dself.redfish_version,"},{"line_number":527,"context_line":"                                registries\u003dself.registries, root\u003dself.root)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a89d3c8_786724a1","line":524,"in_reply_to":"cf0f4a22_c2ef862c","updated":"2024-08-15 06:00:00.000000000","message":"Done","commit_id":"178b7f72d9990295981d9eda7e59b2443420b1ef"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"44fa70d2e89e251aa4cf54e30bc7a640b5e8fc97","unresolved":false,"context_lines":[{"line_number":521,"context_line":"                          \u0027System %s, aborting\u0027, self.identity)"},{"line_number":522,"context_line":"                # NOTE(janders) last_error may record only Managers and not"},{"line_number":523,"context_line":"                # ManagedBy MissingAttributeError with this approach"},{"line_number":524,"context_line":"                raise"},{"line_number":525,"context_line":"        return [manager.Manager(self._conn, path,"},{"line_number":526,"context_line":"                                redfish_version\u003dself.redfish_version,"},{"line_number":527,"context_line":"                                registries\u003dself.registries, root\u003dself.root)"}],"source_content_type":"text/x-python","patch_set":2,"id":"f258ffcf_5d12a02d","line":524,"in_reply_to":"cf0f4a22_c2ef862c","updated":"2024-08-15 06:00:00.000000000","message":"Done","commit_id":"178b7f72d9990295981d9eda7e59b2443420b1ef"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"cc25dd9069622dd99316db5cd01f38fd062c8b14","unresolved":true,"context_lines":[{"line_number":520,"context_line":"                LOG.error(\u0027Both ManagedBy and Managers attributes missing for \u0027"},{"line_number":521,"context_line":"                          \u0027System %s, aborting\u0027, self.identity)"},{"line_number":522,"context_line":"                # NOTE(janders) last_error may record only Managers and not"},{"line_number":523,"context_line":"                # ManagedBy MissingAttributeError with this approach"},{"line_number":524,"context_line":"                raise"},{"line_number":525,"context_line":"        return [manager.Manager(self._conn, path,"},{"line_number":526,"context_line":"                                redfish_version\u003dself.redfish_version,"}],"source_content_type":"text/x-python","patch_set":3,"id":"f2607668_1a26c3ae","line":523,"updated":"2024-08-15 08:51:52.000000000","message":"Correct. I\u0027d prefer we saved the original exception or compose a new one that mentions both paths.","commit_id":"52363b4af597defdd27802ea01c3613d0f16ced7"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"0ef8f57256b01640e9d08a7dd72da92882663fce","unresolved":false,"context_lines":[{"line_number":520,"context_line":"                LOG.error(\u0027Both ManagedBy and Managers attributes missing for \u0027"},{"line_number":521,"context_line":"                          \u0027System %s, aborting\u0027, self.identity)"},{"line_number":522,"context_line":"                # NOTE(janders) last_error may record only Managers and not"},{"line_number":523,"context_line":"                # ManagedBy MissingAttributeError with this approach"},{"line_number":524,"context_line":"                raise"},{"line_number":525,"context_line":"        return [manager.Manager(self._conn, path,"},{"line_number":526,"context_line":"                                redfish_version\u003dself.redfish_version,"}],"source_content_type":"text/x-python","patch_set":3,"id":"8b11a65b_c34d47fe","line":523,"in_reply_to":"f2607668_1a26c3ae","updated":"2024-08-15 10:32:49.000000000","message":"Done","commit_id":"52363b4af597defdd27802ea01c3613d0f16ced7"}],"sushy/tests/unit/resources/system/test_system.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"0ef8f57256b01640e9d08a7dd72da92882663fce","unresolved":true,"context_lines":[{"line_number":911,"context_line":"    def test_managers_missing_ref(self):"},{"line_number":912,"context_line":"        # | GIVEN |"},{"line_number":913,"context_line":"        with open(\u0027sushy/tests/unit/json_samples/\u0027"},{"line_number":914,"context_line":"                  \u0027system_missing_manager_ref.json\u0027) as f:"},{"line_number":915,"context_line":"            settings_obj \u003d json.load(f)"},{"line_number":916,"context_line":"        self.json_doc.update(settings_obj)"},{"line_number":917,"context_line":"        self.sys_inst._parse_attributes(self.json_doc)"}],"source_content_type":"text/x-python","patch_set":4,"id":"62443f9e_032b9308","line":914,"updated":"2024-08-15 10:32:49.000000000","message":"Instead of having a whole new file, you could just load the full JSON and modify it afterwards (del self.json_doc[\u0027Links\u0027][\u0027ManagedBy\u0027] or something like that).","commit_id":"1266495a0664831991cfb22f8a473791f24945e3"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"2df3d5c40e43d41f0738ef89b4d00d93314f01b2","unresolved":false,"context_lines":[{"line_number":911,"context_line":"    def test_managers_missing_ref(self):"},{"line_number":912,"context_line":"        # | GIVEN |"},{"line_number":913,"context_line":"        with open(\u0027sushy/tests/unit/json_samples/\u0027"},{"line_number":914,"context_line":"                  \u0027system_missing_manager_ref.json\u0027) as f:"},{"line_number":915,"context_line":"            settings_obj \u003d json.load(f)"},{"line_number":916,"context_line":"        self.json_doc.update(settings_obj)"},{"line_number":917,"context_line":"        self.sys_inst._parse_attributes(self.json_doc)"}],"source_content_type":"text/x-python","patch_set":4,"id":"07f2ab72_1d8f9a72","line":914,"in_reply_to":"62443f9e_032b9308","updated":"2024-08-15 10:43:45.000000000","message":"good point, pushing new version, thanks!","commit_id":"1266495a0664831991cfb22f8a473791f24945e3"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"0f81d3bb850d4310ffabd1e195d0be54cea87bcc","unresolved":true,"context_lines":[{"line_number":893,"context_line":"    def test_managers_retry(self):"},{"line_number":894,"context_line":"        with open(\u0027sushy/tests/unit/json_samples/\u0027"},{"line_number":895,"context_line":"                  \u0027system_managedby_missing_manager_present.json\u0027) as f:"},{"line_number":896,"context_line":"            settings_obj \u003d json.load(f)"},{"line_number":897,"context_line":"        self.json_doc.update(settings_obj)"},{"line_number":898,"context_line":"        self.sys_inst._parse_attributes(self.json_doc)"},{"line_number":899,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"7ec802e0_cdf09fb1","line":896,"updated":"2024-08-15 10:49:18.000000000","message":"nit: just set this to self.json_doc, there seem to be no need for the 2nd object","commit_id":"dccdadec5ce86a6e1988e345f63e65eb93ccec05"}]}