)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"1a73e17ee6e91553fc0a5895684ff30560c91657","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a90c5034_409e6ef5","updated":"2024-09-17 20:14:54.000000000","message":"Suggestion, take it or leave it.","commit_id":"581820d39dc6da688330aaef4ade1fa13792822c"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"72b84fbda55fe3d1bbbb47a6bae545cb203dfc50","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"4fef8f8e_85c911d3","updated":"2024-09-18 12:22:48.000000000","message":"I noticed you dropped pycodestyle from the test reqs, any reason for that?\nalso please be aware that the pre-commit will always run with the default python binary, meaning that the behavior can be different between pre-commit and CI","commit_id":"f42d3db50b40398e2838d770caa2aecfbcd40a52"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"aab1898b1a28c7421fb63d48acaa80e8feb3c6c6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b374beb3_b54870e2","updated":"2024-09-17 23:01:49.000000000","message":"I\u0027ll note for other reviewers: this is changing the checked style *slightly*, at least it did when I made a similar change in Ironic (not to put it in tox, but for pre-commit itself).","commit_id":"f42d3db50b40398e2838d770caa2aecfbcd40a52"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"45f3fa3605c0fdb5848d950fec042b7e6f1b1555","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"6503413a_9de76443","updated":"2024-09-18 14:40:42.000000000","message":"pending discussion during PTG","commit_id":"f42d3db50b40398e2838d770caa2aecfbcd40a52"},{"author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"change_message_id":"50d4599b953fbc2c83460e8ecaae93bbfd3a0472","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"2f556785_950df228","in_reply_to":"4fef8f8e_85c911d3","updated":"2024-09-18 13:21:55.000000000","message":"You actually nailed why I advocate ruff over pycodestyle and flake8. The later two are heavily dependent on the version of Python they run under. Which is why locally I needed to have that change. I actually always failed sushy\u0027s pep8 checks locally but they passed on CI. On the other hand ruff is configured by targeting a specific Python and that\u0027s the syntax style that\u0027s used.\n\nAs far as pycodestyle, it wasn\u0027t dropped. It is still used. We\u0027re calling out via https://github.com/PyCQA/flake8 (flake8 is a python tool that glues together pycodestyle, pyflakes, mccabe, and third-party plugins to check the style and quality of some python code). So we\u0027re using pycodestyle via flake8.\n\nThis patch sucks for a code style standpoint but ultimately it maintains the exact behavior today. pre-commit uses python3, which is what tox was using to execute pycodestyle.\n\nYou can argue the function change I made is that flake8-import-order ACTUALLY gets applied now. It wasn\u0027t being applied by pycodestyle because it\u0027s a flake8 plugin so it needed to be run through that. It just happens that hacking is enforcing the same rules so there was no code style changes.","commit_id":"f42d3db50b40398e2838d770caa2aecfbcd40a52"},{"author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"change_message_id":"28ca47815c35a075db632db82e3176f68a5b944c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"ed66e2e6_9f738482","updated":"2024-11-09 18:46:27.000000000","message":"recheck","commit_id":"360cfc50701283598c13e972bce67cf91f09146f"}],"doc/source/conf.py":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"1a73e17ee6e91553fc0a5895684ff30560c91657","unresolved":true,"context_lines":[{"line_number":22,"context_line":"extensions \u003d ["},{"line_number":23,"context_line":"    \u0027sphinxcontrib.apidoc\u0027,"},{"line_number":24,"context_line":"    # \u0027sphinx.ext.intersphinx\u0027,"},{"line_number":25,"context_line":"    \u0027openstackdocstheme\u0027"},{"line_number":26,"context_line":"]"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"# autodoc generation is a bit aggressive and a nuisance when doing heavy"}],"source_content_type":"text/x-python","patch_set":1,"id":"6e0b40cf_1f295d0e","line":25,"updated":"2024-09-17 20:14:54.000000000","message":"honestly, we should exclude this file from formatting IMO, it\u0027s a sphinx config file moreso than an actual python file (we should not force sphinx-based stuff to comply with our style)","commit_id":"581820d39dc6da688330aaef4ade1fa13792822c"},{"author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"change_message_id":"4cb4c5f6672bda86eff094b80d11dc1f715fb353","unresolved":false,"context_lines":[{"line_number":22,"context_line":"extensions \u003d ["},{"line_number":23,"context_line":"    \u0027sphinxcontrib.apidoc\u0027,"},{"line_number":24,"context_line":"    # \u0027sphinx.ext.intersphinx\u0027,"},{"line_number":25,"context_line":"    \u0027openstackdocstheme\u0027"},{"line_number":26,"context_line":"]"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"# autodoc generation is a bit aggressive and a nuisance when doing heavy"}],"source_content_type":"text/x-python","patch_set":1,"id":"712bcf7e_bef832de","line":25,"in_reply_to":"6e0b40cf_1f295d0e","updated":"2024-11-10 22:19:09.000000000","message":"Done","commit_id":"581820d39dc6da688330aaef4ade1fa13792822c"}]}