)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"e11c0a810266dd89521a81ea192cfa5253b007e7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"e3d427f1_382f93d1","updated":"2024-10-11 08:48:38.000000000","message":"Thank you, this looks good at a glance, I\u0027m a bit puzzled by the copyright change in port.py, but I guess that\u0027s fine as it is basically a new module.\nJust one thing for now, please rewrite the release note considering that this will be read by final users/operators that not necessarily have knowledge of internals, thanks!","commit_id":"79bbad6d81c0e15a918c0fd1734ab2259f239aed"},{"author":{"_account_id":37363,"name":"Scott Tran","email":"transt@gmail.com","username":"transt"},"change_message_id":"6f6bf6fe59fd7fe064ba16a72625478723072334","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"092a3c75_f9a1c150","in_reply_to":"e3d427f1_382f93d1","updated":"2024-10-12 21:49:54.000000000","message":"Updated the release note","commit_id":"79bbad6d81c0e15a918c0fd1734ab2259f239aed"},{"author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"change_message_id":"ad1c6ef135d3b752f38ed002d1943028c5de53e3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"bb806ef5_d29940fa","updated":"2024-10-16 22:05:33.000000000","message":"So I wanted to add that Scott moved the existing NetworkPort to network_port.py to match the style of the rest of Sushy and remain consistent with 1 DMTF object per Python file. He then added Port as port.py. Since this has all been squashed into one commit that\u0027s not evident from looking at the diff.","commit_id":"ecdc7e70edfd582829095766e2f469fa82035d2d"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"446d35f72e65aa5c3a80b1eeb25ca56f1490f032","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"cd71ed3c_cceaf68c","updated":"2024-10-23 07:30:29.000000000","message":"thanks! this looks ok to me, please update the release note as Jay suggested and let\u0027s wait for sushy release before landing it since this is potentially a breaking change","commit_id":"ecdc7e70edfd582829095766e2f469fa82035d2d"},{"author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"change_message_id":"fd0eaf221001a69df855a9b7f9b0e1b3668fb3b5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"3854e3e7_77b3c00d","updated":"2024-10-29 22:39:43.000000000","message":"@jay@jvf.cc \u0026 @elfosardo@gmail.com How about this change? Now the port piece is higher up since this maps to physical ports and is more than just network. Now there\u0027s no change to the API surface at all.","commit_id":"ba4a6d1cf3f76df4c5ed554de6eb873201a14db8"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"7484d195362ea4f303f7d24ffba0313c856f0ef3","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"4b1f0a4e_7a405e75","updated":"2024-11-06 17:00:32.000000000","message":"lgtm; but this is a large change in sushy and that\u0027s not my area of expertise so I\u0027d rather not be the second +2","commit_id":"ba4a6d1cf3f76df4c5ed554de6eb873201a14db8"}],"releasenotes/notes/add-port-e57ec6759ee70bf7.yaml":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"5f49b0a02cd2b0e75be9db29d9761265200b53f6","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Adds support for the ``Port`` resource to the library."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"a4db88d8_163b7f5f","line":3,"updated":"2024-10-22 17:15:20.000000000","message":"As this is a library, we need to also notate the moving of any public modules in the library.","commit_id":"ecdc7e70edfd582829095766e2f469fa82035d2d"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"afb3d0260a08974c1f78a365059b59a735bd110d","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Adds support for the ``Port`` resource to the library."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"c082f3fe_941c8be3","line":3,"in_reply_to":"a4db88d8_163b7f5f","updated":"2024-10-22 17:16:20.000000000","message":"note: +1 is reflective of my nervousness about core reviewing a sushy change of this size","commit_id":"ecdc7e70edfd582829095766e2f469fa82035d2d"},{"author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"change_message_id":"c404e4f432845fb0fa72de836bcbc7d2a2d99d30","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Adds support for the ``Port`` resource to the library."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"2022b1fd_d07c28fb","line":3,"in_reply_to":"c082f3fe_941c8be3","updated":"2024-10-29 22:52:01.000000000","message":"Acknowledged","commit_id":"ecdc7e70edfd582829095766e2f469fa82035d2d"}]}