)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"6514ed6d1349473494e8d8b248abfde0cf7f83cd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c3a997d1_f8328b55","updated":"2025-05-08 11:16:55.000000000","message":"Thank you for your review Dmitry. Comments inline.","commit_id":"94eaf346a98df529bcd6cad8cf1543f94c79edd0"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"c24ce01a3eb68c215503d4a3f4b7defd0cf97eb0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"39d4ed77_8340dbe1","updated":"2025-05-22 11:54:24.000000000","message":"CI is currently broken, once we get it fixed I will recheck","commit_id":"595ffbcff4a53eb73fdedb9587ba421558ef6967"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"b5d04594c66cc5a8c9c51f7b400ed1550428080c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"f6eae866_e230556d","updated":"2025-05-22 00:09:12.000000000","message":"Thank you for your reviews Dmitry and Iury, pushed revised patch.","commit_id":"595ffbcff4a53eb73fdedb9587ba421558ef6967"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"566b13640a1a331b5502b2fda342979654b7abb0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"e7e9907f_ce4637ea","updated":"2025-05-22 11:53:25.000000000","message":"recheck","commit_id":"595ffbcff4a53eb73fdedb9587ba421558ef6967"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"4d0265fc5fc51219cf910499e2b65e1ea6ea5c24","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"2a665237_dc38f85f","updated":"2025-05-22 00:15:11.000000000","message":"thanks Jacob!","commit_id":"595ffbcff4a53eb73fdedb9587ba421558ef6967"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"a1cfceeebd1f578016f4309a807fff307e9d9273","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"6907ca9a_e7a0e7a3","updated":"2025-05-22 00:56:47.000000000","message":"the test was passing before and there were no significant code changes\n/recheck","commit_id":"595ffbcff4a53eb73fdedb9587ba421558ef6967"}],"releasenotes/notes/supermicro-vmedia-dev-workaround-cc7a870c9a99d92b.yaml":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"649e43b4ef6cb389c9dbe1ecaba3b3c015b02852","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fixes incompatibility with SuperMicro models which use \u0027Cd\u0027 device"},{"line_number":5,"context_line":"    string for virtual media boot as opposed to \u0027UsbCd\u0027 typical to most"},{"line_number":6,"context_line":"    SuperMicro servers."},{"line_number":7,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"43580797_63469735","line":4,"updated":"2025-05-21 11:59:39.000000000","message":"Let\u0027s mention the one model that we\u0027re actually fixing. We don\u0027t know if there are other models that are affected.","commit_id":"a6b35549c8ebbec880f4b4a484aea342f55e2292"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"b5d04594c66cc5a8c9c51f7b400ed1550428080c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fixes incompatibility with SuperMicro models which use \u0027Cd\u0027 device"},{"line_number":5,"context_line":"    string for virtual media boot as opposed to \u0027UsbCd\u0027 typical to most"},{"line_number":6,"context_line":"    SuperMicro servers."},{"line_number":7,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"368de435_319cdbf1","line":4,"in_reply_to":"43580797_63469735","updated":"2025-05-22 00:09:12.000000000","message":"Good point - this was a leftover from the earlier iteration where I was hoping we\u0027ll get to test more models (and positive they will be affected to). Let\u0027s stick with the facts, shall we :). Rephrased it and added the model.","commit_id":"a6b35549c8ebbec880f4b4a484aea342f55e2292"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"d14fc72bb8172b9b374ab8e8a2d8f461d24b4548","unresolved":true,"context_lines":[{"line_number":4,"context_line":"    Fixes incompatibility with SuperMicro models which use \u0027Cd\u0027 device"},{"line_number":5,"context_line":"    string for virtual media boot as opposed to \u0027UsbCd\u0027 typical to most"},{"line_number":6,"context_line":"    SuperMicro servers."},{"line_number":7,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"7d360621_aba0b0cc","line":7,"updated":"2025-05-21 15:07:57.000000000","message":"since you will push a new version you can remove the empty lines on the release note \u003d)","commit_id":"a6b35549c8ebbec880f4b4a484aea342f55e2292"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"b5d04594c66cc5a8c9c51f7b400ed1550428080c","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    Fixes incompatibility with SuperMicro models which use \u0027Cd\u0027 device"},{"line_number":5,"context_line":"    string for virtual media boot as opposed to \u0027UsbCd\u0027 typical to most"},{"line_number":6,"context_line":"    SuperMicro servers."},{"line_number":7,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"8e063738_43cb7fe4","line":7,"in_reply_to":"7d360621_aba0b0cc","updated":"2025-05-22 00:09:12.000000000","message":"Well spotted, thank you Iury. Should be all good in the latest revision.","commit_id":"a6b35549c8ebbec880f4b4a484aea342f55e2292"}],"sushy/resources/system/system.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"55fd0bda8722a81f126dd10816c8857374278f8f","unresolved":true,"context_lines":[{"line_number":123,"context_line":"    name \u003d base.Field(\u0027Name\u0027)"},{"line_number":124,"context_line":"    \"\"\"The system name\"\"\""},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"    model \u003d base.Field(\u0027Model\u0027)"},{"line_number":127,"context_line":"    \"\"\"The system model\"\"\""},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"    part_number \u003d base.Field(\u0027PartNumber\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5fceef74_980d86a1","line":126,"updated":"2025-05-08 10:48:37.000000000","message":"nit: model comes before name","commit_id":"94eaf346a98df529bcd6cad8cf1543f94c79edd0"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"6514ed6d1349473494e8d8b248abfde0cf7f83cd","unresolved":false,"context_lines":[{"line_number":123,"context_line":"    name \u003d base.Field(\u0027Name\u0027)"},{"line_number":124,"context_line":"    \"\"\"The system name\"\"\""},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"    model \u003d base.Field(\u0027Model\u0027)"},{"line_number":127,"context_line":"    \"\"\"The system model\"\"\""},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"    part_number \u003d base.Field(\u0027PartNumber\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7c0424cd_5bb11fb3","line":126,"in_reply_to":"5fceef74_980d86a1","updated":"2025-05-08 11:16:55.000000000","message":"Thank you, good pickup.","commit_id":"94eaf346a98df529bcd6cad8cf1543f94c79edd0"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"55fd0bda8722a81f126dd10816c8857374278f8f","unresolved":true,"context_lines":[{"line_number":290,"context_line":"            # vMedia. If \"CD\" is selected, boot fails even if vMedia is"},{"line_number":291,"context_line":"            # inserted. This code detects a case where a SuperMicro machine is"},{"line_number":292,"context_line":"            # about to attempt boot from CD and overrides the boot device to"},{"line_number":293,"context_line":"            # UsbCd instead which makes boot from vMedia work as expected."},{"line_number":294,"context_line":"            if (self.manufacturer and self.manufacturer.lower() \u003d\u003d \u0027supermicro\u0027"},{"line_number":295,"context_line":"                    and self.model and self.model.lower() !\u003d \u0027ars-111gl-nhr\u0027"},{"line_number":296,"context_line":"                    and target \u003d\u003d sys_cons.BootSource.CD"}],"source_content_type":"text/x-python","patch_set":1,"id":"fe502413_9575314a","line":293,"updated":"2025-05-08 10:48:37.000000000","message":"Can you update this comment?","commit_id":"94eaf346a98df529bcd6cad8cf1543f94c79edd0"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"6514ed6d1349473494e8d8b248abfde0cf7f83cd","unresolved":false,"context_lines":[{"line_number":290,"context_line":"            # vMedia. If \"CD\" is selected, boot fails even if vMedia is"},{"line_number":291,"context_line":"            # inserted. This code detects a case where a SuperMicro machine is"},{"line_number":292,"context_line":"            # about to attempt boot from CD and overrides the boot device to"},{"line_number":293,"context_line":"            # UsbCd instead which makes boot from vMedia work as expected."},{"line_number":294,"context_line":"            if (self.manufacturer and self.manufacturer.lower() \u003d\u003d \u0027supermicro\u0027"},{"line_number":295,"context_line":"                    and self.model and self.model.lower() !\u003d \u0027ars-111gl-nhr\u0027"},{"line_number":296,"context_line":"                    and target \u003d\u003d sys_cons.BootSource.CD"}],"source_content_type":"text/x-python","patch_set":1,"id":"6859c5fa_8a6f7b61","line":293,"in_reply_to":"fe502413_9575314a","updated":"2025-05-08 11:16:55.000000000","message":"Done","commit_id":"94eaf346a98df529bcd6cad8cf1543f94c79edd0"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"55fd0bda8722a81f126dd10816c8857374278f8f","unresolved":true,"context_lines":[{"line_number":292,"context_line":"            # about to attempt boot from CD and overrides the boot device to"},{"line_number":293,"context_line":"            # UsbCd instead which makes boot from vMedia work as expected."},{"line_number":294,"context_line":"            if (self.manufacturer and self.manufacturer.lower() \u003d\u003d \u0027supermicro\u0027"},{"line_number":295,"context_line":"                    and self.model and self.model.lower() !\u003d \u0027ars-111gl-nhr\u0027"},{"line_number":296,"context_line":"                    and target \u003d\u003d sys_cons.BootSource.CD"},{"line_number":297,"context_line":"                    and sys_cons.BootSource.USB_CD.value"},{"line_number":298,"context_line":"                    in self.boot.allowed_values):"}],"source_content_type":"text/x-python","patch_set":1,"id":"11a3cfb0_a680abb4","line":295,"updated":"2025-05-08 10:48:37.000000000","message":"Is it really one model or we just don\u0027t know?\n\nCan we say that ARM machines always have the new behavior? You can probably figure out the CPU architecture.","commit_id":"94eaf346a98df529bcd6cad8cf1543f94c79edd0"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"6514ed6d1349473494e8d8b248abfde0cf7f83cd","unresolved":true,"context_lines":[{"line_number":292,"context_line":"            # about to attempt boot from CD and overrides the boot device to"},{"line_number":293,"context_line":"            # UsbCd instead which makes boot from vMedia work as expected."},{"line_number":294,"context_line":"            if (self.manufacturer and self.manufacturer.lower() \u003d\u003d \u0027supermicro\u0027"},{"line_number":295,"context_line":"                    and self.model and self.model.lower() !\u003d \u0027ars-111gl-nhr\u0027"},{"line_number":296,"context_line":"                    and target \u003d\u003d sys_cons.BootSource.CD"},{"line_number":297,"context_line":"                    and sys_cons.BootSource.USB_CD.value"},{"line_number":298,"context_line":"                    in self.boot.allowed_values):"}],"source_content_type":"text/x-python","patch_set":1,"id":"ed3ece12_087f8cbd","line":295,"in_reply_to":"11a3cfb0_a680abb4","updated":"2025-05-08 11:16:55.000000000","message":"I don\u0027t know, however it is a good question. It prompted me looking at SMC brochure: https://www.supermicro.com/datasheet/datasheet_Arm-Ampere.pdf\n\nI see they have a NC-SI NIC - I wonder if all the ARM SMCs with NC-SI NIC are likely to behave like this? *111*/*211* models are all NC-SI based however *110*/*210*/*520* may not be. I will ask Reporters to see if we could look at a broader set of hardware.","commit_id":"94eaf346a98df529bcd6cad8cf1543f94c79edd0"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"10a721181fb88274f32d592fec42a547bad3db99","unresolved":false,"context_lines":[{"line_number":292,"context_line":"            # about to attempt boot from CD and overrides the boot device to"},{"line_number":293,"context_line":"            # UsbCd instead which makes boot from vMedia work as expected."},{"line_number":294,"context_line":"            if (self.manufacturer and self.manufacturer.lower() \u003d\u003d \u0027supermicro\u0027"},{"line_number":295,"context_line":"                    and self.model and self.model.lower() !\u003d \u0027ars-111gl-nhr\u0027"},{"line_number":296,"context_line":"                    and target \u003d\u003d sys_cons.BootSource.CD"},{"line_number":297,"context_line":"                    and sys_cons.BootSource.USB_CD.value"},{"line_number":298,"context_line":"                    in self.boot.allowed_values):"}],"source_content_type":"text/x-python","patch_set":1,"id":"e72e3bfd_21802b57","line":295,"in_reply_to":"ed3ece12_087f8cbd","updated":"2025-05-20 02:08:29.000000000","message":"I was unable to secure access to any other SuperMicro-ARM hardware so for the time being we will work under the assumption this is the only model with this behaviour, however I am open to reconsider this once more models become available.","commit_id":"94eaf346a98df529bcd6cad8cf1543f94c79edd0"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"649e43b4ef6cb389c9dbe1ecaba3b3c015b02852","unresolved":true,"context_lines":[{"line_number":297,"context_line":"            # UsbCd if required, depending on the model. This makes boot from"},{"line_number":298,"context_line":"            # vMedia work as expected on both variants."},{"line_number":299,"context_line":"            if (self.manufacturer and self.manufacturer.lower() \u003d\u003d \u0027supermicro\u0027"},{"line_number":300,"context_line":"                    and self.model and self.model.lower() not in"},{"line_number":301,"context_line":"                    self._supermicro_models_cd_vmedia"},{"line_number":302,"context_line":"                    and target \u003d\u003d sys_cons.BootSource.CD"},{"line_number":303,"context_line":"                    and sys_cons.BootSource.USB_CD.value"}],"source_content_type":"text/x-python","patch_set":3,"id":"c84f9a9e_7fdcb2bd","line":300,"updated":"2025-05-21 11:59:39.000000000","message":"nit: you don\u0027t need the first check on self.model: None is not in _supermicro_models_cd_vmedia","commit_id":"a6b35549c8ebbec880f4b4a484aea342f55e2292"},{"author":{"_account_id":32177,"name":"Jacob Anders","email":"jacob-anders-dev@proton.me","username":"janders"},"change_message_id":"b5d04594c66cc5a8c9c51f7b400ed1550428080c","unresolved":false,"context_lines":[{"line_number":297,"context_line":"            # UsbCd if required, depending on the model. This makes boot from"},{"line_number":298,"context_line":"            # vMedia work as expected on both variants."},{"line_number":299,"context_line":"            if (self.manufacturer and self.manufacturer.lower() \u003d\u003d \u0027supermicro\u0027"},{"line_number":300,"context_line":"                    and self.model and self.model.lower() not in"},{"line_number":301,"context_line":"                    self._supermicro_models_cd_vmedia"},{"line_number":302,"context_line":"                    and target \u003d\u003d sys_cons.BootSource.CD"},{"line_number":303,"context_line":"                    and sys_cons.BootSource.USB_CD.value"}],"source_content_type":"text/x-python","patch_set":3,"id":"f994e60e_6807ff8f","line":300,"in_reply_to":"c84f9a9e_7fdcb2bd","updated":"2025-05-22 00:09:12.000000000","message":"Good pickup, thank you. Also a leftover from the initial version with model hardcoded in the if condition. Unnecessary check removed.","commit_id":"a6b35549c8ebbec880f4b4a484aea342f55e2292"}]}