)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"ce97f3ab52a93838341856ba15ff0009a7853e05","unresolved":true,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2025-11-19 11:36:44 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Don\u0027t require Boot and Actions for Systems"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Closes-Bug: 2131942"},{"line_number":10,"context_line":"Change-Id: I4736cdeda37cd82a5081bb3e59e8ce8e5e2d2e9d"},{"line_number":11,"context_line":"Signed-off-by: Marcus Furlong \u003cfurlongm@gmail.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5c541f31_bb706c3d","line":8,"updated":"2025-11-21 21:48:59.000000000","message":"If we could get some more background on \"why\", it would be helpful for reviewing. Thanks!","commit_id":"6c09bcd8628962c4228e82e287ec783c43b1572f"},{"author":{"_account_id":6851,"name":"Marcus Furlong","email":"furlongm@gmail.com","username":"furlongm"},"change_message_id":"ac54dfb623a26c1d11947c72ff1583d1a88c0c16","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2025-11-19 11:36:44 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Don\u0027t require Boot and Actions for Systems"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Closes-Bug: 2131942"},{"line_number":10,"context_line":"Change-Id: I4736cdeda37cd82a5081bb3e59e8ce8e5e2d2e9d"},{"line_number":11,"context_line":"Signed-off-by: Marcus Furlong \u003cfurlongm@gmail.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"f73073b6_6337dd8c","line":8,"in_reply_to":"475e8d64_4d9f3762","updated":"2025-12-09 17:24:27.000000000","message":"Done","commit_id":"6c09bcd8628962c4228e82e287ec783c43b1572f"},{"author":{"_account_id":6851,"name":"Marcus Furlong","email":"furlongm@gmail.com","username":"furlongm"},"change_message_id":"a13b3fa385a89088c2b43e59c0f96fabfcae7f3c","unresolved":true,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2025-11-19 11:36:44 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Don\u0027t require Boot and Actions for Systems"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Closes-Bug: 2131942"},{"line_number":10,"context_line":"Change-Id: I4736cdeda37cd82a5081bb3e59e8ce8e5e2d2e9d"},{"line_number":11,"context_line":"Signed-off-by: Marcus Furlong \u003cfurlongm@gmail.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ae490596_4ca46e49","line":8,"in_reply_to":"5c541f31_bb706c3d","updated":"2025-11-22 00:30:30.000000000","message":"I thought the why being in the bug report would suffice? If not I can add it here too. In short, Systems without actions and boot are more commonplace now and sushy raises exceptions and fails on those systems. Many Nvidia systems fall into this category. Should I add this info to the commit message too?","commit_id":"6c09bcd8628962c4228e82e287ec783c43b1572f"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"5fb20de79a460515f98dab399cf6dfedbd17bd3d","unresolved":true,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2025-11-19 11:36:44 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Don\u0027t require Boot and Actions for Systems"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Closes-Bug: 2131942"},{"line_number":10,"context_line":"Change-Id: I4736cdeda37cd82a5081bb3e59e8ce8e5e2d2e9d"},{"line_number":11,"context_line":"Signed-off-by: Marcus Furlong \u003cfurlongm@gmail.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"475e8d64_4d9f3762","line":8,"in_reply_to":"ae490596_4ca46e49","updated":"2025-11-25 14:34:20.000000000","message":"Generally we still expect some detail in the commit message, for example if launchpad one day implodes, there is at least some inline documented rationale.","commit_id":"6c09bcd8628962c4228e82e287ec783c43b1572f"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":6851,"name":"Marcus Furlong","email":"furlongm@gmail.com","username":"furlongm"},"change_message_id":"a13b3fa385a89088c2b43e59c0f96fabfcae7f3c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c3c35937_45a9927f","updated":"2025-11-22 00:30:30.000000000","message":"I thought the why being in the bug report would suffice? If not, I can add it here too. In short, Systems without actions and boot are more commonplace now and sushy raises exceptions and fails on those systems. Many Nvidia systems fall into this category. Should I add this info to the commit message too?","commit_id":"6c09bcd8628962c4228e82e287ec783c43b1572f"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"11b4502f82bbabe0ae4ea0bf1a85e4a33662d8d7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"9ec7dfdf_3afb4aa4","updated":"2025-11-20 09:14:24.000000000","message":"please update the commit message and unit tests, thanks","commit_id":"6c09bcd8628962c4228e82e287ec783c43b1572f"}],"sushy/resources/system/system.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"948d022fce5c18571324b413cd1ec8dd4ecfbe02","unresolved":false,"context_lines":[{"line_number":278,"context_line":"            root\u003droot)"},{"line_number":279,"context_line":""},{"line_number":280,"context_line":"    def _get_reset_action_element(self):"},{"line_number":281,"context_line":"        reset_action \u003d self._actions.reset"},{"line_number":282,"context_line":"        # TODO(dtantsur): make this check also declarative?"},{"line_number":283,"context_line":"        if not reset_action:"},{"line_number":284,"context_line":"            raise exceptions.MissingActionError(action\u003d\u0027#ComputerSystem.Reset\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"14acf3df_6d6b7638","line":281,"updated":"2025-12-06 17:47:48.000000000","message":"This assumes _actions is not None and needs to be updated now","commit_id":"fba32446519deb33c9928b8df12f8ddf29322972"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"948d022fce5c18571324b413cd1ec8dd4ecfbe02","unresolved":false,"context_lines":[{"line_number":324,"context_line":""},{"line_number":325,"context_line":"        :returns: A set with the allowed values."},{"line_number":326,"context_line":"        \"\"\""},{"line_number":327,"context_line":"        if not self.boot.allowed_values:"},{"line_number":328,"context_line":"            LOG.warning(\u0027Could not figure out the allowed values for \u0027"},{"line_number":329,"context_line":"                        \u0027configuring the boot source for System %s\u0027,"},{"line_number":330,"context_line":"                        self.identity)"}],"source_content_type":"text/x-python","patch_set":4,"id":"6cdd1613_d2a5b158","line":327,"updated":"2025-12-06 17:47:48.000000000","message":"This call assumes self.boot is not None and needs to be updated","commit_id":"fba32446519deb33c9928b8df12f8ddf29322972"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"948d022fce5c18571324b413cd1ec8dd4ecfbe02","unresolved":false,"context_lines":[{"line_number":393,"context_line":"                    self._supermicro_models_cd_vmedia"},{"line_number":394,"context_line":"                    and target \u003d\u003d sys_cons.BootSource.CD"},{"line_number":395,"context_line":"                    and sys_cons.BootSource.USB_CD.value"},{"line_number":396,"context_line":"                    in self.boot.allowed_values):"},{"line_number":397,"context_line":"                LOG.debug(\u0027Boot from vMedia was requested on a SuperMicro\u0027"},{"line_number":398,"context_line":"                          \u0027machine. Overriding boot device from %s to %s.\u0027,"},{"line_number":399,"context_line":"                          target, sys_cons.BootSource.USB_CD)"}],"source_content_type":"text/x-python","patch_set":4,"id":"2cb1063d_fa217d77","line":396,"updated":"2025-12-06 17:47:48.000000000","message":"same","commit_id":"fba32446519deb33c9928b8df12f8ddf29322972"}]}
