)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"0acaf8b1fec09439487ff136aca4fa51e869ab99","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"5d57c440_5bc08944","updated":"2022-12-07 07:00:57.000000000","message":"Created https://review.opendev.org/c/openstack/swift-bench/+/866826 as an attempt to start some test scaffolding for the swiftbench cli at least.","commit_id":"0fe85015dbef0655f70fcdb0084f1a37ec169924"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"03abd2726553af6983ee712e6ace5880f94dfe2d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"752a3ff9_01863b12","updated":"2023-02-17 22:42:31.000000000","message":"Do we like the direction Matt\u0027s taking with https://review.opendev.org/c/openstack/swift-bench/+/866826? Assuming we do, I might work on a optparse-\u003eargparse patch on top of it, then stack *this* on top of *that*...","commit_id":"0fe85015dbef0655f70fcdb0084f1a37ec169924"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"6bb0d0a11b05283d91fc45ee7b6486b1c3ec05b0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"f36abaf1_853fd02c","updated":"2023-02-03 19:58:36.000000000","message":"i don\u0027t think hiding the _0 with num_containers \u003d 1 actually works yet\n\nthe --container-name on the command line seems to override the conf option\n\nthe lack of testing in this project means we\u0027re wasting a lot of time on functional validation and it might be worth some small investment if we\u0027re going to develop it further.","commit_id":"0fe85015dbef0655f70fcdb0084f1a37ec169924"},{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"9580b68792964279d631a247c0e2be7c17da3a9c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"17570255_f92daf4c","updated":"2022-12-07 04:53:24.000000000","message":"much better... man the state of the tests in swift-bench are horrible. A test would be good, but there doesn\u0027t seem to be much test infrastructure setup.\nSo that may be out of scope for your change, unless you want to work on some :) ","commit_id":"0fe85015dbef0655f70fcdb0084f1a37ec169924"},{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"a3646cba46bcadd2956676f6778a812ad70f6547","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"c32982bc_397dcde1","updated":"2025-02-27 05:07:39.000000000","message":"Landing this to for the new release.","commit_id":"897a2f9b3b7f308217f8c196bccb5cc5071653bf"}],"bin/swift-bench":[{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"f30578bc1449f4b582a4ac447f289a1d945b85f1","unresolved":true,"context_lines":[{"line_number":156,"context_line":"    if int(options.num_containers) \u003e 1 and options.container_name is not \u0027\u0027:"},{"line_number":157,"context_line":"        raise ValueError(\u0027--num-containers (%s) must be \u0027"},{"line_number":158,"context_line":"                         \u0027equal to 1 when --container-name (%s) is set\u0027 %"},{"line_number":159,"context_line":"                         (options.num_containers, options.container_name))"},{"line_number":160,"context_line":"    if options.concurrency is not \u0027\u0027:"},{"line_number":161,"context_line":"        options.put_concurrency \u003d options.concurrency"},{"line_number":162,"context_line":"        options.get_concurrency \u003d options.concurrency"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"5ee33c35_ada70e77","line":159,"updated":"2022-12-06 01:35:46.000000000","message":"Doesn\u0027t this break normal behaviour?\n\nBy default there will be an options.container_name that\u0027s loaded in from the config or DEFAULT config values which is using UUID.\n\nAdding it to the CLI is great, as this will override the config value.\nLook on line 164, when options.num_container is 1, the container_name will be \"\u003coptions.container_name\u003e_1\".\nSo it\u0027s not really container_name but container_name base.\n\nSo I think you need to remove this check as it isn\u0027t required. and change the help string to in line 121 to say something like:\n\n  Set the base container_name","commit_id":"943b098b18c07c38d0888827ddd558dd22e6c30c"},{"author":{"_account_id":34892,"name":"ASHWIN A NAIR","display_name":"indianwhocodes","email":"nairashwin952013@gmail.com","username":"indianwhocodes","status":"Nvidia"},"change_message_id":"7d639cdcdf0f3d07a3ddd583ce7a0e17e437dd4f","unresolved":false,"context_lines":[{"line_number":156,"context_line":"    if int(options.num_containers) \u003e 1 and options.container_name is not \u0027\u0027:"},{"line_number":157,"context_line":"        raise ValueError(\u0027--num-containers (%s) must be \u0027"},{"line_number":158,"context_line":"                         \u0027equal to 1 when --container-name (%s) is set\u0027 %"},{"line_number":159,"context_line":"                         (options.num_containers, options.container_name))"},{"line_number":160,"context_line":"    if options.concurrency is not \u0027\u0027:"},{"line_number":161,"context_line":"        options.put_concurrency \u003d options.concurrency"},{"line_number":162,"context_line":"        options.get_concurrency \u003d options.concurrency"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"94640a64_f47d3b61","line":159,"in_reply_to":"5ee33c35_ada70e77","updated":"2023-08-17 16:14:31.000000000","message":"Ack","commit_id":"943b098b18c07c38d0888827ddd558dd22e6c30c"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"384b3ed46adf398b562d7510eb079588f739490d","unresolved":true,"context_lines":[{"line_number":162,"context_line":"        options.get_concurrency \u003d options.concurrency"},{"line_number":163,"context_line":"        options.del_concurrency \u003d options.concurrency"},{"line_number":164,"context_line":"    options.containers \u003d [\u0027%s_%d\u0027 % (options.container_name, i)"},{"line_number":165,"context_line":"                          for i in range(int(options.num_containers))]"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"    # Turn \"yes\"/\"no\"/etc. strings to booleans"},{"line_number":168,"context_line":"    options.use_proxy \u003d config_true_value(options.use_proxy)"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"a29f37c3_c6bd3a22","line":165,"updated":"2022-12-06 06:17:54.000000000","message":"Might be reasonable to have something like\n\n if options.num_containers \u003d\u003d 1:\n     options.containers \u003d [options.container_name]\n else:\n     options.containers \u003d [\u0027%s_%d\u0027 % (options.container_name, i)\n                           for i in range(int(options.num_containers))]\n\nIt would still be a change in behavior, but I think a more-expected outcome.","commit_id":"943b098b18c07c38d0888827ddd558dd22e6c30c"},{"author":{"_account_id":34892,"name":"ASHWIN A NAIR","display_name":"indianwhocodes","email":"nairashwin952013@gmail.com","username":"indianwhocodes","status":"Nvidia"},"change_message_id":"7d639cdcdf0f3d07a3ddd583ce7a0e17e437dd4f","unresolved":false,"context_lines":[{"line_number":162,"context_line":"        options.get_concurrency \u003d options.concurrency"},{"line_number":163,"context_line":"        options.del_concurrency \u003d options.concurrency"},{"line_number":164,"context_line":"    options.containers \u003d [\u0027%s_%d\u0027 % (options.container_name, i)"},{"line_number":165,"context_line":"                          for i in range(int(options.num_containers))]"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"    # Turn \"yes\"/\"no\"/etc. strings to booleans"},{"line_number":168,"context_line":"    options.use_proxy \u003d config_true_value(options.use_proxy)"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"c260dbd1_4ff7d4ac","line":165,"in_reply_to":"a29f37c3_c6bd3a22","updated":"2023-08-17 16:14:31.000000000","message":"Ack","commit_id":"943b098b18c07c38d0888827ddd558dd22e6c30c"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"6bb0d0a11b05283d91fc45ee7b6486b1c3ec05b0","unresolved":true,"context_lines":[{"line_number":118,"context_line":"    parser.add_option(\u0027-C\u0027, \u0027--num-containers\u0027, dest\u003d\u0027num_containers\u0027,"},{"line_number":119,"context_line":"                      help\u003d\u0027Number of containers to distribute objects among\u0027)"},{"line_number":120,"context_line":"    parser.add_option(\u0027--container-name\u0027, dest\u003d\u0027container_name\u0027,"},{"line_number":121,"context_line":"                      help\u003d\u0027Set the base container_name\u0027)"},{"line_number":122,"context_line":"    parser.add_option(\u0027-x\u0027, \u0027--no-delete\u0027, dest\u003d\u0027delete\u0027, action\u003d\u0027store_false\u0027,"},{"line_number":123,"context_line":"                      help\u003d\u0027If set, will not delete the objects created\u0027)"},{"line_number":124,"context_line":"    parser.add_option(\u0027-V\u0027, \u0027--auth_version\u0027, dest\u003d\u0027auth_version\u0027,"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"5bc884e3_43116cdc","line":121,"updated":"2023-02-03 19:58:36.000000000","message":"i guess this is the main point of the change... it seems like we already support this option via config file?","commit_id":"0fe85015dbef0655f70fcdb0084f1a37ec169924"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"6bb0d0a11b05283d91fc45ee7b6486b1c3ec05b0","unresolved":true,"context_lines":[{"line_number":161,"context_line":"        options.containers \u003d [options.container_name]"},{"line_number":162,"context_line":"    else:"},{"line_number":163,"context_line":"        options.containers \u003d [\u0027%s_%d\u0027 % (options.container_name, i)"},{"line_number":164,"context_line":"                              for i in range(int(options.num_containers))]"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"    # Turn \"yes\"/\"no\"/etc. strings to booleans"},{"line_number":167,"context_line":"    options.use_proxy \u003d config_true_value(options.use_proxy)"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"a86240a7_01121d55","line":164,"updated":"2023-02-03 19:58:36.000000000","message":"i notice in this branch we convert options.num_containers to an int before we use it as such\n\nOMM when I tried to test this with `num_containers \u003d 1` in my bench.conf on my vsaio, I still got a container named `d9b155a78c3e41ccbdf2457ee55a2de8_0`\n\nusing pdb it appears this is because `options.num_containers \u003d\u003d \u00271\u0027` but `options.num_containers \u003d\u003d 1` is False","commit_id":"0fe85015dbef0655f70fcdb0084f1a37ec169924"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"03abd2726553af6983ee712e6ace5880f94dfe2d","unresolved":true,"context_lines":[{"line_number":161,"context_line":"        options.containers \u003d [options.container_name]"},{"line_number":162,"context_line":"    else:"},{"line_number":163,"context_line":"        options.containers \u003d [\u0027%s_%d\u0027 % (options.container_name, i)"},{"line_number":164,"context_line":"                              for i in range(int(options.num_containers))]"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"    # Turn \"yes\"/\"no\"/etc. strings to booleans"},{"line_number":167,"context_line":"    options.use_proxy \u003d config_true_value(options.use_proxy)"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"e666687a_2d07b8ce","line":164,"in_reply_to":"a86240a7_01121d55","updated":"2023-02-17 22:42:31.000000000","message":"Yeah, we probably should add `type\u003dint` all over the place when we\u0027re defining the parser.\n\nAlso, we should switch to argparse.\n\nOr, if that\u0027s a bit much yak to shave, just check `if int(options.num_containers) \u003d\u003d 1`.","commit_id":"0fe85015dbef0655f70fcdb0084f1a37ec169924"}]}