)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"ae2b8d1667eeace29db8ec8a5e53bee849609611","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"3d32f7b0_08530bbc","updated":"2023-02-17 22:16:44.000000000","message":"Feel free to merge if you like how I updated it -- I think there\u0027s only one patch that\u0027s both active and in conflict with this, and it should be fairly easy to apply (and test!) after the merge.","commit_id":"5065c4a559dcdbff0617e9d436402dce41eea330"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"c053c8be0b1680048c6966654fd8781b33e9680f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"83b75195_ee17199f","updated":"2023-02-17 22:57:28.000000000","message":"We really ought to have some func tests for this thing :-(","commit_id":"5065c4a559dcdbff0617e9d436402dce41eea330"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"cb6f254cace8c39fe7a03540e5bf53a449ebf915","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"f88f2c6a_f737a900","updated":"2023-07-10 22:44:54.000000000","message":"Forgot that this addressed the warning before I went and proposed \u0026 merged https://review.opendev.org/c/openstack/swift-bench/+/888069 -- Matt, how do you like what I\u0027ve done here? Should we go ahead and merge it?","commit_id":"5f803ae8fde7d5511e8b364ae7fd86fac09e48d3"},{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"13fa956e2999c479fe8dbc2ae07b460a2472e395","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"cf109bad_6a09ab5b","updated":"2023-07-11 06:32:45.000000000","message":"Thanks for the extra fixes Tim, this looks great.","commit_id":"5f803ae8fde7d5511e8b364ae7fd86fac09e48d3"}],"bin/swift-bench":[{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"b84c2094b6bea6f85191158ed66bda5ab05059bf","unresolved":true,"context_lines":[{"line_number":18,"context_line":"from swiftbench import main"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"if __name__ \u003d\u003d \u0027__main__\u0027:"},{"line_number":21,"context_line":"    sys.exit(main(sys.argv))"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"ca179f29_b4a0b322","line":21,"updated":"2022-12-07 07:02:44.000000000","message":"I do wonder if this needs to be:\n\n  sys.argv[1:]","commit_id":"1f6a3f8ee0101f727e3ed91cc4259581a7954a5a"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"662b37f9f52f165912c7686c6e7e6f43f1c2aaea","unresolved":false,"context_lines":[{"line_number":18,"context_line":"from swiftbench import main"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"if __name__ \u003d\u003d \u0027__main__\u0027:"},{"line_number":21,"context_line":"    sys.exit(main(sys.argv))"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"5d2e2821_3723373d","line":21,"in_reply_to":"ca179f29_b4a0b322","updated":"2023-02-18 00:29:14.000000000","message":"Done","commit_id":"1f6a3f8ee0101f727e3ed91cc4259581a7954a5a"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"ae2b8d1667eeace29db8ec8a5e53bee849609611","unresolved":true,"context_lines":[{"line_number":129,"context_line":""},{"line_number":130,"context_line":"    if len(sys.argv) \u003d\u003d 1:"},{"line_number":131,"context_line":"        parser.print_help()"},{"line_number":132,"context_line":"        sys.exit(1)"},{"line_number":133,"context_line":"    options, args \u003d parser.parse_args()"},{"line_number":134,"context_line":"    if options.saio:"},{"line_number":135,"context_line":"        CONF_DEFAULTS.update(SAIO_DEFAULTS)"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"73a5a27a_fb251298","side":"PARENT","line":132,"updated":"2023-02-17 22:16:44.000000000","message":"We lost this, but I don\u0027t think it\u0027s any great loss.","commit_id":"7d3192cdee334c7b38a806a699d76611ee8567ce"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"c053c8be0b1680048c6966654fd8781b33e9680f","unresolved":true,"context_lines":[{"line_number":15,"context_line":"# limitations under the License."},{"line_number":16,"context_line":"import sys"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from swiftbench import main"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"if __name__ \u003d\u003d \u0027__main__\u0027:"},{"line_number":21,"context_line":"    sys.exit(main(sys.argv[1:]))"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"589412a1_5ec373f7","line":18,"range":{"start_line":18,"start_character":5,"end_line":18,"end_character":16},"updated":"2023-02-17 22:57:28.000000000","message":"Needs to be `swiftbench.cli`","commit_id":"5065c4a559dcdbff0617e9d436402dce41eea330"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"662b37f9f52f165912c7686c6e7e6f43f1c2aaea","unresolved":false,"context_lines":[{"line_number":15,"context_line":"# limitations under the License."},{"line_number":16,"context_line":"import sys"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from swiftbench import main"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"if __name__ \u003d\u003d \u0027__main__\u0027:"},{"line_number":21,"context_line":"    sys.exit(main(sys.argv[1:]))"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"00adfcbd_47688aa1","line":18,"range":{"start_line":18,"start_character":5,"end_line":18,"end_character":16},"in_reply_to":"589412a1_5ec373f7","updated":"2023-02-18 00:29:14.000000000","message":"Done","commit_id":"5065c4a559dcdbff0617e9d436402dce41eea330"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"ae2b8d1667eeace29db8ec8a5e53bee849609611","unresolved":true,"context_lines":[{"line_number":18,"context_line":"from swiftbench import main"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"if __name__ \u003d\u003d \u0027__main__\u0027:"},{"line_number":21,"context_line":"    sys.exit(main(sys.argv[1:]))"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"9d0ac752_353b2163","line":21,"range":{"start_line":21,"start_character":13,"end_line":21,"end_character":17},"updated":"2023-02-17 22:16:44.000000000","message":"`main` always returns None, though, doesn\u0027t it?","commit_id":"5065c4a559dcdbff0617e9d436402dce41eea330"},{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"13fa956e2999c479fe8dbc2ae07b460a2472e395","unresolved":true,"context_lines":[{"line_number":18,"context_line":"from swiftbench import main"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"if __name__ \u003d\u003d \u0027__main__\u0027:"},{"line_number":21,"context_line":"    sys.exit(main(sys.argv[1:]))"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"74b2f59f_a5031288","line":21,"range":{"start_line":21,"start_character":13,"end_line":21,"end_character":17},"in_reply_to":"9d0ac752_353b2163","updated":"2023-07-11 06:32:45.000000000","message":"oh yeah.. it does.. happy to fix it. But seeing as it\u0027s already has a +2 and head of a chain, happy to fix this as a follow up too.","commit_id":"5065c4a559dcdbff0617e9d436402dce41eea330"}],"tests/test_cli.py":[{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"b84c2094b6bea6f85191158ed66bda5ab05059bf","unresolved":true,"context_lines":[{"line_number":20,"context_line":"class TestCli(unittest.TestCase):"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    def setUp(self):"},{"line_number":23,"context_line":"        self.controller_options \u003d None"},{"line_number":24,"context_line":"        self.container_options \u003d None"},{"line_number":25,"context_line":"        self.delete_options \u003d None"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fc2378d6_79138033","line":23,"range":{"start_line":23,"start_character":8,"end_line":23,"end_character":38},"updated":"2022-12-07 07:02:44.000000000","message":"I can remove this now","commit_id":"1f6a3f8ee0101f727e3ed91cc4259581a7954a5a"}]}