)]}'
{"id":"openstack%2Fswift~1005286","triplet_id":"openstack%2Fswift~master~Iec0c542aca465d9ccca7401393cd68902916396e","project":"openstack/swift","branch":"master","attention_set":{},"removed_from_attention_set":{"6968":{"account":{"_account_id":6968,"name":"Christian Schwede","email":"cschwede@nvidia.com","username":"cschwede"},"last_update":"2026-09-14 05:04:42.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Iec0c542aca465d9ccca7401393cd68902916396e","subject":"memcached: do not grow the pool after a failed connect","status":"MERGED","created":"2026-09-11 15:51:52.000000000","updated":"2026-09-14 14:57:41.000000000","submitted":"2026-09-14 05:04:42.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":5,"unresolved_comment_count":1,"has_review_started":true,"submission_id":"1005286","meta_rev_id":"efed7021980d6b44c2d5fa1a95b2bbc160eccb95","_number":1005286,"virtual_id_number":1005286,"owner":{"_account_id":6968,"name":"Christian Schwede","email":"cschwede@nvidia.com","username":"cschwede"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2026-09-14 05:04:42.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"all":[{"value":2,"date":"2026-09-14 04:00:51.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2026-09-13 18:03:18.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"all":[{"value":1,"date":"2026-09-14 04:00:51.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-09-11 16:24:11.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2026-09-11 17:52:50.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2026-09-13 18:03:18.000000000","updated_by":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"reviewer":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"state":"REVIEWER"},{"updated":"2026-09-14 04:00:51.000000000","updated_by":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"reviewer":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"state":"REVIEWER"}],"messages":[{"id":"8be4a4f835f0ec49f5c5ea860846aefe0be10420","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":6968,"name":"Christian Schwede","email":"cschwede@nvidia.com","username":"cschwede"},"date":"2026-09-11 15:51:52.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"f1f4ede640076607a9d397bbe65fe3284e5d9ada","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-09-11 16:24:11.000000000","message":"Patch Set 1:\n\nBuild succeeded (ARM64 pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/9141314011ac4f5a903d5e83ac0d4eeb\n\n- swift-tox-py312-arm64 https://zuul.opendev.org/t/openstack/build/6fd5395fee874935a93f658b55e4ea0b : SUCCESS in 30m 12s","accounts_in_message":[],"_revision_number":1},{"id":"b7d9b58c25a63b7e3f84fa3d86f37db3dafd3c46","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":6968,"name":"Christian Schwede","email":"cschwede@nvidia.com","username":"cschwede"},"date":"2026-09-11 16:46:07.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"45a8f9d5f239eeeddf48edba24497f6e1350c753","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-09-11 17:19:39.000000000","message":"Patch Set 2:\n\nBuild succeeded (ARM64 pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/3ec155c359f04632928a75d5c2213601\n\n- swift-tox-py312-arm64 https://zuul.opendev.org/t/openstack/build/d87f96461d53489daf964142e5858fed : SUCCESS in 31m 32s","accounts_in_message":[],"_revision_number":2},{"id":"991146c0206927b46952433ae25a7013c5849edf","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-09-11 17:52:50.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/99b2f755a9dc46caad6a49081c6072bd\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/7516b69f72ff423499a08351025b74d8 : SUCCESS in 8m 37s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/3c373cdc52674c7da0a49c35685a9720 : SUCCESS in 9m 13s\n- grenade https://zuul.opendev.org/t/openstack/build/3fb8f6f4c2364a809d4ae2fe86aadae6 : SUCCESS in 33m 35s\n- grenade-skip-level-always https://zuul.opendev.org/t/openstack/build/ba71de2fba2a4d40b6c1b5d97dde43e7 : SUCCESS in 58m 08s\n- tempest-integrated-object-storage https://zuul.opendev.org/t/openstack/build/0bc5aec145864cc9b20d47afd2da3149 : SUCCESS in 36m 54s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/c040d41eeac54ccaa149a85dacbf2c3a : SUCCESS in 28m 44s\n- swift-tox-func-py39-centos-9-stream-fips https://zuul.opendev.org/t/openstack/build/b928dd5ec5dd4959a0073f0ea3acfafd : SUCCESS in 10m 54s (non-voting)\n- swift-tox-func-encryption-py39-centos-9-stream-fips https://zuul.opendev.org/t/openstack/build/2f707027471142388c4f44b3660325a4 : SUCCESS in 19m 48s (non-voting)\n- swift-tox-func-ec-py39-centos-9-stream-fips https://zuul.opendev.org/t/openstack/build/9832158f553b4deea24015326b90eeb9 : SUCCESS in 19m 28s (non-voting)\n- swift-build-image https://zuul.opendev.org/t/openstack/build/a86ce0b7c98e4a8788c785b3851240a1 : SUCCESS in 5m 02s (non-voting)\n- swift-tox-py37 https://zuul.opendev.org/t/openstack/build/be4ffc228b0d4c309e720cc1b0a1da09 : SUCCESS in 25m 04s\n- swift-tox-py310 https://zuul.opendev.org/t/openstack/build/d0c72c70cb7147c5922bc83da739b1b0 : SUCCESS in 16m 52s\n- swift-tox-py313 https://zuul.opendev.org/t/openstack/build/15955c708d594728b3ed490e85506b12 : SUCCESS in 13m 00s\n- swift-tox-py314 https://zuul.opendev.org/t/openstack/build/24c56f3cc5f6415dbbaf324a66d15e63 : SUCCESS in 13m 18s\n- swift-tox-func-py312 https://zuul.opendev.org/t/openstack/build/5eb42866ed414cb2bdd5f8240dea47dd : SUCCESS in 15m 35s\n- swift-tox-func-encryption-py312 https://zuul.opendev.org/t/openstack/build/5b72f0c16c4e4b15bd3c5357c06ceb21 : SUCCESS in 16m 21s\n- swift-tox-func-ec-py312 https://zuul.opendev.org/t/openstack/build/65e1d46e392e4e3c8a521c160b18d0b0 : SUCCESS in 12m 56s\n- swift-tox-func-py39-centos-9-stream https://zuul.opendev.org/t/openstack/build/7774ed877554405f85d5f8db7957dfc4 : SUCCESS in 17m 32s\n- swift-func-cors https://zuul.opendev.org/t/openstack/build/4a2c9d9193f84ea2a1db065b2282b74e : SUCCESS in 6m 05s\n- swift-tox-func-ceph-s3tests-tempauth https://zuul.opendev.org/t/openstack/build/60f91dafac724ff585626a623d9726be : FAILURE in 17m 31s (non-voting)\n- swift-tox-func-s3api-compat-tests-tempauth https://zuul.opendev.org/t/openstack/build/87bc3b7327b544a2826de1183b5e7e0d : SUCCESS in 9m 10s\n- swift-probetests-centos-9-stream https://zuul.opendev.org/t/openstack/build/9c0fa49dedc542dd90c51c2e1b424243 : SUCCESS in 58m 25s\n- swift-dsvm-functional https://zuul.opendev.org/t/openstack/build/a79e54fca24743778fc9d3491451d66f : SUCCESS in 24m 55s\n- swift-dsvm-functional-ipv6 https://zuul.opendev.org/t/openstack/build/5964ead857ba48f5b209d6ae96c433ff : SUCCESS in 57m 27s\n- swift-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/0da7f0fe8b154d82b903f966fa39d865 : SUCCESS in 28m 44s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/6f96cb914eec46cda2dc962834c57870 : SUCCESS in 3m 48s\n- swift-multinode-rolling-upgrade https://zuul.opendev.org/t/openstack/build/445b68dc03d74c568ec940a2ef075c79 : SUCCESS in 18m 26s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/f52d446c5c1b4597982b5d04104b2879 : SUCCESS in 1h 00m 02s\n\nWarning:\n  File .ssh/known_hosts.old found in build home directory during playbook opendev.org/zuul/zuul-jobs/playbooks/unittests/post.yaml for job swift-tox-func-py39-centos-9-stream-fips.  Add to preserve-home-paths if safe, or otherwise remove.\n  File .ssh/known_hosts.old found in build home directory during playbook opendev.org/opendev/base-jobs/playbooks/base/post.yaml for job swift-tox-func-py39-centos-9-stream-fips.  Add to preserve-home-paths if safe, or otherwise remove.\n  File .ssh/known_hosts.old found in build home directory during playbook opendev.org/opendev/base-jobs/playbooks/base/cleanup.yaml for job swift-tox-func-py39-centos-9-stream-fips.  Add to preserve-home-paths if safe, or otherwise remove.\n  File .ssh/known_hosts.old found in build home directory during playbook opendev.org/opendev/base-jobs/playbooks/base/post-logs.yaml for job swift-tox-func-py39-centos-9-stream-fips.  Add to preserve-home-paths if safe, or otherwise remove.\n  File .ssh/known_hosts.old found in build home directory during playbook opendev.org/zuul/zuul-jobs/playbooks/unittests/post.yaml for job swift-tox-func-encryption-py39-centos-9-stream-fips.  Add to preserve-home-paths if safe, or otherwise remove.\n  File .ssh/known_hosts.old found in build home directory during playbook opendev.org/opendev/base-jobs/playbooks/base/post.yaml for job swift-tox-func-encryption-py39-centos-9-stream-fips.  Add to preserve-home-paths if safe, or otherwise remove.\n  File .ssh/known_hosts.old found in build home directory during playbook opendev.org/opendev/base-jobs/playbooks/base/cleanup.yaml for job swift-tox-func-encryption-py39-centos-9-stream-fips.  Add to preserve-home-paths if safe, or otherwise remove.\n  File .ssh/known_hosts.old found in build home directory during playbook opendev.org/opendev/base-jobs/playbooks/base/post-logs.yaml for job swift-tox-func-encryption-py39-centos-9-stream-fips.  Add to preserve-home-paths if safe, or otherwise remove.\n  File .ssh/known_hosts.old found in build home directory during playbook opendev.org/zuul/zuul-jobs/playbooks/unittests/post.yaml for job swift-tox-func-ec-py39-centos-9-stream-fips.  Add to preserve-home-paths if safe, or otherwise remove.\n  File .ssh/known_hosts.old found in build home directory during playbook opendev.org/opendev/base-jobs/playbooks/base/post.yaml for job swift-tox-func-ec-py39-centos-9-stream-fips.  Add to preserve-home-paths if safe, or otherwise remove.\n  File .ssh/known_hosts.old found in build home directory during playbook opendev.org/opendev/base-jobs/playbooks/base/cleanup.yaml for job swift-tox-func-ec-py39-centos-9-stream-fips.  Add to preserve-home-paths if safe, or otherwise remove.\n  File .ssh/known_hosts.old found in build home directory during playbook opendev.org/opendev/base-jobs/playbooks/base/post-logs.yaml for job swift-tox-func-ec-py39-centos-9-stream-fips.  Add to preserve-home-paths if safe, or otherwise remove.","accounts_in_message":[],"_revision_number":2},{"id":"45adaa7303156e9c4f8d1c4db81cfd3976a88ae5","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2026-09-13 18:03:18.000000000","message":"Patch Set 2: Code-Review+2\n\n(3 comments)","accounts_in_message":[],"_revision_number":2},{"id":"cb11ec232485baa9f7481fd077a7b6ebfd4156c4","author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"date":"2026-09-14 04:00:51.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"a22129e30a1422635f6dec36989b196ff5b3b422","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-09-14 04:01:42.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"a762e5142d6aa4a735f22b2642fb89d13e52bb90","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-09-14 05:04:42.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/e4ebe16fe0ea43df91dbcff756e546a1\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/81ac02076d5349cc9df7d903f434a401 : SUCCESS in 6m 08s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/b1f7224bf93945878977eb91a20e053f : SUCCESS in 5m 24s\n- grenade https://zuul.opendev.org/t/openstack/build/7237b5e921564b5692b32111cfe5e40e : SUCCESS in 30m 08s\n- grenade-skip-level-always https://zuul.opendev.org/t/openstack/build/22076b01b6a14b16b797708297ef91e5 : SUCCESS in 34m 53s\n- tempest-integrated-object-storage https://zuul.opendev.org/t/openstack/build/45a8a3d5872444eb9320efde8ec0c204 : SUCCESS in 48m 28s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/0fcf0e99c172407bbf79093117b0e4f3 : SUCCESS in 32m 33s\n- swift-upload-image https://zuul.opendev.org/t/openstack/build/8c8688b0885a4abb8a0b20f6193803f8 : SUCCESS in 7m 05s (non-voting)\n- swift-tox-py37 https://zuul.opendev.org/t/openstack/build/5946953f7a7a483c83ac14b2c89c6e13 : SUCCESS in 10m 40s\n- swift-tox-py310 https://zuul.opendev.org/t/openstack/build/d6969d9391e042daa7fe5b9b742fceea : SUCCESS in 17m 14s\n- swift-tox-py313 https://zuul.opendev.org/t/openstack/build/5e6967de8bf248e8b57fa0a8f6e41e25 : SUCCESS in 21m 52s\n- swift-tox-py314 https://zuul.opendev.org/t/openstack/build/9f0f8e265f394c34b43cc255d473dd5a : SUCCESS in 9m 40s\n- swift-tox-func-py312 https://zuul.opendev.org/t/openstack/build/74a6f57c53344c22bf94ffa0edbf7e73 : SUCCESS in 12m 17s\n- swift-tox-func-encryption-py312 https://zuul.opendev.org/t/openstack/build/3d65b4de8e9c47339ce6088a9b72ac09 : SUCCESS in 14m 47s\n- swift-tox-func-ec-py312 https://zuul.opendev.org/t/openstack/build/34b6078f0d184082bc5a808a807d322d : SUCCESS in 15m 31s\n- swift-func-cors https://zuul.opendev.org/t/openstack/build/3f258698d9f447958e55334144d57d8e : SUCCESS in 14m 02s\n- swift-tox-func-s3api-compat-tests-tempauth https://zuul.opendev.org/t/openstack/build/218e01d6fb234e979cceaa6795bc21e7 : SUCCESS in 12m 53s\n- swift-probetests-centos-9-stream https://zuul.opendev.org/t/openstack/build/9c21bd97070c49159c9f1c3216a293f0 : SUCCESS in 36m 03s\n- swift-dsvm-functional https://zuul.opendev.org/t/openstack/build/ad36f5c0cdc34b05bee098225d4012d6 : SUCCESS in 56m 21s\n- swift-dsvm-functional-ipv6 https://zuul.opendev.org/t/openstack/build/aa93aa2d3cf24c55ad5d7de0f69206fe : SUCCESS in 23m 49s\n- swift-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/ada6d4bfb707415092a92e0018bae821 : SUCCESS in 23m 36s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/b2109b1d0ac744b3bb1824a6519e00a6 : SUCCESS in 4m 38s\n- swift-multinode-rolling-upgrade https://zuul.opendev.org/t/openstack/build/226d3dd76fd04ad7a113738ec4dfc996 : SUCCESS in 9m 25s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/aa7f64deb139459a9caf788886c114b7 : SUCCESS in 28m 30s","accounts_in_message":[],"_revision_number":2},{"id":"ae9045a99848a223315ee7b452a2c514e1248d39","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-09-14 05:04:42.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":2},{"id":"9b1c17e362d860ca44cebdcd2361fd9c19233a26","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-09-14 05:05:58.000000000","message":"Patch Set 2:\n\nBuild succeeded (promote pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/e77f47324b854c2b95ab55a523af89ba\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/5689f08271f5482a897c14bdea6af7b9 : SUCCESS in 52s\n- swift-promote-image https://zuul.opendev.org/t/openstack/build/f615801c94354f43bd569a11b3b677d1 : SUCCESS in 52s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"efed7021980d6b44c2d5fa1a95b2bbc160eccb95","author":{"_account_id":6968,"name":"Christian Schwede","email":"cschwede@nvidia.com","username":"cschwede"},"date":"2026-09-14 14:57:41.000000000","message":"Patch Set 2:\n\n(2 comments)","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"96f4751e2838970768f894ab6881867119f16e90","revisions":{"c9ebead21d89b7ea5e759a4fc1cb583469428364":{"kind":"REWORK","_number":1,"created":"2026-09-11 15:51:52.000000000","uploader":{"_account_id":6968,"name":"Christian Schwede","email":"cschwede@nvidia.com","username":"cschwede"},"ref":"refs/changes/86/1005286/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/swift","ref":"refs/changes/86/1005286/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/swift refs/changes/86/1005286/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/swift refs/changes/86/1005286/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/swift refs/changes/86/1005286/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/swift refs/changes/86/1005286/1"}}},"commit":{"parents":[{"commit":"9318950da879bd33b3b5216d0d0cfed4dea45d9c","subject":"Merge \"replicator: Quarantine suffixes we cannot delete\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/9318950da879bd33b3b5216d0d0cfed4dea45d9c"}]}],"author":{"name":"Christian Schwede","email":"cschwede@mailbox.org","date":"2026-09-11 14:19:22.000000000","tz":120},"committer":{"name":"Christian Schwede","email":"cschwede@mailbox.org","date":"2026-09-11 15:51:07.000000000","tz":120},"subject":"memcached: do not grow the pool after a failed connect","message":"memcached: do not grow the pool after a failed connect\n\nThe pool marks a failed connection with a (None, None) placeholder.\nget() replaces the placeholder with a new connection from create().\nIf create() fails, the placeholder must return to the pool.\n\nget() returned the placeholder only after a MemcachePoolTimeout. After\nevery other error, _get_conns() returned a placeholder. This is wrong\nwhen create() fails for a new connection. The base pool releases the\nslot itself, so the placeholder from _get_conns() is not counted.\nAfter each such failure the pool can open one connection more than\nmemcache_max_connections. The extra connection stays until the worker\nrestarts. On a SAIO, five bursts of concurrent requests during a\nmemcached outage left a proxy worker with 14 connections instead\nof 2.\n\nOnly get() knows if it took an item from the pool. get() now returns\nthe placeholder after every error from create(). _get_conns() passes\ngot_connection\u003dFalse and does not return a placeholder.\n\nCloses-Bug: #2167125\nChange-Id: Iec0c542aca465d9ccca7401393cd68902916396e\nSigned-off-by: Christian Schwede \u003ccschwede@mailbox.org\u003e\nCo-Authored-By: Claude Opus 5 \u003cnoreply@anthropic.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/c9ebead21d89b7ea5e759a4fc1cb583469428364"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/c9ebead21d89b7ea5e759a4fc1cb583469428364"}]},"branch":"refs/heads/master"},"96f4751e2838970768f894ab6881867119f16e90":{"kind":"REWORK","_number":2,"created":"2026-09-11 16:46:07.000000000","uploader":{"_account_id":6968,"name":"Christian Schwede","email":"cschwede@nvidia.com","username":"cschwede"},"ref":"refs/changes/86/1005286/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/swift","ref":"refs/changes/86/1005286/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/swift refs/changes/86/1005286/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/swift refs/changes/86/1005286/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/swift refs/changes/86/1005286/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/swift refs/changes/86/1005286/2"}}},"commit":{"parents":[{"commit":"9318950da879bd33b3b5216d0d0cfed4dea45d9c","subject":"Merge \"replicator: Quarantine suffixes we cannot delete\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/9318950da879bd33b3b5216d0d0cfed4dea45d9c"}]}],"author":{"name":"Christian Schwede","email":"cschwede@mailbox.org","date":"2026-09-11 14:19:22.000000000","tz":120},"committer":{"name":"Christian Schwede","email":"cschwede@mailbox.org","date":"2026-09-11 16:46:00.000000000","tz":120},"subject":"memcached: do not grow the pool after a failed connect","message":"memcached: do not grow the pool after a failed connect\n\nThe pool marks a failed connection with a (None, None) placeholder.\nget() replaces the placeholder with a new connection from create().\nIf create() fails, the placeholder must return to the pool.\n\nget() returned the placeholder only after a MemcachePoolTimeout. After\nevery other error, _get_conns() returned a placeholder. This is wrong\nwhen create() fails for a new connection. The base pool releases the\nslot itself, so the placeholder from _get_conns() is not counted.\nAfter each such failure the pool can open one connection more than\nmemcache_max_connections. The extra connection stays until the worker\nrestarts. On a SAIO, five bursts of concurrent requests during a\nmemcached outage left a proxy worker with 14 connections instead\nof 2.\n\nOnly get() knows if it took an item from the pool. get() now returns\nthe placeholder after every error from create(). _get_conns() passes\ngot_connection\u003dFalse and does not return a placeholder.\n\nCloses-Bug: #2167125\nChange-Id: Iec0c542aca465d9ccca7401393cd68902916396e\nSigned-off-by: Christian Schwede \u003ccschwede@mailbox.org\u003e\nCo-Authored-By: Claude Opus 5 \u003cnoreply@anthropic.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/96f4751e2838970768f894ab6881867119f16e90"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/96f4751e2838970768f894ab6881867119f16e90"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}},{"label":"Workflow","status":"MAY","applied_by":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"}}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX"],"failing_atoms":["label:Verified\u003dMIN"],"atom_explanations":{"label:Verified\u003dMAX":"","label:Verified\u003dMIN":""}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX"],"failing_atoms":["label:Code-Review\u003dMIN"],"atom_explanations":{"label:Code-Review\u003dMAX":"","label:Code-Review\u003dMIN":""}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dMAX"],"failing_atoms":["label:Workflow\u003dMIN"],"atom_explanations":{"label:Workflow\u003dMAX":"","label:Workflow\u003dMIN":""}}}]}
