)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"0c556e342fa88ad28bfdb81fdfb5a871a2a71756","unresolved":true,"context_lines":[{"line_number":19,"context_line":"This may not be the desired behavior for CLI tooling. Furthermore,"},{"line_number":20,"context_line":"quarantining a database attempts to move it to a relative location"},{"line_number":21,"context_line":"assuming the canonical layout, which may be nonsense for database files"},{"line_number":22,"context_line":"that have been relocated for forensics. This change adds an optional"},{"line_number":23,"context_line":"quarantine_ok flag to the database broker constructor and modifies the"},{"line_number":24,"context_line":"CLI tools to opt out of quarantine."},{"line_number":25,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ff3498ed_8f51e74d","line":22,"updated":"2026-09-18 18:45:27.000000000","message":"\u003e which may be nonsense for database files that have been relocated for forensics.\n\nPERFECT - we definately need this change.","commit_id":"cccc414d0df8c856609d8a02f677a98663ce6afa"},{"author":{"_account_id":39164,"name":"Matthew Allen","display_name":"Matthew Allen","email":"maallen@nvidia.com","username":"matthewallen"},"change_message_id":"2f23623e05b319584644c3be3b5a740d785e1130","unresolved":false,"context_lines":[{"line_number":19,"context_line":"This may not be the desired behavior for CLI tooling. Furthermore,"},{"line_number":20,"context_line":"quarantining a database attempts to move it to a relative location"},{"line_number":21,"context_line":"assuming the canonical layout, which may be nonsense for database files"},{"line_number":22,"context_line":"that have been relocated for forensics. This change adds an optional"},{"line_number":23,"context_line":"quarantine_ok flag to the database broker constructor and modifies the"},{"line_number":24,"context_line":"CLI tools to opt out of quarantine."},{"line_number":25,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"e70f208f_fea31e88","line":22,"in_reply_to":"ff3498ed_8f51e74d","updated":"2026-09-29 16:01:55.000000000","message":"Acknowledged","commit_id":"cccc414d0df8c856609d8a02f677a98663ce6afa"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"0c556e342fa88ad28bfdb81fdfb5a871a2a71756","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ba28819f_537414cf","updated":"2026-09-18 18:45:27.000000000","message":"1006319: sq? Cover container info quarantine opt-out | https://review.opendev.org/c/openstack/swift/+/1006319\n\nI think the doc-string should change\nI think we should cover the container case\n\nit\u0027s a good patch tho - nice commit message - helpful 🙏","commit_id":"cccc414d0df8c856609d8a02f677a98663ce6afa"},{"author":{"_account_id":39164,"name":"Matthew Allen","display_name":"Matthew Allen","email":"maallen@nvidia.com","username":"matthewallen"},"change_message_id":"2f23623e05b319584644c3be3b5a740d785e1130","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"74fef275_74b02baa","updated":"2026-09-29 16:01:55.000000000","message":"All feedback has been addressed, except for refactoring print_info and adding a BrokerError.","commit_id":"d22e853b2da2c2b5d5f04983ca2fe6e457d6af3e"},{"author":{"_account_id":39164,"name":"Matthew Allen","display_name":"Matthew Allen","email":"maallen@nvidia.com","username":"matthewallen"},"change_message_id":"9e9be3315204a779ce1210904beb3117057df993","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"a16e568b_ff93dc40","updated":"2026-10-15 22:20:45.000000000","message":"Thanks for the review, that was helpful. I will confer with @clay.gerrard@gmail.com and see if we can agree on making `quarantine_ok` True the default.","commit_id":"d22e853b2da2c2b5d5f04983ca2fe6e457d6af3e"},{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"87beb68b75e04d237d1bc9eb4faa1b7f916abe2b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"708a5073_9376a1b0","updated":"2026-10-20 02:59:08.000000000","message":"OK I\u0027m on board, thanks for the disccusion Matthew explaining what you and Clay talked about.\n\n-1 on the broker using True internally rather then the same value used to create it, as this could lead to unexpected behaviour.","commit_id":"60c58cbb18ab92d0cb9c77c0389d8947302076f0"},{"author":{"_account_id":39164,"name":"Matthew Allen","display_name":"Matthew Allen","email":"maallen@nvidia.com","username":"matthewallen"},"change_message_id":"3282ec05108d0436a03390b2848379919a73cc6c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"212ae649_6f06d1c7","updated":"2026-10-20 21:40:58.000000000","message":"Adopted @matt@oliver.net.au suggestions.","commit_id":"3b4031982f418d852d8975810fb055223f092247"},{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"f00efb0e8f454c96fe2b705ad4288cc758735282","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"8d21a9ef_ce95eaa9","updated":"2026-10-21 05:58:00.000000000","message":"Cool, Clay mentions some cool nice to haves, but if you want that to be a follow up later I\u0027m down.","commit_id":"3b4031982f418d852d8975810fb055223f092247"}],"swift/cli/info.py":[{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"0c556e342fa88ad28bfdb81fdfb5a871a2a71756","unresolved":true,"context_lines":[{"line_number":486,"context_line":"        datadir \u003d ABDATADIR"},{"line_number":487,"context_line":"    else:"},{"line_number":488,"context_line":"        broker \u003d ContainerBroker(db_file, stale_reads_ok\u003dstale_reads_ok,"},{"line_number":489,"context_line":"                                 quarantine_ok\u003dFalse)"},{"line_number":490,"context_line":"        datadir \u003d CBDATADIR"},{"line_number":491,"context_line":"    try:"},{"line_number":492,"context_line":"        info \u003d broker.get_info()"}],"source_content_type":"text/x-python","patch_set":2,"id":"8e39a518_9697ea75","line":489,"updated":"2026-09-18 18:45:27.000000000","message":"probably better as `broker_class \u003d AccountBroker` so you can apply `quarnatine_ok\u003dFalse` consistently","commit_id":"cccc414d0df8c856609d8a02f677a98663ce6afa"},{"author":{"_account_id":39164,"name":"Matthew Allen","display_name":"Matthew Allen","email":"maallen@nvidia.com","username":"matthewallen"},"change_message_id":"2f23623e05b319584644c3be3b5a740d785e1130","unresolved":false,"context_lines":[{"line_number":486,"context_line":"        datadir \u003d ABDATADIR"},{"line_number":487,"context_line":"    else:"},{"line_number":488,"context_line":"        broker \u003d ContainerBroker(db_file, stale_reads_ok\u003dstale_reads_ok,"},{"line_number":489,"context_line":"                                 quarantine_ok\u003dFalse)"},{"line_number":490,"context_line":"        datadir \u003d CBDATADIR"},{"line_number":491,"context_line":"    try:"},{"line_number":492,"context_line":"        info \u003d broker.get_info()"}],"source_content_type":"text/x-python","patch_set":2,"id":"7fd7c7a1_5cc2a9fa","line":489,"in_reply_to":"8e39a518_9697ea75","updated":"2026-09-29 16:01:55.000000000","message":"Done","commit_id":"cccc414d0df8c856609d8a02f677a98663ce6afa"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"0c556e342fa88ad28bfdb81fdfb5a871a2a71756","unresolved":true,"context_lines":[{"line_number":506,"context_line":"    except sqlite3.OperationalError as err:"},{"line_number":507,"context_line":"        if \u0027no such table\u0027 in str(err):"},{"line_number":508,"context_line":"            print(\"Does not appear to be a DB of type \\\"%s\\\": %s\""},{"line_number":509,"context_line":"                  % (db_type, db_file))"},{"line_number":510,"context_line":"            raise InfoSystemExit()"},{"line_number":511,"context_line":"        raise"},{"line_number":512,"context_line":"    except sqlite3.DatabaseError as err:"}],"source_content_type":"text/x-python","patch_set":2,"id":"b2dc9c89_369729c9","line":509,"updated":"2026-09-18 18:45:27.000000000","message":"this sort of looks like the error we were thiking about making quarantine-able?\n\ni.e. \"if auditor tries to check on account db and finds a container db the container db should be quarnatined\"\n\nobvs that behavior is specific to the container - an operator may have just fat fingered a path and printing an error and NOT quarantineing is definately the right behavior.","commit_id":"cccc414d0df8c856609d8a02f677a98663ce6afa"},{"author":{"_account_id":39164,"name":"Matthew Allen","display_name":"Matthew Allen","email":"maallen@nvidia.com","username":"matthewallen"},"change_message_id":"2f23623e05b319584644c3be3b5a740d785e1130","unresolved":false,"context_lines":[{"line_number":506,"context_line":"    except sqlite3.OperationalError as err:"},{"line_number":507,"context_line":"        if \u0027no such table\u0027 in str(err):"},{"line_number":508,"context_line":"            print(\"Does not appear to be a DB of type \\\"%s\\\": %s\""},{"line_number":509,"context_line":"                  % (db_type, db_file))"},{"line_number":510,"context_line":"            raise InfoSystemExit()"},{"line_number":511,"context_line":"        raise"},{"line_number":512,"context_line":"    except sqlite3.DatabaseError as err:"}],"source_content_type":"text/x-python","patch_set":2,"id":"cd97b189_9950dbdd","line":509,"in_reply_to":"b2dc9c89_369729c9","updated":"2026-09-29 16:01:55.000000000","message":"Yes, the plan is the wrong-db-type errors will be quarantined by the auditor/replicator, since they are walking the filesystem and can determine when a database is in an unexpected location.","commit_id":"cccc414d0df8c856609d8a02f677a98663ce6afa"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"0c556e342fa88ad28bfdb81fdfb5a871a2a71756","unresolved":true,"context_lines":[{"line_number":522,"context_line":"                    incoming, include_timestamp\u003dTrue))"},{"line_number":523,"context_line":"        except sqlite3.DatabaseError as err:"},{"line_number":524,"context_line":"            print_db_error(err)"},{"line_number":525,"context_line":"            raise InfoSystemExit()"},{"line_number":526,"context_line":"    try:"},{"line_number":527,"context_line":"        ring \u003d Ring(swift_dir, ring_name\u003ddb_type)"},{"line_number":528,"context_line":"    except Exception:"}],"source_content_type":"text/x-python","patch_set":2,"id":"6ac9f0cc_0fcbf623","line":525,"updated":"2026-09-18 18:45:27.000000000","message":"the smell for me is the similarity to the exception block above....\n\nthis may be the right diff *tactically* but presumably a better design for the `print_info` method would be to sequester ALL the database queries into an extracted helper so we can handle `BrokerError` consistently:\n\n```\ntry:\n    datdir, metadata, syncs \u003d _query_the_broker(db_type, db_file, stale_ok)\nexcept BrokerError:\n    print_db_error(err)\n    raise InfoSystemExit()\nprint_db_info_metadata()\nprint_both_syncs(syncs)\n...\n```","commit_id":"cccc414d0df8c856609d8a02f677a98663ce6afa"},{"author":{"_account_id":39164,"name":"Matthew Allen","display_name":"Matthew Allen","email":"maallen@nvidia.com","username":"matthewallen"},"change_message_id":"2f23623e05b319584644c3be3b5a740d785e1130","unresolved":true,"context_lines":[{"line_number":522,"context_line":"                    incoming, include_timestamp\u003dTrue))"},{"line_number":523,"context_line":"        except sqlite3.DatabaseError as err:"},{"line_number":524,"context_line":"            print_db_error(err)"},{"line_number":525,"context_line":"            raise InfoSystemExit()"},{"line_number":526,"context_line":"    try:"},{"line_number":527,"context_line":"        ring \u003d Ring(swift_dir, ring_name\u003ddb_type)"},{"line_number":528,"context_line":"    except Exception:"}],"source_content_type":"text/x-python","patch_set":2,"id":"47cc0072_3e01b20d","line":525,"in_reply_to":"6ac9f0cc_0fcbf623","updated":"2026-09-29 16:01:55.000000000","message":"I do agree your proposal looks cleaner. But since this set of patches keeps expanding, my proposal would be to circle back and take a whack at it in a subsequent iteration.","commit_id":"cccc414d0df8c856609d8a02f677a98663ce6afa"}],"swift/cli/shard-info.py":[{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"ae337fdfdece569ebe505f5f705224858f91d107","unresolved":true,"context_lines":[{"line_number":48,"context_line":"        if os.path.isdir(datadir):"},{"line_number":49,"context_line":"            dirs.append((datadir, node[\u0027id\u0027], lambda *args: True))"},{"line_number":50,"context_line":"    for part, object_file, node_id in roundrobin_datadirs(dirs):"},{"line_number":51,"context_line":"        broker \u003d ContainerBroker(object_file, quarantine_ok\u003dTrue)"},{"line_number":52,"context_line":"        for node in c_ring.get_part_nodes(int(part)):"},{"line_number":53,"context_line":"            if node[\u0027id\u0027] \u003d\u003d node_id:"},{"line_number":54,"context_line":"                node_index \u003d str(node[\u0027index\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f2711f5_0ad0ad47","line":51,"updated":"2026-10-15 02:57:28.000000000","message":"Is this one ok to quarantine because of the round_robin datadirs, so we expect the path to be proper?\n\nI feel this is a grey area, its a CLI tool but also mainly used (at least by me) in saio debugging, so if I happened to be testing corruption and ran the tool to see what that state of things, and running it caused the quratnine behaviour. then that\u0027ll be confusing.\n\nI do wonder if CLI tools should or shouldn\u0027t qurantine by deafult. Or maybe ask?","commit_id":"d22e853b2da2c2b5d5f04983ca2fe6e457d6af3e"},{"author":{"_account_id":39164,"name":"Matthew Allen","display_name":"Matthew Allen","email":"maallen@nvidia.com","username":"matthewallen"},"change_message_id":"9e9be3315204a779ce1210904beb3117057df993","unresolved":true,"context_lines":[{"line_number":48,"context_line":"        if os.path.isdir(datadir):"},{"line_number":49,"context_line":"            dirs.append((datadir, node[\u0027id\u0027], lambda *args: True))"},{"line_number":50,"context_line":"    for part, object_file, node_id in roundrobin_datadirs(dirs):"},{"line_number":51,"context_line":"        broker \u003d ContainerBroker(object_file, quarantine_ok\u003dTrue)"},{"line_number":52,"context_line":"        for node in c_ring.get_part_nodes(int(part)):"},{"line_number":53,"context_line":"            if node[\u0027id\u0027] \u003d\u003d node_id:"},{"line_number":54,"context_line":"                node_index \u003d str(node[\u0027index\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"c314eadd_ae680adf","line":51,"in_reply_to":"7f2711f5_0ad0ad47","updated":"2026-10-15 22:20:45.000000000","message":"Yes, that was the idea--if we have the proper path, then we know the quarantine destination is sane. But I agree we should be setting it to false for anything that is not a consistency daemon as Clay suggested here: https://review.opendev.org/c/openstack/swift/+/1005958/comment/dd045532_3196aef5/\n\nI think your example and https://review.opendev.org/c/openstack/swift/+/791487 both provide an argument that CLI tools should not quarantine by default. But this touches on a related issue that I have been thinking about: if an operator encouters a broken database in production and needs to remediate it immediately, what is the mechanism to do that? My straw man idea would be that once we have this patch chain in, we add the ability to directly invoke the database auditor, but I haven\u0027t fleshed that out. Appreciate any input you have there.","commit_id":"d22e853b2da2c2b5d5f04983ca2fe6e457d6af3e"},{"author":{"_account_id":39164,"name":"Matthew Allen","display_name":"Matthew Allen","email":"maallen@nvidia.com","username":"matthewallen"},"change_message_id":"3282ec05108d0436a03390b2848379919a73cc6c","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        if os.path.isdir(datadir):"},{"line_number":49,"context_line":"            dirs.append((datadir, node[\u0027id\u0027], lambda *args: True))"},{"line_number":50,"context_line":"    for part, object_file, node_id in roundrobin_datadirs(dirs):"},{"line_number":51,"context_line":"        broker \u003d ContainerBroker(object_file, quarantine_ok\u003dTrue)"},{"line_number":52,"context_line":"        for node in c_ring.get_part_nodes(int(part)):"},{"line_number":53,"context_line":"            if node[\u0027id\u0027] \u003d\u003d node_id:"},{"line_number":54,"context_line":"                node_index \u003d str(node[\u0027index\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"ea0dc8b7_824b2046","line":51,"in_reply_to":"ac875ae4_7fff054b","updated":"2026-10-20 21:40:58.000000000","message":"Gotcha, I\u0027ve adjusted quarantine_ok\u003dfalse here.","commit_id":"d22e853b2da2c2b5d5f04983ca2fe6e457d6af3e"},{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"87beb68b75e04d237d1bc9eb4faa1b7f916abe2b","unresolved":true,"context_lines":[{"line_number":48,"context_line":"        if os.path.isdir(datadir):"},{"line_number":49,"context_line":"            dirs.append((datadir, node[\u0027id\u0027], lambda *args: True))"},{"line_number":50,"context_line":"    for part, object_file, node_id in roundrobin_datadirs(dirs):"},{"line_number":51,"context_line":"        broker \u003d ContainerBroker(object_file, quarantine_ok\u003dTrue)"},{"line_number":52,"context_line":"        for node in c_ring.get_part_nodes(int(part)):"},{"line_number":53,"context_line":"            if node[\u0027id\u0027] \u003d\u003d node_id:"},{"line_number":54,"context_line":"                node_index \u003d str(node[\u0027index\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"ac875ae4_7fff054b","line":51,"in_reply_to":"c314eadd_ae680adf","updated":"2026-10-20 02:59:08.000000000","message":"I think that is a great question, either being able to trigger a db auditor with an absolute path might be useful, but also when I have my sre hat on and poking around I tend to use swift-{account,container}-info to see what\u0027s going on with a DB. So I wonder if we should add a `-Q` switch or something to that to quarantine on db error, or maybe ask.\nThe info CLI tool probably does a better check then the db auditor because it trys to pull a lot more data from the db.\n\nBut to bring it back to this file, shard-info (at least as I am aware) is a dev only tool used in SAIOs, and its purpose is to see what the sharding situation is like at a snapshot in time. I use it alot when writing probetests for example. So it went and quarantined something while checking the state of things, that might be annoying. So I err on the side of in this files case it should be `quarantine_ok-False`.","commit_id":"d22e853b2da2c2b5d5f04983ca2fe6e457d6af3e"}],"swift/common/db.py":[{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"0c556e342fa88ad28bfdb81fdfb5a871a2a71756","unresolved":true,"context_lines":[{"line_number":333,"context_line":"        :param quarantine_ok: if False then quarantine() never moves the"},{"line_number":334,"context_line":"            database; the caller still learns the reason via the raised"},{"line_number":335,"context_line":"            sqlite3.DatabaseError, but the file is left in place for"},{"line_number":336,"context_line":"            inspection. Read-only tooling should set this False."},{"line_number":337,"context_line":"        \"\"\""},{"line_number":338,"context_line":"        self.conn \u003d None"},{"line_number":339,"context_line":"        self._db_file \u003d db_file"}],"source_content_type":"text/x-python","patch_set":2,"id":"dd045532_3196aef5","line":336,"updated":"2026-09-18 18:45:27.000000000","message":"instead of Read-only I prefer \"diagnostic\" - or even \"operator\" - basically \"anyone not a consistency engine daemon\"\n\nthe combination of `quarantine_ok\u003dFalse \u0026 (skip_commits\u003dFalse || stale_reads_ok\u003dFalse)` as valid suggests to me that it \"doesn\u0027t modify the database\" is not the REAL constraint for when this should be False\n\n... in fact I think it should DEFAULT to False; although; we might need a `\u003dNone` deprecation period 😭","commit_id":"cccc414d0df8c856609d8a02f677a98663ce6afa"},{"author":{"_account_id":39164,"name":"Matthew Allen","display_name":"Matthew Allen","email":"maallen@nvidia.com","username":"matthewallen"},"change_message_id":"c666928724ab609d9c3340f5a8375e06fb4c0d3c","unresolved":false,"context_lines":[{"line_number":333,"context_line":"        :param quarantine_ok: if False then quarantine() never moves the"},{"line_number":334,"context_line":"            database; the caller still learns the reason via the raised"},{"line_number":335,"context_line":"            sqlite3.DatabaseError, but the file is left in place for"},{"line_number":336,"context_line":"            inspection. Read-only tooling should set this False."},{"line_number":337,"context_line":"        \"\"\""},{"line_number":338,"context_line":"        self.conn \u003d None"},{"line_number":339,"context_line":"        self._db_file \u003d db_file"}],"source_content_type":"text/x-python","patch_set":2,"id":"605274b4_634e37af","line":336,"in_reply_to":"380c8c49_30a1bda8","updated":"2026-09-29 16:14:55.000000000","message":"I also thought the default for `quarantine_ok` should be False, but this introduced a large number of changes to DatabaseBroker constructor call sites and also was a break with existing behavior. I had not thought of the deprecation route and went with this. All production calls to the DatabaseBroker constructor are updated in Patchset 3. To avoid polluting the substance of this patch, I added a new patch that deals with several hundred test call sites: 1007893: db: Pass quarantine_ok arg to broker in tests | https://review.opendev.org/c/openstack/swift/+/1007893","commit_id":"cccc414d0df8c856609d8a02f677a98663ce6afa"},{"author":{"_account_id":39164,"name":"Matthew Allen","display_name":"Matthew Allen","email":"maallen@nvidia.com","username":"matthewallen"},"change_message_id":"2f23623e05b319584644c3be3b5a740d785e1130","unresolved":false,"context_lines":[{"line_number":333,"context_line":"        :param quarantine_ok: if False then quarantine() never moves the"},{"line_number":334,"context_line":"            database; the caller still learns the reason via the raised"},{"line_number":335,"context_line":"            sqlite3.DatabaseError, but the file is left in place for"},{"line_number":336,"context_line":"            inspection. Read-only tooling should set this False."},{"line_number":337,"context_line":"        \"\"\""},{"line_number":338,"context_line":"        self.conn \u003d None"},{"line_number":339,"context_line":"        self._db_file \u003d db_file"}],"source_content_type":"text/x-python","patch_set":2,"id":"380c8c49_30a1bda8","line":336,"in_reply_to":"dd045532_3196aef5","updated":"2026-09-29 16:01:55.000000000","message":"I went with \"operator\", since swift-manage-shard-ranges is not strictly diagnostic.","commit_id":"cccc414d0df8c856609d8a02f677a98663ce6afa"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"0c556e342fa88ad28bfdb81fdfb5a871a2a71756","unresolved":true,"context_lines":[{"line_number":523,"context_line":"        (malformed or corrupted database). If not, the original exception will"},{"line_number":524,"context_line":"        be reraised. If so, the database will be quarantined -- unless the"},{"line_number":525,"context_line":"        broker was constructed with ``quarantine_ok`` False, in which case it"},{"line_number":526,"context_line":"        is left in place -- and a new sqlite3.DatabaseError will be raised."},{"line_number":527,"context_line":"        \"\"\""},{"line_number":528,"context_line":"        if \u0027database disk image is malformed\u0027 in str(err):"},{"line_number":529,"context_line":"            exc_hint \u003d \u0027malformed database\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"1877281d_22c88c28","line":526,"updated":"2026-09-18 18:45:27.000000000","message":"I think the design I\u0027d ultimately like is Brokers to raise BrokerErrors - when/if those seem quarantinable the caller should have say:\n\n```\nwith quarantineable(db_file):\n   self._get_a_broker_and_do_all_my_db_stuff(db_file)\n```\n\neveryone else should just blow up with `BrokerError(\u0027useful diagnostic info\u0027)`\n\n... that said I don\u0027t know *exactly* what the implementation of `quarantieable` should do other than:\n\n```\ntry:\n    yield\nexcept BrokerError as e:\n    if ??????:\n        quarnatine(db_file)\n    else:\n        logging.exception???\n        re-raise?\n```\n\nso, since i\u0027m just dreaming - this is a fine start tho 💪","commit_id":"cccc414d0df8c856609d8a02f677a98663ce6afa"},{"author":{"_account_id":39164,"name":"Matthew Allen","display_name":"Matthew Allen","email":"maallen@nvidia.com","username":"matthewallen"},"change_message_id":"2f23623e05b319584644c3be3b5a740d785e1130","unresolved":true,"context_lines":[{"line_number":523,"context_line":"        (malformed or corrupted database). If not, the original exception will"},{"line_number":524,"context_line":"        be reraised. If so, the database will be quarantined -- unless the"},{"line_number":525,"context_line":"        broker was constructed with ``quarantine_ok`` False, in which case it"},{"line_number":526,"context_line":"        is left in place -- and a new sqlite3.DatabaseError will be raised."},{"line_number":527,"context_line":"        \"\"\""},{"line_number":528,"context_line":"        if \u0027database disk image is malformed\u0027 in str(err):"},{"line_number":529,"context_line":"            exc_hint \u003d \u0027malformed database\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f31da30_4e48e059","line":526,"in_reply_to":"1877281d_22c88c28","updated":"2026-09-29 16:01:55.000000000","message":"Yeah, I think this makes sense. Same comment as above--maybe a subsequent pass for this? I am seeing that touching the brokers tends to cause a huge ripple effect since there are so many consumers.","commit_id":"cccc414d0df8c856609d8a02f677a98663ce6afa"},{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"ae337fdfdece569ebe505f5f705224858f91d107","unresolved":true,"context_lines":[{"line_number":320,"context_line":"            \u0027pass ``quarantine_ok`` explicitly instead.\u0027,"},{"line_number":321,"context_line":"            DeprecationWarning, stacklevel\u003d3"},{"line_number":322,"context_line":"        )"},{"line_number":323,"context_line":"        return True"},{"line_number":324,"context_line":"    return quarantine_ok"},{"line_number":325,"context_line":""},{"line_number":326,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9049dece_26ef7942","line":323,"updated":"2026-10-15 02:57:28.000000000","message":"So a \"default of None\" is actaully a quarantine true.. lets make sure we document that or say that in the commit message. Shouldn\u0027t we just set the quataintine_ok default to true in the constructor? Becaise a None (a normally falsey value is now suddenly a truey). \n\nSo is the plan to be able to track or deprecation warning to find places that are doing it wrong.. but if that\u0027s the case, can\u0027t we just use `git grep` for that?","commit_id":"d22e853b2da2c2b5d5f04983ca2fe6e457d6af3e"},{"author":{"_account_id":39164,"name":"Matthew Allen","display_name":"Matthew Allen","email":"maallen@nvidia.com","username":"matthewallen"},"change_message_id":"9e9be3315204a779ce1210904beb3117057df993","unresolved":true,"context_lines":[{"line_number":320,"context_line":"            \u0027pass ``quarantine_ok`` explicitly instead.\u0027,"},{"line_number":321,"context_line":"            DeprecationWarning, stacklevel\u003d3"},{"line_number":322,"context_line":"        )"},{"line_number":323,"context_line":"        return True"},{"line_number":324,"context_line":"    return quarantine_ok"},{"line_number":325,"context_line":""},{"line_number":326,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"db9604fa_3088038b","line":323,"in_reply_to":"9049dece_26ef7942","updated":"2026-10-15 22:20:45.000000000","message":"The original behavior in the proposed patch was to have `quarantine_ok` default to true to maintain the existing behavior. @clay.gerrard@gmail.com suggested making the default false (to eliminate the element of surprise side effects for new consumers) via a deprecation path: we warn if the argument isn\u0027t passed and treat as True for now, and then change to False in a subsequent release. I assumed that this was a python idiom for changing default behavior, but it seems to be more nuanced than that.\n\nI should have documented this better in the commit message, apologies for that.","commit_id":"d22e853b2da2c2b5d5f04983ca2fe6e457d6af3e"},{"author":{"_account_id":39164,"name":"Matthew Allen","display_name":"Matthew Allen","email":"maallen@nvidia.com","username":"matthewallen"},"change_message_id":"c291a79a659e1ba48797059c4ef7e118efb2268c","unresolved":false,"context_lines":[{"line_number":320,"context_line":"            \u0027pass ``quarantine_ok`` explicitly instead.\u0027,"},{"line_number":321,"context_line":"            DeprecationWarning, stacklevel\u003d3"},{"line_number":322,"context_line":"        )"},{"line_number":323,"context_line":"        return True"},{"line_number":324,"context_line":"    return quarantine_ok"},{"line_number":325,"context_line":""},{"line_number":326,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"cf404e1f_d4b9fe8a","line":323,"in_reply_to":"db9604fa_3088038b","updated":"2026-10-19 21:38:30.000000000","message":"The default value has been modified to a truthy value and the commit message has been updated with the info about deprecating the quarantine-by-default behavior.","commit_id":"d22e853b2da2c2b5d5f04983ca2fe6e457d6af3e"},{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"ae337fdfdece569ebe505f5f705224858f91d107","unresolved":true,"context_lines":[{"line_number":517,"context_line":"            self.logger.error("},{"line_number":518,"context_line":"                \u0027Not quarantining %(db_dir)s: %(reason)s; quarantining is \u0027"},{"line_number":519,"context_line":"                \u0027disabled for this broker, so the database is left in \u0027"},{"line_number":520,"context_line":"                \u0027place\u0027, {\u0027db_dir\u0027: self.db_dir, \u0027reason\u0027: reason})"},{"line_number":521,"context_line":"            raise sqlite3.DatabaseError(reason)"},{"line_number":522,"context_line":""},{"line_number":523,"context_line":"        device_path \u003d self.get_device_path()"}],"source_content_type":"text/x-python","patch_set":3,"id":"0b9f5d1d_afd1d652","line":520,"updated":"2026-10-15 02:57:28.000000000","message":"Should this be logged at an error? I thought this was the guard and the whole point of using qurantine_ok. So things don\u0027t get qurantined, like using a cli tool on a backed up db.. should this cause an error log? Maybe warning or even info makes more sense? \n\nOr is getting to this bit of the code actually unexpected so would be an error?","commit_id":"d22e853b2da2c2b5d5f04983ca2fe6e457d6af3e"},{"author":{"_account_id":39164,"name":"Matthew Allen","display_name":"Matthew Allen","email":"maallen@nvidia.com","username":"matthewallen"},"change_message_id":"9e9be3315204a779ce1210904beb3117057df993","unresolved":true,"context_lines":[{"line_number":517,"context_line":"            self.logger.error("},{"line_number":518,"context_line":"                \u0027Not quarantining %(db_dir)s: %(reason)s; quarantining is \u0027"},{"line_number":519,"context_line":"                \u0027disabled for this broker, so the database is left in \u0027"},{"line_number":520,"context_line":"                \u0027place\u0027, {\u0027db_dir\u0027: self.db_dir, \u0027reason\u0027: reason})"},{"line_number":521,"context_line":"            raise sqlite3.DatabaseError(reason)"},{"line_number":522,"context_line":""},{"line_number":523,"context_line":"        device_path \u003d self.get_device_path()"}],"source_content_type":"text/x-python","patch_set":3,"id":"8517b9ff_f7899644","line":520,"in_reply_to":"0b9f5d1d_afd1d652","updated":"2026-10-15 22:20:45.000000000","message":"This is a good callout. I would argue that the log level is correct here and it is the message that needs to be modified. It reads as routine news: not quarantining the database is expected behavior here. It should first indicate that a database error was encountered. The idea is to have an error message that corresponds to the error logged on the quarantine_ok is True path.","commit_id":"d22e853b2da2c2b5d5f04983ca2fe6e457d6af3e"},{"author":{"_account_id":39164,"name":"Matthew Allen","display_name":"Matthew Allen","email":"maallen@nvidia.com","username":"matthewallen"},"change_message_id":"c291a79a659e1ba48797059c4ef7e118efb2268c","unresolved":false,"context_lines":[{"line_number":517,"context_line":"            self.logger.error("},{"line_number":518,"context_line":"                \u0027Not quarantining %(db_dir)s: %(reason)s; quarantining is \u0027"},{"line_number":519,"context_line":"                \u0027disabled for this broker, so the database is left in \u0027"},{"line_number":520,"context_line":"                \u0027place\u0027, {\u0027db_dir\u0027: self.db_dir, \u0027reason\u0027: reason})"},{"line_number":521,"context_line":"            raise sqlite3.DatabaseError(reason)"},{"line_number":522,"context_line":""},{"line_number":523,"context_line":"        device_path \u003d self.get_device_path()"}],"source_content_type":"text/x-python","patch_set":3,"id":"ce16058f_26aac65d","line":520,"in_reply_to":"8517b9ff_f7899644","updated":"2026-10-19 21:38:30.000000000","message":"Done","commit_id":"d22e853b2da2c2b5d5f04983ca2fe6e457d6af3e"}],"swift/common/db_auditor.py":[{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"ae337fdfdece569ebe505f5f705224858f91d107","unresolved":true,"context_lines":[{"line_number":136,"context_line":"        start_time \u003d time.time()"},{"line_number":137,"context_line":"        try:"},{"line_number":138,"context_line":"            broker \u003d self.broker_class(path, logger\u003dself.logger,"},{"line_number":139,"context_line":"                                       quarantine_ok\u003dTrue)"},{"line_number":140,"context_line":"            if not broker.is_deleted():"},{"line_number":141,"context_line":"                info \u003d broker.get_info()"},{"line_number":142,"context_line":"                err \u003d self._audit(info, broker)"}],"source_content_type":"text/x-python","patch_set":3,"id":"c05d3514_734dee79","line":139,"updated":"2026-10-15 02:57:28.000000000","message":"db auditor, this is a no brainer, but also makes me feel like we touch SO MANY files passing this flag as true.. seems to be we know what the default should be, none None but True. Then we only need to specify the flag when we don\u0027t want the qurantine, and in which case it would be super obvious in the code.","commit_id":"d22e853b2da2c2b5d5f04983ca2fe6e457d6af3e"},{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"f00efb0e8f454c96fe2b705ad4288cc758735282","unresolved":false,"context_lines":[{"line_number":136,"context_line":"        start_time \u003d time.time()"},{"line_number":137,"context_line":"        try:"},{"line_number":138,"context_line":"            broker \u003d self.broker_class(path, logger\u003dself.logger,"},{"line_number":139,"context_line":"                                       quarantine_ok\u003dTrue)"},{"line_number":140,"context_line":"            if not broker.is_deleted():"},{"line_number":141,"context_line":"                info \u003d broker.get_info()"},{"line_number":142,"context_line":"                err \u003d self._audit(info, broker)"}],"source_content_type":"text/x-python","patch_set":3,"id":"e0fed068_61adbd9d","line":139,"in_reply_to":"706c5e92_31b79d46","updated":"2026-10-21 05:58:00.000000000","message":"Acknowledged","commit_id":"d22e853b2da2c2b5d5f04983ca2fe6e457d6af3e"},{"author":{"_account_id":39164,"name":"Matthew Allen","display_name":"Matthew Allen","email":"maallen@nvidia.com","username":"matthewallen"},"change_message_id":"9e9be3315204a779ce1210904beb3117057df993","unresolved":true,"context_lines":[{"line_number":136,"context_line":"        start_time \u003d time.time()"},{"line_number":137,"context_line":"        try:"},{"line_number":138,"context_line":"            broker \u003d self.broker_class(path, logger\u003dself.logger,"},{"line_number":139,"context_line":"                                       quarantine_ok\u003dTrue)"},{"line_number":140,"context_line":"            if not broker.is_deleted():"},{"line_number":141,"context_line":"                info \u003d broker.get_info()"},{"line_number":142,"context_line":"                err \u003d self._audit(info, broker)"}],"source_content_type":"text/x-python","patch_set":3,"id":"706c5e92_31b79d46","line":139,"in_reply_to":"c05d3514_734dee79","updated":"2026-10-15 22:20:45.000000000","message":"Just for my education, what is the reluctance to change a large number of files? The only thing I can think of is that it creates a lot of merge conflicts for a large number of in-flight patches. I have found coding agents are pretty good at resolving merge conflicts, so it\u0027s not as painful as it used to be but I do see that it could be irritating.\n\nThe best argument I can come up with for setting `quarantine_ok` to True is that it maintains existing behavior. If we were introducing a huge new side effect as default behavior, that would be a different story.","commit_id":"d22e853b2da2c2b5d5f04983ca2fe6e457d6af3e"}],"swift/container/backend.py":[{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"87beb68b75e04d237d1bc9eb4faa1b7f916abe2b","unresolved":true,"context_lines":[{"line_number":2168,"context_line":"                                   \"fresh%s.db.tmp\" % str(uuid4()))"},{"line_number":2169,"context_line":"        fresh_broker \u003d ContainerBroker(tmp_db_file, self.timeout, self.logger,"},{"line_number":2170,"context_line":"                                       self.account, self.container,"},{"line_number":2171,"context_line":"                                       quarantine_ok\u003dTrue)"},{"line_number":2172,"context_line":"        fresh_broker.initialize(info[\u0027put_timestamp\u0027],"},{"line_number":2173,"context_line":"                                info[\u0027storage_policy_index\u0027])"},{"line_number":2174,"context_line":"        # copy relevant data from the retiring db to the fresh db"}],"source_content_type":"text/x-python","patch_set":4,"id":"eafb501d_bebb4e4c","line":2171,"range":{"start_line":2171,"start_character":39,"end_line":2171,"end_character":57},"updated":"2026-10-20 02:59:08.000000000","message":"In the case of the sharder, we create a broker object with qurantine_ok\u003dTrue, but if something else creates a broker with a False, then uing the same broker and calling `set_sharding_state` it\u0027ll create the fresh_broker with True which could lead to the db directory including the orig db to qurantine. \n\nSo shouldn\u0027t this not be hardcoded to True, but be whatever the broker set at construction of the broker class?\nIe. up in the constructor maybe we:\n\n```\nself._db_quarantine \u003d db_quarantine\n\n```\n\nThen down here we can just:\n```\nfresh_broker \u003d ContainerBroker(..., quarantine_ok\u003dself._quarantine_ok)\n```","commit_id":"60c58cbb18ab92d0cb9c77c0389d8947302076f0"},{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"f00efb0e8f454c96fe2b705ad4288cc758735282","unresolved":false,"context_lines":[{"line_number":2168,"context_line":"                                   \"fresh%s.db.tmp\" % str(uuid4()))"},{"line_number":2169,"context_line":"        fresh_broker \u003d ContainerBroker(tmp_db_file, self.timeout, self.logger,"},{"line_number":2170,"context_line":"                                       self.account, self.container,"},{"line_number":2171,"context_line":"                                       quarantine_ok\u003dTrue)"},{"line_number":2172,"context_line":"        fresh_broker.initialize(info[\u0027put_timestamp\u0027],"},{"line_number":2173,"context_line":"                                info[\u0027storage_policy_index\u0027])"},{"line_number":2174,"context_line":"        # copy relevant data from the retiring db to the fresh db"}],"source_content_type":"text/x-python","patch_set":4,"id":"b3d8143d_163679fc","line":2171,"range":{"start_line":2171,"start_character":39,"end_line":2171,"end_character":57},"in_reply_to":"01a40a64_135166d8","updated":"2026-10-21 05:58:00.000000000","message":"Done","commit_id":"60c58cbb18ab92d0cb9c77c0389d8947302076f0"},{"author":{"_account_id":39164,"name":"Matthew Allen","display_name":"Matthew Allen","email":"maallen@nvidia.com","username":"matthewallen"},"change_message_id":"3282ec05108d0436a03390b2848379919a73cc6c","unresolved":true,"context_lines":[{"line_number":2168,"context_line":"                                   \"fresh%s.db.tmp\" % str(uuid4()))"},{"line_number":2169,"context_line":"        fresh_broker \u003d ContainerBroker(tmp_db_file, self.timeout, self.logger,"},{"line_number":2170,"context_line":"                                       self.account, self.container,"},{"line_number":2171,"context_line":"                                       quarantine_ok\u003dTrue)"},{"line_number":2172,"context_line":"        fresh_broker.initialize(info[\u0027put_timestamp\u0027],"},{"line_number":2173,"context_line":"                                info[\u0027storage_policy_index\u0027])"},{"line_number":2174,"context_line":"        # copy relevant data from the retiring db to the fresh db"}],"source_content_type":"text/x-python","patch_set":4,"id":"01a40a64_135166d8","line":2171,"range":{"start_line":2171,"start_character":39,"end_line":2171,"end_character":57},"in_reply_to":"eafb501d_bebb4e4c","updated":"2026-10-20 21:40:58.000000000","message":"Good catch, I\u0027ve modified this so that the fresh broker inherits the setting from the original broker.\n\nThe broker already stores the resolved value as self.quarantine_ok. I\u0027m unclear if you are proposing a change or another flag here, so leaving it as-is for now. LMK if I\u0027m missing something.","commit_id":"60c58cbb18ab92d0cb9c77c0389d8947302076f0"},{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"87beb68b75e04d237d1bc9eb4faa1b7f916abe2b","unresolved":true,"context_lines":[{"line_number":2287,"context_line":"                db_file, self.timeout, self.logger, self.account,"},{"line_number":2288,"context_line":"                self.container, self.pending_timeout, self.stale_reads_ok,"},{"line_number":2289,"context_line":"                force_db_file\u003dTrue, skip_commits\u003dbool(db_files),"},{"line_number":2290,"context_line":"                quarantine_ok\u003dself.quarantine_ok)"},{"line_number":2291,"context_line":"            brokers.append(sub_broker)"},{"line_number":2292,"context_line":"        return brokers"},{"line_number":2293,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"56336121_6ceab9b6","line":2290,"updated":"2026-10-20 02:59:08.000000000","message":"Could use the same here","commit_id":"60c58cbb18ab92d0cb9c77c0389d8947302076f0"},{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"f00efb0e8f454c96fe2b705ad4288cc758735282","unresolved":false,"context_lines":[{"line_number":2287,"context_line":"                db_file, self.timeout, self.logger, self.account,"},{"line_number":2288,"context_line":"                self.container, self.pending_timeout, self.stale_reads_ok,"},{"line_number":2289,"context_line":"                force_db_file\u003dTrue, skip_commits\u003dbool(db_files),"},{"line_number":2290,"context_line":"                quarantine_ok\u003dself.quarantine_ok)"},{"line_number":2291,"context_line":"            brokers.append(sub_broker)"},{"line_number":2292,"context_line":"        return brokers"},{"line_number":2293,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"f62fca47_8d47c793","line":2290,"in_reply_to":"56336121_6ceab9b6","updated":"2026-10-21 05:58:00.000000000","message":"Done","commit_id":"60c58cbb18ab92d0cb9c77c0389d8947302076f0"}],"test/unit/cli/test_info.py":[{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"0c556e342fa88ad28bfdb81fdfb5a871a2a71756","unresolved":true,"context_lines":[{"line_number":793,"context_line":"            finally:"},{"line_number":794,"context_line":"                os.chdir(orig_cwd)"},{"line_number":795,"context_line":"        if exp_raised:"},{"line_number":796,"context_line":"            exp_out \u003d \u0027Does not appear to be a DB of type \"account\":\u0027 \\"},{"line_number":797,"context_line":"                \u0027 ./d49d0ecbb53be1fcc49624f2f7c7ccae.db\u0027"},{"line_number":798,"context_line":"            self.assertEqual(out.getvalue().strip(), exp_out)"},{"line_number":799,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"774a2ef0_83385c6e","line":796,"updated":"2026-09-18 18:45:27.000000000","message":"even if this *technically* covers the regression below - I prefer:\n\n    test_print_info_wrong_db_type_message_still_works\n\nover\n\n    test_print_info\n\nPerhaps better as:\n\n    test_print_info_malformed_wrong_type_precedence\n    \n... with a comment like:\n\n    # given both we think wrong type is MOST useful starting point to debug","commit_id":"cccc414d0df8c856609d8a02f677a98663ce6afa"},{"author":{"_account_id":39164,"name":"Matthew Allen","display_name":"Matthew Allen","email":"maallen@nvidia.com","username":"matthewallen"},"change_message_id":"2f23623e05b319584644c3be3b5a740d785e1130","unresolved":false,"context_lines":[{"line_number":793,"context_line":"            finally:"},{"line_number":794,"context_line":"                os.chdir(orig_cwd)"},{"line_number":795,"context_line":"        if exp_raised:"},{"line_number":796,"context_line":"            exp_out \u003d \u0027Does not appear to be a DB of type \"account\":\u0027 \\"},{"line_number":797,"context_line":"                \u0027 ./d49d0ecbb53be1fcc49624f2f7c7ccae.db\u0027"},{"line_number":798,"context_line":"            self.assertEqual(out.getvalue().strip(), exp_out)"},{"line_number":799,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"30366fb9_995070a4","line":796,"in_reply_to":"774a2ef0_83385c6e","updated":"2026-09-29 16:01:55.000000000","message":"I think it\u0027s better to just eliminate `test_print_info_wrong_db_type_message_still_works` since the test is redundant as you noted in the comment. That test does not test precedence, was just added as a regression test by an agent after it found a bug in its exception handling. And we can\u0027t do precedence in the way you suggest, at least not with the way we are creating a malformed DB by deleting the second half of the file. If you make a DB of the wrong type and then partially truncate it, the type is no longer recognizable and it always raises a malformed DB error.","commit_id":"cccc414d0df8c856609d8a02f677a98663ce6afa"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"0c556e342fa88ad28bfdb81fdfb5a871a2a71756","unresolved":true,"context_lines":[{"line_number":841,"context_line":"                                     \u0027HTTP_X_TIMESTAMP\u0027: \u00270\u0027})"},{"line_number":842,"context_line":"        resp \u003d req.get_response(controller)"},{"line_number":843,"context_line":"        self.assertEqual(resp.status_int, 201)"},{"line_number":844,"context_line":"        db_file \u003d os.path.join(self.testdir, \u0027sda1\u0027, \u0027containers\u0027,"},{"line_number":845,"context_line":"                               \u00271\u0027, \u0027cae\u0027,"},{"line_number":846,"context_line":"                               \u0027d49d0ecbb53be1fcc49624f2f7c7ccae\u0027,"},{"line_number":847,"context_line":"                               \u0027d49d0ecbb53be1fcc49624f2f7c7ccae.db\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"8aefbafa_f713fe5e","line":844,"updated":"2026-09-18 18:45:27.000000000","message":"AFAICT this is the only new test that uses a container and doesn\u0027t exercise the new code\n\nconsider:\n\n```\ndiff --git a/swift/cli/info.py b/swift/cli/info.py\nindex 17276d70c..f7fbf6e9b 100644\n--- a/swift/cli/info.py\n+++ b/swift/cli/info.py\n@@ -485,8 +485,7 @@ def print_info(db_type, db_file, swift_dir\u003d\u0027/etc/swift\u0027, stale_reads_ok\u003dFalse,\n                                quarantine_ok\u003dFalse)\n         datadir \u003d ABDATADIR\n     else:\n-        broker \u003d ContainerBroker(db_file, stale_reads_ok\u003dstale_reads_ok,\n-                                 quarantine_ok\u003dFalse)\n+        broker \u003d ContainerBroker(db_file, stale_reads_ok\u003dstale_reads_ok)\n         datadir \u003d CBDATADIR\n     try:\n         info \u003d broker.get_info()\n```\n\n```\npytest test/unit/cli/test_info.py\n...\n55 passed in 0.82s\n```","commit_id":"cccc414d0df8c856609d8a02f677a98663ce6afa"},{"author":{"_account_id":39164,"name":"Matthew Allen","display_name":"Matthew Allen","email":"maallen@nvidia.com","username":"matthewallen"},"change_message_id":"2f23623e05b319584644c3be3b5a740d785e1130","unresolved":false,"context_lines":[{"line_number":841,"context_line":"                                     \u0027HTTP_X_TIMESTAMP\u0027: \u00270\u0027})"},{"line_number":842,"context_line":"        resp \u003d req.get_response(controller)"},{"line_number":843,"context_line":"        self.assertEqual(resp.status_int, 201)"},{"line_number":844,"context_line":"        db_file \u003d os.path.join(self.testdir, \u0027sda1\u0027, \u0027containers\u0027,"},{"line_number":845,"context_line":"                               \u00271\u0027, \u0027cae\u0027,"},{"line_number":846,"context_line":"                               \u0027d49d0ecbb53be1fcc49624f2f7c7ccae\u0027,"},{"line_number":847,"context_line":"                               \u0027d49d0ecbb53be1fcc49624f2f7c7ccae.db\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"2a8bae90_faf718c3","line":844,"in_reply_to":"8aefbafa_f713fe5e","updated":"2026-09-29 16:01:55.000000000","message":"You are correct. I squashed in your patch (with slight modifications).","commit_id":"cccc414d0df8c856609d8a02f677a98663ce6afa"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"0c556e342fa88ad28bfdb81fdfb5a871a2a71756","unresolved":true,"context_lines":[{"line_number":858,"context_line":"        # not a sqlite3.OperationalError one, so it reaches the same except"},{"line_number":859,"context_line":"        # clause as a real quarantine reason. It is not necessarily damage"},{"line_number":860,"context_line":"        # (e.g. a permission error opening an otherwise healthy file), so"},{"line_number":861,"context_line":"        # the message must not call it \"damaged\"."},{"line_number":862,"context_line":"        controller \u003d AccountController("},{"line_number":863,"context_line":"            {\u0027devices\u0027: self.testdir, \u0027mount_check\u0027: \u0027false\u0027})"},{"line_number":864,"context_line":"        req \u003d Request.blank(\u0027/sda1/1/acct\u0027, environ\u003d{\u0027REQUEST_METHOD\u0027: \u0027PUT\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"a6ce449d_8dfd64cd","line":861,"updated":"2026-09-18 18:45:27.000000000","message":"seems like somebodies agent was getting a bit too strong with with their language!","commit_id":"cccc414d0df8c856609d8a02f677a98663ce6afa"},{"author":{"_account_id":39164,"name":"Matthew Allen","display_name":"Matthew Allen","email":"maallen@nvidia.com","username":"matthewallen"},"change_message_id":"2f23623e05b319584644c3be3b5a740d785e1130","unresolved":false,"context_lines":[{"line_number":858,"context_line":"        # not a sqlite3.OperationalError one, so it reaches the same except"},{"line_number":859,"context_line":"        # clause as a real quarantine reason. It is not necessarily damage"},{"line_number":860,"context_line":"        # (e.g. a permission error opening an otherwise healthy file), so"},{"line_number":861,"context_line":"        # the message must not call it \"damaged\"."},{"line_number":862,"context_line":"        controller \u003d AccountController("},{"line_number":863,"context_line":"            {\u0027devices\u0027: self.testdir, \u0027mount_check\u0027: \u0027false\u0027})"},{"line_number":864,"context_line":"        req \u003d Request.blank(\u0027/sda1/1/acct\u0027, environ\u003d{\u0027REQUEST_METHOD\u0027: \u0027PUT\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f25a4d7_3111076c","line":861,"in_reply_to":"a6ce449d_8dfd64cd","updated":"2026-09-29 16:01:55.000000000","message":"This is my fault--I introduced \"damaged\" as a generic term for various database problems, and the agents ran with it. I agree that we shouldn\u0027t introduce new, imprecise terminology when we have existing terminology. It has been expunged.","commit_id":"cccc414d0df8c856609d8a02f677a98663ce6afa"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"0c556e342fa88ad28bfdb81fdfb5a871a2a71756","unresolved":true,"context_lines":[{"line_number":878,"context_line":"            print_info(\u0027account\u0027, db_file, swift_dir\u003dself.testdir)"},{"line_number":879,"context_line":"        self.assertEqual("},{"line_number":880,"context_line":"            out.getvalue().strip(),"},{"line_number":881,"context_line":"            \u0027Database error: %s\\n\u0027"},{"line_number":882,"context_line":"            \u0027This command does not quarantine; the database has been \u0027"},{"line_number":883,"context_line":"            \u0027left in place.\u0027 % conn_err)"},{"line_number":884,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"e3121555_44ab684d","line":881,"updated":"2026-09-18 18:45:27.000000000","message":"I bet this assertion would be stronger if it was a literal string.","commit_id":"cccc414d0df8c856609d8a02f677a98663ce6afa"},{"author":{"_account_id":39164,"name":"Matthew Allen","display_name":"Matthew Allen","email":"maallen@nvidia.com","username":"matthewallen"},"change_message_id":"2f23623e05b319584644c3be3b5a740d785e1130","unresolved":false,"context_lines":[{"line_number":878,"context_line":"            print_info(\u0027account\u0027, db_file, swift_dir\u003dself.testdir)"},{"line_number":879,"context_line":"        self.assertEqual("},{"line_number":880,"context_line":"            out.getvalue().strip(),"},{"line_number":881,"context_line":"            \u0027Database error: %s\\n\u0027"},{"line_number":882,"context_line":"            \u0027This command does not quarantine; the database has been \u0027"},{"line_number":883,"context_line":"            \u0027left in place.\u0027 % conn_err)"},{"line_number":884,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"6f951c93_38c81349","line":881,"in_reply_to":"e3121555_44ab684d","updated":"2026-09-29 16:01:55.000000000","message":"Done","commit_id":"cccc414d0df8c856609d8a02f677a98663ce6afa"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"0c556e342fa88ad28bfdb81fdfb5a871a2a71756","unresolved":true,"context_lines":[{"line_number":882,"context_line":"            \u0027This command does not quarantine; the database has been \u0027"},{"line_number":883,"context_line":"            \u0027left in place.\u0027 % conn_err)"},{"line_number":884,"context_line":""},{"line_number":885,"context_line":"    def test_print_info_sync_reports_damage_instead_of_tracebacking(self):"},{"line_number":886,"context_line":"        # broker.get_syncs(), reached only when sync\u003dTrue, goes through the"},{"line_number":887,"context_line":"        # same self.get() -\u003e possibly_quarantine() path as get_info() and"},{"line_number":888,"context_line":"        # friends but is called after the main try/except block; it needs"}],"source_content_type":"text/x-python","patch_set":2,"id":"853dc174_0aa3ebe8","line":885,"updated":"2026-09-18 18:45:27.000000000","message":"I love verbing 🤣","commit_id":"cccc414d0df8c856609d8a02f677a98663ce6afa"},{"author":{"_account_id":39164,"name":"Matthew Allen","display_name":"Matthew Allen","email":"maallen@nvidia.com","username":"matthewallen"},"change_message_id":"2f23623e05b319584644c3be3b5a740d785e1130","unresolved":false,"context_lines":[{"line_number":882,"context_line":"            \u0027This command does not quarantine; the database has been \u0027"},{"line_number":883,"context_line":"            \u0027left in place.\u0027 % conn_err)"},{"line_number":884,"context_line":""},{"line_number":885,"context_line":"    def test_print_info_sync_reports_damage_instead_of_tracebacking(self):"},{"line_number":886,"context_line":"        # broker.get_syncs(), reached only when sync\u003dTrue, goes through the"},{"line_number":887,"context_line":"        # same self.get() -\u003e possibly_quarantine() path as get_info() and"},{"line_number":888,"context_line":"        # friends but is called after the main try/except block; it needs"}],"source_content_type":"text/x-python","patch_set":2,"id":"826e44a4_d74ecc33","line":885,"in_reply_to":"853dc174_0aa3ebe8","updated":"2026-09-29 16:01:55.000000000","message":"Gerunds FTW. I changed the name since I was getting rid of damage anyway.","commit_id":"cccc414d0df8c856609d8a02f677a98663ce6afa"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"0c556e342fa88ad28bfdb81fdfb5a871a2a71756","unresolved":true,"context_lines":[{"line_number":886,"context_line":"        # broker.get_syncs(), reached only when sync\u003dTrue, goes through the"},{"line_number":887,"context_line":"        # same self.get() -\u003e possibly_quarantine() path as get_info() and"},{"line_number":888,"context_line":"        # friends but is called after the main try/except block; it needs"},{"line_number":889,"context_line":"        # its own damage handling."},{"line_number":890,"context_line":"        controller \u003d AccountController("},{"line_number":891,"context_line":"            {\u0027devices\u0027: self.testdir, \u0027mount_check\u0027: \u0027false\u0027})"},{"line_number":892,"context_line":"        req \u003d Request.blank(\u0027/sda1/1/acct\u0027, environ\u003d{\u0027REQUEST_METHOD\u0027: \u0027PUT\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3afcea0e_ca60fdd8","line":889,"updated":"2026-09-18 18:45:27.000000000","message":"DAMAGE","commit_id":"cccc414d0df8c856609d8a02f677a98663ce6afa"},{"author":{"_account_id":39164,"name":"Matthew Allen","display_name":"Matthew Allen","email":"maallen@nvidia.com","username":"matthewallen"},"change_message_id":"2f23623e05b319584644c3be3b5a740d785e1130","unresolved":false,"context_lines":[{"line_number":886,"context_line":"        # broker.get_syncs(), reached only when sync\u003dTrue, goes through the"},{"line_number":887,"context_line":"        # same self.get() -\u003e possibly_quarantine() path as get_info() and"},{"line_number":888,"context_line":"        # friends but is called after the main try/except block; it needs"},{"line_number":889,"context_line":"        # its own damage handling."},{"line_number":890,"context_line":"        controller \u003d AccountController("},{"line_number":891,"context_line":"            {\u0027devices\u0027: self.testdir, \u0027mount_check\u0027: \u0027false\u0027})"},{"line_number":892,"context_line":"        req \u003d Request.blank(\u0027/sda1/1/acct\u0027, environ\u003d{\u0027REQUEST_METHOD\u0027: \u0027PUT\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"ea5a31f1_f819aff8","line":889,"in_reply_to":"3afcea0e_ca60fdd8","updated":"2026-09-29 16:01:55.000000000","message":"Done","commit_id":"cccc414d0df8c856609d8a02f677a98663ce6afa"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"0c556e342fa88ad28bfdb81fdfb5a871a2a71756","unresolved":true,"context_lines":[{"line_number":906,"context_line":"            print_info(\u0027account\u0027, db_file, swift_dir\u003dself.testdir, sync\u003dTrue)"},{"line_number":907,"context_line":"        self.assertEqual("},{"line_number":908,"context_line":"            out.getvalue().strip().splitlines()[-2:],"},{"line_number":909,"context_line":"            [\u0027Database error: malformed database\u0027,"},{"line_number":910,"context_line":"             \u0027This command does not quarantine; the database has been \u0027"},{"line_number":911,"context_line":"             \u0027left in place.\u0027])"},{"line_number":912,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"adc20e51_23288084","line":909,"updated":"2026-09-18 18:45:27.000000000","message":"this is helpful context.","commit_id":"cccc414d0df8c856609d8a02f677a98663ce6afa"},{"author":{"_account_id":39164,"name":"Matthew Allen","display_name":"Matthew Allen","email":"maallen@nvidia.com","username":"matthewallen"},"change_message_id":"2f23623e05b319584644c3be3b5a740d785e1130","unresolved":false,"context_lines":[{"line_number":906,"context_line":"            print_info(\u0027account\u0027, db_file, swift_dir\u003dself.testdir, sync\u003dTrue)"},{"line_number":907,"context_line":"        self.assertEqual("},{"line_number":908,"context_line":"            out.getvalue().strip().splitlines()[-2:],"},{"line_number":909,"context_line":"            [\u0027Database error: malformed database\u0027,"},{"line_number":910,"context_line":"             \u0027This command does not quarantine; the database has been \u0027"},{"line_number":911,"context_line":"             \u0027left in place.\u0027])"},{"line_number":912,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"8c2410e6_a58f9a38","line":909,"in_reply_to":"adc20e51_23288084","updated":"2026-09-29 16:01:55.000000000","message":"Done","commit_id":"cccc414d0df8c856609d8a02f677a98663ce6afa"}]}
