)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":38767,"name":"Wael Halbawi","display_name":"Wael Halbawi","email":"whalbawi@nvidia.com","username":"whalbawi"},"change_message_id":"9ff871b64d4cef63e211c3ca45cb28de8e293686","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"e78d705f_66846e73","updated":"2026-09-22 23:44:51.000000000","message":"Nice improvement to the tests. My only concern is that the tests that directly exercise `audit_location` do not make the same assertion on the `hash_dirs` counter.","commit_id":"a2992cdc51bb31f25ba71a91833cd19d885cdcaa"}],"test/unit/cli/test_relinker.py":[{"author":{"_account_id":38767,"name":"Wael Halbawi","display_name":"Wael Halbawi","email":"whalbawi@nvidia.com","username":"whalbawi"},"change_message_id":"9ff871b64d4cef63e211c3ca45cb28de8e293686","unresolved":true,"context_lines":[{"line_number":259,"context_line":"                relinker.DEFAULT_MAX_AUDIT_HISTORY_QUARANTINE_THRESHOLD,"},{"line_number":260,"context_line":"            \u0027clobber_hardlink_collisions\u0027: False,"},{"line_number":261,"context_line":"        }"},{"line_number":262,"context_line":"        expected_conf[\u0027policies\u0027] \u003d {POLICIES[0], POLICIES[2]}"},{"line_number":263,"context_line":"        self.assertEqual([mock.call("},{"line_number":264,"context_line":"            expected_conf, expected_logger, [self.existing_device],"},{"line_number":265,"context_line":"            step\u003drelinker.Step.AUDIT)],"}],"source_content_type":"text/x-python","patch_set":3,"id":"94839ff2_fe8b7b7d","line":262,"updated":"2026-09-22 23:44:51.000000000","message":"Is this left out of the the previous definition intentionally? The following passes in my SAIO:\n```\n--- a/test/unit/cli/test_relinker.py\n+++ b/test/unit/cli/test_relinker.py\n@@ -258,8 +258,8 @@ class TestRelinker(unittest.TestCase):\n             \u0027max_audit_history_quarantine_threshold\u0027:\n                 relinker.DEFAULT_MAX_AUDIT_HISTORY_QUARANTINE_THRESHOLD,\n             \u0027clobber_hardlink_collisions\u0027: False,\n+            \u0027policies\u0027: {POLICIES[0], POLICIES[2]},\n         }\n-        expected_conf[\u0027policies\u0027] \u003d {POLICIES[0], POLICIES[2]}\n         self.assertEqual([mock.call(\n             expected_conf, expected_logger, [self.existing_device],\n             step\u003drelinker.Step.AUDIT)],\n```","commit_id":"a2992cdc51bb31f25ba71a91833cd19d885cdcaa"},{"author":{"_account_id":38767,"name":"Wael Halbawi","display_name":"Wael Halbawi","email":"whalbawi@nvidia.com","username":"whalbawi"},"change_message_id":"9ff871b64d4cef63e211c3ca45cb28de8e293686","unresolved":true,"context_lines":[{"line_number":4548,"context_line":""},{"line_number":4549,"context_line":"        # hash_dirs is counted by the process_policy loop, not by"},{"line_number":4550,"context_line":"        # audit_location."},{"line_number":4551,"context_line":"        self.assertEqual(r.stats[\u0027hash_dirs\u0027], 0)"},{"line_number":4552,"context_line":"        self.assertEqual(r.stats[\u0027removed\u0027], 0)"},{"line_number":4553,"context_line":"        self.assertEqual(r.stats[\u0027quarantined\u0027], 1)"},{"line_number":4554,"context_line":"        self.assertEqual(r.stats[\u0027errors\u0027], 1)"}],"source_content_type":"text/x-python","patch_set":3,"id":"47383548_435dae56","line":4551,"updated":"2026-09-22 23:44:51.000000000","message":"This seems like too strong of a negative assertion. If anything we\u0027d have to apply it in all other tests.","commit_id":"a2992cdc51bb31f25ba71a91833cd19d885cdcaa"}]}
