)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"63304b4534d6068f2c5a92b85288bf91f63b0908","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"d24a8d6e_e8812bf5","updated":"2026-10-05 03:44:31.000000000","message":"Love better logging!\n\nJust some inline comments.","commit_id":"1f4a3290669efc8efafbd52ccf9ae721ad727bb3"},{"author":{"_account_id":38368,"name":"Christian Ohanaja","display_name":"Christian Ohanaja","email":"cohanaja@nvidia.com","username":"cohanaja"},"change_message_id":"4ce215620e994d1f6bb4fad25a606bd516978a0d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"5a58cd61_7ca90503","updated":"2026-09-30 19:31:54.000000000","message":"wanna see if we can get this carried (most likely outcome) or maybe slotted into the next release, tested it and I think we\u0027ll find it helpful for our current issue","commit_id":"1f4a3290669efc8efafbd52ccf9ae721ad727bb3"},{"author":{"_account_id":38368,"name":"Christian Ohanaja","display_name":"Christian Ohanaja","email":"cohanaja@nvidia.com","username":"cohanaja"},"change_message_id":"249b3d103b7b48f4d586e8c7f3ebd5947e6818b9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"96946cc0_f43c5f03","in_reply_to":"5a58cd61_7ca90503","updated":"2026-09-30 19:46:13.000000000","message":"info like this will be super sick!\n\n2026-09-30T19:41:17.970053+00:00 saio container-sharder-6041: Finished replication to 127.0.0.2:6021/sdb2, method: rsync_then_merge, outcome: success, elapsed: 6.190s, path: .shards_AUTH_test/big-d861877da56b8b4ceb35c8cbfdf65bb4-1790797085.70748-2, db: /srv/node4/sdb4/containers/261/68d/41400011b76bae4d8e544524107f668d/41400011b76bae4d8e544524107f668d.db","commit_id":"1f4a3290669efc8efafbd52ccf9ae721ad727bb3"},{"author":{"_account_id":38368,"name":"Christian Ohanaja","display_name":"Christian Ohanaja","email":"cohanaja@nvidia.com","username":"cohanaja"},"change_message_id":"742d646085dc4356ac919f45f797fddc933efc10","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"a676dac3_91636fe5","in_reply_to":"d24a8d6e_e8812bf5","updated":"2026-10-05 17:25:33.000000000","message":"Thanks! love the idea of not having to guess when shard dbs are replicated via u/r/sync... should help us a lot with our prod investigation I think","commit_id":"1f4a3290669efc8efafbd52ccf9ae721ad727bb3"},{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"1b57583089b96255e523749b1bbc69f47682894a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"ef17ae8e_71b68b14","updated":"2026-10-06 04:55:15.000000000","message":"Love it! Nice one Christian!","commit_id":"5ae8cf9bce9394b2d135158d0614e7102336ef37"}],"swift/common/db_replicator.py":[{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"63304b4534d6068f2c5a92b85288bf91f63b0908","unresolved":true,"context_lines":[{"line_number":592,"context_line":"            # send diffs over to the remote server"},{"line_number":593,"context_line":"            method \u003d \u0027usync\u0027"},{"line_number":594,"context_line":""},{"line_number":595,"context_line":"        peer \u003d \u0027%s:%s/%s\u0027 % ("},{"line_number":596,"context_line":"            node.get(\u0027replication_ip\u0027, node[\u0027ip\u0027]),"},{"line_number":597,"context_line":"            node.get(\u0027replication_port\u0027, node[\u0027port\u0027]),"},{"line_number":598,"context_line":"            node[\u0027device\u0027])"},{"line_number":599,"context_line":"        self.db_logger.info("},{"line_number":600,"context_line":"            broker, \u0027Starting replication to %s, method: %s, \u0027"},{"line_number":601,"context_line":"            \u0027local max row: %s, remote max row: %s, remote sync point: %s, \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"5e0034b9_4a2f6782","line":598,"range":{"start_line":595,"start_character":8,"end_line":598,"end_character":27},"updated":"2026-10-05 03:44:31.000000000","message":"This feel likes the right case for `swift.common.utils.node_to_string(node_dict)` to me.","commit_id":"1f4a3290669efc8efafbd52ccf9ae721ad727bb3"},{"author":{"_account_id":38368,"name":"Christian Ohanaja","display_name":"Christian Ohanaja","email":"cohanaja@nvidia.com","username":"cohanaja"},"change_message_id":"742d646085dc4356ac919f45f797fddc933efc10","unresolved":false,"context_lines":[{"line_number":592,"context_line":"            # send diffs over to the remote server"},{"line_number":593,"context_line":"            method \u003d \u0027usync\u0027"},{"line_number":594,"context_line":""},{"line_number":595,"context_line":"        peer \u003d \u0027%s:%s/%s\u0027 % ("},{"line_number":596,"context_line":"            node.get(\u0027replication_ip\u0027, node[\u0027ip\u0027]),"},{"line_number":597,"context_line":"            node.get(\u0027replication_port\u0027, node[\u0027port\u0027]),"},{"line_number":598,"context_line":"            node[\u0027device\u0027])"},{"line_number":599,"context_line":"        self.db_logger.info("},{"line_number":600,"context_line":"            broker, \u0027Starting replication to %s, method: %s, \u0027"},{"line_number":601,"context_line":"            \u0027local max row: %s, remote max row: %s, remote sync point: %s, \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"64692067_3d8df635","line":598,"range":{"start_line":595,"start_character":8,"end_line":598,"end_character":27},"in_reply_to":"5e0034b9_4a2f6782","updated":"2026-10-05 17:25:33.000000000","message":"I ought make a skill or add a bit to my agent instructions that tells em to check swift utils before implementing anything new... Done","commit_id":"1f4a3290669efc8efafbd52ccf9ae721ad727bb3"},{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"63304b4534d6068f2c5a92b85288bf91f63b0908","unresolved":true,"context_lines":[{"line_number":608,"context_line":"            if method \u003d\u003d \u0027rsync_then_merge\u0027:"},{"line_number":609,"context_line":"                success \u003d self._rsync_db("},{"line_number":610,"context_line":"                    broker, node, http, info[\u0027id\u0027],"},{"line_number":611,"context_line":"                    replicate_method\u003d\u0027rsync_then_merge\u0027,"},{"line_number":612,"context_line":"                    replicate_timeout\u003d(info[\u0027count\u0027] / 2000),"},{"line_number":613,"context_line":"                    different_region\u003ddifferent_region)"},{"line_number":614,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":3,"id":"0aae31fe_fd78e27d","line":611,"range":{"start_line":611,"start_character":38,"end_line":611,"end_character":54},"updated":"2026-10-05 03:44:31.000000000","message":"This is defined twice now, can we just pass in `method` here?","commit_id":"1f4a3290669efc8efafbd52ccf9ae721ad727bb3"},{"author":{"_account_id":38368,"name":"Christian Ohanaja","display_name":"Christian Ohanaja","email":"cohanaja@nvidia.com","username":"cohanaja"},"change_message_id":"742d646085dc4356ac919f45f797fddc933efc10","unresolved":false,"context_lines":[{"line_number":608,"context_line":"            if method \u003d\u003d \u0027rsync_then_merge\u0027:"},{"line_number":609,"context_line":"                success \u003d self._rsync_db("},{"line_number":610,"context_line":"                    broker, node, http, info[\u0027id\u0027],"},{"line_number":611,"context_line":"                    replicate_method\u003d\u0027rsync_then_merge\u0027,"},{"line_number":612,"context_line":"                    replicate_timeout\u003d(info[\u0027count\u0027] / 2000),"},{"line_number":613,"context_line":"                    different_region\u003ddifferent_region)"},{"line_number":614,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":3,"id":"a6dbf22d_60f391c7","line":611,"range":{"start_line":611,"start_character":38,"end_line":611,"end_character":54},"in_reply_to":"0aae31fe_fd78e27d","updated":"2026-10-05 17:25:33.000000000","message":"Done","commit_id":"1f4a3290669efc8efafbd52ccf9ae721ad727bb3"}]}