)]}'
{"id":"openstack%2Fswift~1009764","triplet_id":"openstack%2Fswift~master~I4874cb420a56d8b482839f636b606b5a13f4cf38","project":"openstack/swift","branch":"master","hashtags":[],"change_id":"I4874cb420a56d8b482839f636b606b5a13f4cf38","subject":"sq? tests: Enforce autospec\u003dTrue on mock patches","status":"NEW","created":"2026-10-09 12:55:54.000000000","updated":"2026-10-09 15:05:51.000000000","submit_type":"MERGE_IF_NECESSARY","mergeable":true,"submittable":false,"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"dfd5dad07377eec3174ec58d93be286a90e15101","_number":1009764,"virtual_id_number":1009764,"owner":{"_account_id":6968,"name":"Christian Schwede","email":"cschwede@nvidia.com","username":"cschwede"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:check","value":1,"date":"2026-10-09 13:56:39.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-10-09 13:56:39.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"6457605089aa7681b2c46ee68dff115b55577c04","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":6968,"name":"Christian Schwede","email":"cschwede@nvidia.com","username":"cschwede"},"date":"2026-10-09 12:55:54.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"95905b0985fffb3b0ee04f53c792b4e1e2a2b00a","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-10-09 13:56:39.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/4bc38e65a61c43229e95482e533b2fef\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/3bc5bd71219d4078a1217179b149ecae : SUCCESS in 8m 17s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/6068edeb4ecc443392b4d298049fe46d : SUCCESS in 9m 16s\n- swift-tox-func-py39-centos-9-stream-fips https://zuul.opendev.org/t/openstack/build/f99a50efe0744d94b26da019bed55414 : SUCCESS in 23m 00s (non-voting)\n- swift-tox-func-encryption-py39-centos-9-stream-fips https://zuul.opendev.org/t/openstack/build/68c6a01133874ff78fb7add3a0520e11 : SUCCESS in 19m 40s (non-voting)\n- swift-tox-func-ec-py39-centos-9-stream-fips https://zuul.opendev.org/t/openstack/build/0b989918e76d4b2fa39bc15e06f736c7 : SUCCESS in 23m 33s (non-voting)\n- swift-build-image https://zuul.opendev.org/t/openstack/build/9443f9f405914552926238d080f8ffbe : SUCCESS in 4m 54s (non-voting)\n- swift-tox-py37 https://zuul.opendev.org/t/openstack/build/65125c131dfb4087ac15647e9aefd221 : SUCCESS in 29m 18s\n- swift-tox-py310 https://zuul.opendev.org/t/openstack/build/db940407395d4e41a02d2d71a66f5fbf : SUCCESS in 14m 38s\n- swift-tox-py313 https://zuul.opendev.org/t/openstack/build/3f452001ba1648f49db7e824db54b4a1 : SUCCESS in 18m 23s\n- swift-tox-py314 https://zuul.opendev.org/t/openstack/build/65257065bfc54502851244baea8bfe52 : SUCCESS in 13m 11s\n- swift-tox-func-py312 https://zuul.opendev.org/t/openstack/build/4f3c120fe00e4ac6a6dd30a550cccc80 : SUCCESS in 16m 03s\n- swift-tox-func-encryption-py312 https://zuul.opendev.org/t/openstack/build/a81fa4ca6bfc4f16a59933887cf545d4 : SUCCESS in 17m 48s\n- swift-tox-func-ec-py312 https://zuul.opendev.org/t/openstack/build/6d24a33ef9b647b89121f7145a6ce531 : SUCCESS in 10m 49s\n- swift-tox-func-py39-centos-9-stream https://zuul.opendev.org/t/openstack/build/6b64ee025a9b4a748e1a97da5f6b4d4a : SUCCESS in 18m 06s\n- swift-dsvm-functional https://zuul.opendev.org/t/openstack/build/90c91dac43214d7db07418ce28db4f88 : SUCCESS in 52m 45s\n- swift-dsvm-functional-ipv6 https://zuul.opendev.org/t/openstack/build/eec2c29d957b4e1e96dfabccf4aa5a62 : SUCCESS in 39m 53s\n- swift-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/1a9f21f41e204677b514123433bd2462 : SUCCESS in 30m 42s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/d2120e6c4bc344b790cefa1e901db8fc : SUCCESS in 4m 40s\n- swift-multinode-rolling-upgrade https://zuul.opendev.org/t/openstack/build/22450b750bb14185b3d942c98a69560d : SUCCESS in 21m 11s\n\nWarning:\n  File .ssh/known_hosts.old found in build home directory during playbook opendev.org/zuul/zuul-jobs/playbooks/unittests/post.yaml for job swift-tox-func-encryption-py39-centos-9-stream-fips.  Add to preserve-home-paths if safe, or otherwise remove.\n  File .ssh/known_hosts.old found in build home directory during playbook opendev.org/opendev/base-jobs/playbooks/base/post.yaml for job swift-tox-func-encryption-py39-centos-9-stream-fips.  Add to preserve-home-paths if safe, or otherwise remove.\n  File .ssh/known_hosts.old found in build home directory during playbook opendev.org/opendev/base-jobs/playbooks/base/cleanup.yaml for job swift-tox-func-encryption-py39-centos-9-stream-fips.  Add to preserve-home-paths if safe, or otherwise remove.\n  File .ssh/known_hosts.old found in build home directory during playbook opendev.org/opendev/base-jobs/playbooks/base/post-logs.yaml for job swift-tox-func-encryption-py39-centos-9-stream-fips.  Add to preserve-home-paths if safe, or otherwise remove.\n  File .ssh/known_hosts.old found in build home directory during playbook opendev.org/zuul/zuul-jobs/playbooks/unittests/post.yaml for job swift-tox-func-py39-centos-9-stream-fips.  Add to preserve-home-paths if safe, or otherwise remove.\n  File .ssh/known_hosts.old found in build home directory during playbook opendev.org/opendev/base-jobs/playbooks/base/post.yaml for job swift-tox-func-py39-centos-9-stream-fips.  Add to preserve-home-paths if safe, or otherwise remove.\n  File .ssh/known_hosts.old found in build home directory during playbook opendev.org/opendev/base-jobs/playbooks/base/cleanup.yaml for job swift-tox-func-py39-centos-9-stream-fips.  Add to preserve-home-paths if safe, or otherwise remove.\n  File .ssh/known_hosts.old found in build home directory during playbook opendev.org/opendev/base-jobs/playbooks/base/post-logs.yaml for job swift-tox-func-py39-centos-9-stream-fips.  Add to preserve-home-paths if safe, or otherwise remove.\n  File .ssh/known_hosts.old found in build home directory during playbook opendev.org/zuul/zuul-jobs/playbooks/unittests/post.yaml for job swift-tox-func-ec-py39-centos-9-stream-fips.  Add to preserve-home-paths if safe, or otherwise remove.\n  File .ssh/known_hosts.old found in build home directory during playbook opendev.org/opendev/base-jobs/playbooks/base/post.yaml for job swift-tox-func-ec-py39-centos-9-stream-fips.  Add to preserve-home-paths if safe, or otherwise remove.\n  File .ssh/known_hosts.old found in build home directory during playbook opendev.org/opendev/base-jobs/playbooks/base/cleanup.yaml for job swift-tox-func-ec-py39-centos-9-stream-fips.  Add to preserve-home-paths if safe, or otherwise remove.\n  File .ssh/known_hosts.old found in build home directory during playbook opendev.org/opendev/base-jobs/playbooks/base/post-logs.yaml for job swift-tox-func-ec-py39-centos-9-stream-fips.  Add to preserve-home-paths if safe, or otherwise remove.","accounts_in_message":[],"_revision_number":1},{"id":"dfd5dad07377eec3174ec58d93be286a90e15101","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-10-09 15:05:51.000000000","message":"Patch Set 1:\n\nBuild succeeded (ARM64 pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/1e7668bc0ae24d60b2f0294faf66628c\n\n- swift-tox-py312-arm64 https://zuul.opendev.org/t/openstack/build/3326574d3ad946c495d806132da71550 : SUCCESS in 1h 35m 30s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"6cbee206f602314c4113936908bef6d01079c429","revisions":{"6cbee206f602314c4113936908bef6d01079c429":{"kind":"REWORK","_number":1,"created":"2026-10-09 12:55:54.000000000","uploader":{"_account_id":6968,"name":"Christian Schwede","email":"cschwede@nvidia.com","username":"cschwede"},"ref":"refs/changes/64/1009764/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/swift","ref":"refs/changes/64/1009764/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/swift refs/changes/64/1009764/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/swift refs/changes/64/1009764/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/swift refs/changes/64/1009764/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/swift refs/changes/64/1009764/1"}}},"commit":{"parents":[{"commit":"d2f270ce964fc867188930cff09a8c18a5a529fd","subject":"tests: Enforce autospec\u003dTrue on mock patches","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/d2f270ce964fc867188930cff09a8c18a5a529fd"}]}],"author":{"name":"Christian Schwede","email":"cschwede@mailbox.org","date":"2026-10-09 12:50:02.000000000","tz":120},"committer":{"name":"Christian Schwede","email":"cschwede@mailbox.org","date":"2026-10-09 12:50:02.000000000","tz":120},"subject":"sq? tests: Enforce autospec\u003dTrue on mock patches","message":"sq? tests: Enforce autospec\u003dTrue on mock patches\n\nFix the two unit tests that the fixture breaks:\n\n- test/unit/obj/test_replicator.py:\n  _test_delete_partition_ssync_quarantine_failure_continues sets\n  sync_method to \u0027ssync\u0027, but __init__ already bound sync_method_fn to\n  rsync. The mock therefore stands in for rsync, and the autospec check\n  rejects the remote_check_objs keyword that revert() passes.\n\n- test/unit/cli/test_relinker.py:\n  test_audit_run_hash_ok patches Relinker.hashes_filter with\n  autospec\u003dTrue, and the side_effect expects self as the first\n  argument. The fixture discards the autospec argument, so the patched\n  attribute becomes a plain mock. A plain mock is not a descriptor, and\n  it does not pass self.\n\nCo-Authored-By: Claude Opus 5 \u003cnoreply@anthropic.com\u003e\nChange-Id: I4874cb420a56d8b482839f636b606b5a13f4cf38\nSigned-off-by: Christian Schwede \u003ccschwede@mailbox.org\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/6cbee206f602314c4113936908bef6d01079c429"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/6cbee206f602314c4113936908bef6d01079c429"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"OK","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY"},{"label":"Workflow","status":"MAY"}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{"label:Verified\u003dMAX":"","label:Verified\u003dMIN":""}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","label:Code-Review\u003dMIN"],"atom_explanations":{"label:Code-Review\u003dMAX":"","label:Code-Review\u003dMIN":""}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Workflow\u003dMAX","label:Workflow\u003dMIN"],"atom_explanations":{"label:Workflow\u003dMAX":"","label:Workflow\u003dMIN":""}}}]}