)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"3033246741d7759880fb7cae03af020e252c8801","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Christian Schwede \u003ccschwede@mailbox.org\u003e"},{"line_number":5,"context_line":"CommitDate: 2026-10-29 13:37:27 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"test/s3api: support other regions"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add a create_bucket helper that names the location outside us-east-1"},{"line_number":10,"context_line":"to allow running the test suite against other regions."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3b8eaed8_831ca159","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":33},"updated":"2026-10-30 16:36:46.000000000","message":"why do we need this? are we planning to have Swift mimic different S3 regions based on Swift region config?\n\nI assumed that we wanted to ensure Swift is compatible with the most typical S3 behaviour (so pick an S3 region). I\u0027m not sure I understand why need compat tests to succeed against any S3 region by allowing their assertions to deviate from what Swift does - that doesn\u0027t help verify that Swift does exactly what (an instance of) S3 does.\n\nI think I must be missing something","commit_id":"1d88eb9266b9ec749e6d94d8eadec8f4c7344b84"},{"author":{"_account_id":6968,"name":"Christian Schwede","email":"cschwede@nvidia.com","username":"cschwede"},"change_message_id":"2676e1c33880d7c1d46c9d35244683b7dfefc50f","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Christian Schwede \u003ccschwede@mailbox.org\u003e"},{"line_number":5,"context_line":"CommitDate: 2026-10-29 13:37:27 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"test/s3api: support other regions"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add a create_bucket helper that names the location outside us-east-1"},{"line_number":10,"context_line":"to allow running the test suite against other regions."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"2961ea79_d5fd9b8e","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":33},"in_reply_to":"3b8eaed8_831ca159","updated":"2026-10-30 17:07:39.000000000","message":"This patch makes it possible to run tests against other than todays default region as well. At the end the compat tests should pass against one region, but not necessarily todays default region.","commit_id":"1d88eb9266b9ec749e6d94d8eadec8f4c7344b84"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"c26366f8e5daa0bb53e8ecf74281a9a24d59a3bd","unresolved":true,"context_lines":[{"line_number":7,"context_line":"test/s3api: support other regions"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add a create_bucket helper that names the location outside us-east-1"},{"line_number":10,"context_line":"to allow running the test suite against other regions."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I7061afbed25ed38004b445c102c7013ecb268f15"},{"line_number":13,"context_line":"Signed-off-by: Christian Schwede \u003ccschwede@mailbox.org\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1227f5d1_79785be0","line":10,"updated":"2026-10-29 15:38:48.000000000","message":"So we know that we\u0027re doing this because AWS exhibits different behaviors in different regions -- what\u0027s our plan for managing the different expectations in tests? Add some `@skipIf(region !\u003d \u0027us-east-1)` decorators? Some `expected \u003d A if region \u003d\u003d \u0027us-east-1\u0027 else B` blocks before assertions? Seems like it might get gnarly when we\u0027re testing against Swift, though, where an operator might configure the region name as they like, regardless of Swift\u0027s behavior...\n\nDo we want this particular test suite to target a particular region\u0027s behaviors? Or should it be trying to characterize as many (distinct) AWS behaviors as it can, across regions?","commit_id":"1d88eb9266b9ec749e6d94d8eadec8f4c7344b84"}],"test/s3api/__init__.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"c26366f8e5daa0bb53e8ecf74281a9a24d59a3bd","unresolved":false,"context_lines":[{"line_number":263,"context_line":"        A region-specific endpoint refuses a create that names no"},{"line_number":264,"context_line":"        location. us-east-1 refuses a create that names one."},{"line_number":265,"context_line":"        \"\"\""},{"line_number":266,"context_line":"        region \u003d get_opt(\u0027region\u0027, \u0027us-east-1\u0027)"},{"line_number":267,"context_line":"        if region !\u003d \u0027us-east-1\u0027:"},{"line_number":268,"context_line":"            kwargs[\u0027CreateBucketConfiguration\u0027] \u003d {"},{"line_number":269,"context_line":"                \u0027LocationConstraint\u0027: region}"}],"source_content_type":"text/x-python","patch_set":2,"id":"2914a957_ec588003","line":266,"updated":"2026-10-29 15:38:48.000000000","message":"I was expecting a `test/sample.conf` change, too, but [it\u0027s already there](https://github.com/openstack/swift/blame/2.38.3/test/sample.conf#L4)! We just needed to actually do the configuration.","commit_id":"1d88eb9266b9ec749e6d94d8eadec8f4c7344b84"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"c26366f8e5daa0bb53e8ecf74281a9a24d59a3bd","unresolved":true,"context_lines":[{"line_number":267,"context_line":"        if region !\u003d \u0027us-east-1\u0027:"},{"line_number":268,"context_line":"            kwargs[\u0027CreateBucketConfiguration\u0027] \u003d {"},{"line_number":269,"context_line":"                \u0027LocationConstraint\u0027: region}"},{"line_number":270,"context_line":"        return client.create_bucket(Bucket\u003dbucket, **kwargs)"},{"line_number":271,"context_line":""},{"line_number":272,"context_line":"    @classmethod"},{"line_number":273,"context_line":"    def create_name(cls, slug):"}],"source_content_type":"text/x-python","patch_set":2,"id":"a5d2b68c_5d4d708e","line":270,"updated":"2026-10-29 15:38:48.000000000","message":"Should we confirm that this succeeded, or are we content to just make sure it didn\u0027t raise? I was thinking something like\n```\nresp \u003d client.create_bucket(Bucket\u003dbucket, **kwargs)\nself.assertEqual(200, resp[\u0027ResponseMetadata\u0027][\u0027HTTPStatusCode\u0027])\nreturn resp\n```\nsimilar to what some of the other tests we\u0027re touching already do.","commit_id":"1d88eb9266b9ec749e6d94d8eadec8f4c7344b84"}],"test/s3api/test_mpu.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"c26366f8e5daa0bb53e8ecf74281a9a24d59a3bd","unresolved":true,"context_lines":[{"line_number":20,"context_line":"from botocore.exceptions import ClientError"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"class BaseMultiPartUploadTestCase(BaseS3TestCase):"},{"line_number":24,"context_line":"    maxDiff \u003d None"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    def setUp(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"05299acc_82c9eed9","line":23,"updated":"2026-10-29 15:38:48.000000000","message":"Off-topic: I wonder if this (and others) should inherit from `BaseS3TestCaseWithBucket`...","commit_id":"1d88eb9266b9ec749e6d94d8eadec8f4c7344b84"}]}