)]}'
{"swift/common/middleware/s3api/controllers/multi_upload.py":[{"author":{"_account_id":34930,"name":"Jianjian Huo","email":"jhuo@nvidia.com","username":"jhuo"},"change_message_id":"02439ab35c0025e2ce407b6fb32e7b4015881e6a","unresolved":true,"context_lines":[{"line_number":772,"context_line":"            if (index \u003c len(slo_manifest) - 1 and"},{"line_number":773,"context_line":"                    slo_manifest_item[\u0027bytes\u0027] \u003c self.min_segment_size):"},{"line_number":774,"context_line":"                # Save the size error and check the remaining parts."},{"line_number":775,"context_line":"                size_error \u003d size_error or EntityTooSmall()"},{"line_number":776,"context_line":""},{"line_number":777,"context_line":"        # Preserve S3 error precedence: final checksum, size, part checksum,"},{"line_number":778,"context_line":"        # then nonconsecutive parts for COMPOSITE."}],"source_content_type":"text/x-python","patch_set":1,"id":"862ce1bb_e3a7e06f","line":775,"updated":"2026-10-23 00:48:44.000000000","message":"I remember this change was advocated by @alistairncoles@gmail.com, I think the motivation was to add more debug info for users, then they could figure out what\u0027s wrong on their side. not a bad idea though.","commit_id":"0357b7ead9b3d4ee8db39f87344fdfd9e93a9a11"},{"author":{"_account_id":34930,"name":"Jianjian Huo","email":"jhuo@nvidia.com","username":"jhuo"},"change_message_id":"bb9f74c705dd42591f30855f15f1e4300c2498dd","unresolved":false,"context_lines":[{"line_number":772,"context_line":"            if (index \u003c len(slo_manifest) - 1 and"},{"line_number":773,"context_line":"                    slo_manifest_item[\u0027bytes\u0027] \u003c self.min_segment_size):"},{"line_number":774,"context_line":"                # Save the size error and check the remaining parts."},{"line_number":775,"context_line":"                size_error \u003d size_error or EntityTooSmall()"},{"line_number":776,"context_line":""},{"line_number":777,"context_line":"        # Preserve S3 error precedence: final checksum, size, part checksum,"},{"line_number":778,"context_line":"        # then nonconsecutive parts for COMPOSITE."}],"source_content_type":"text/x-python","patch_set":1,"id":"0c551555_c2912295","line":775,"in_reply_to":"10deba95_0968a0ae","updated":"2026-10-24 00:00:26.000000000","message":"agreed, let\u0027s make the error message consistent.","commit_id":"0357b7ead9b3d4ee8db39f87344fdfd9e93a9a11"},{"author":{"_account_id":6968,"name":"Christian Schwede","email":"cschwede@nvidia.com","username":"cschwede"},"change_message_id":"4ef6ff9cfffc962f96f7875fcdf7dd6ebe091d53","unresolved":true,"context_lines":[{"line_number":772,"context_line":"            if (index \u003c len(slo_manifest) - 1 and"},{"line_number":773,"context_line":"                    slo_manifest_item[\u0027bytes\u0027] \u003c self.min_segment_size):"},{"line_number":774,"context_line":"                # Save the size error and check the remaining parts."},{"line_number":775,"context_line":"                size_error \u003d size_error or EntityTooSmall()"},{"line_number":776,"context_line":""},{"line_number":777,"context_line":"        # Preserve S3 error precedence: final checksum, size, part checksum,"},{"line_number":778,"context_line":"        # then nonconsecutive parts for COMPOSITE."}],"source_content_type":"text/x-python","patch_set":1,"id":"10deba95_0968a0ae","line":775,"in_reply_to":"862ce1bb_e3a7e06f","updated":"2026-10-23 12:33:05.000000000","message":"@jhuo@nvidia.com I think the only real difference is showing the minimum number of bytes in the message text?\n\nWithout any arg EntityTooSmall() returns the AWS string, defined here: https://opendev.org/openstack/swift/src/branch/master/swift/common/middleware/s3api/s3response.py#L395-L398\n\nWith the arg changed we might break things? We\u0027re also no longer consistently using the same string everywhere, sometimes it\u0027s the AWS string, sometimes the s3api string.","commit_id":"0357b7ead9b3d4ee8db39f87344fdfd9e93a9a11"}]}