)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"c868aa7f8d205d5bd775854ff813d804056d1199","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3fa7aa63_f91df42d","updated":"2026-11-03 17:11:00.000000000","message":"query about the tox.ini change","commit_id":"e9cd764d89b83cb77841f9f6030593dcaef18118"}],"tox.ini":[{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"c868aa7f8d205d5bd775854ff813d804056d1199","unresolved":true,"context_lines":[{"line_number":28,"context_line":"usedevelop \u003d False"},{"line_number":29,"context_line":"deps \u003d"},{"line_number":30,"context_line":"  {[testenv:py39]deps}"},{"line_number":31,"context_line":"  botocore[crt]"},{"line_number":32,"context_line":"commands \u003d"},{"line_number":33,"context_line":"  pytest {posargs:test/s3api}"},{"line_number":34,"context_line":"# For some reason we hit some EPERM issue when building the package for these tests?"}],"source_content_type":"text/x-properties","patch_set":1,"id":"788b714d_85653470","line":31,"updated":"2026-11-03 17:11:00.000000000","message":"can we instead require the crt extra in test-requirements.txt, or awscrt?","commit_id":"e9cd764d89b83cb77841f9f6030593dcaef18118"},{"author":{"_account_id":34930,"name":"Jianjian Huo","email":"jhuo@nvidia.com","username":"jhuo"},"change_message_id":"a89ff6d4e3ca084626ef1bac8730b20c5656a0e8","unresolved":true,"context_lines":[{"line_number":28,"context_line":"usedevelop \u003d False"},{"line_number":29,"context_line":"deps \u003d"},{"line_number":30,"context_line":"  {[testenv:py39]deps}"},{"line_number":31,"context_line":"  botocore[crt]"},{"line_number":32,"context_line":"commands \u003d"},{"line_number":33,"context_line":"  pytest {posargs:test/s3api}"},{"line_number":34,"context_line":"# For some reason we hit some EPERM issue when building the package for these tests?"}],"source_content_type":"text/x-properties","patch_set":1,"id":"5195b182_66a64905","line":31,"in_reply_to":"788b714d_85653470","updated":"2026-11-03 19:27:03.000000000","message":"We can add awscrt directly to test-requirements.txt. That would make CRT a dependency for all test environments. The current tox.ini change limits it to the functional and S3 compatibility tests.\n\nMoving ``botocore[crt]`` into the shared requirements has a constraint conflict. The current master constraints select botocore\u003d\u003d1.43.118 and awscrt\u003d\u003d0.38.0, but that Botocore version’s CRT extra requires awscrt\u003d\u003d0.36.0. Constraints, Botocore requirement.\n\nThe functional and S3 environments use the 2025.1 constraints, which select Botocore 1.36.26. Its CRT extra requires awscrt\u003d\u003d0.23.8, which supports both CRC32C and CRC64NVME.\n\nI suggest keeping the extra limited to those environments.","commit_id":"e9cd764d89b83cb77841f9f6030593dcaef18118"}]}