)]}'
{"swift/common/middleware/list_endpoints.py":[{"author":{"_account_id":917,"name":"Chuck Thier","email":"cthier@gmail.com","username":"cthier"},"change_message_id":"f4537b731599c45cd8eb2e9fa0252343a0c3414a","unresolved":false,"context_lines":[{"line_number":99,"context_line":"                \u0027Unknown response version %r specified for \u0027"},{"line_number":100,"context_line":"                \u0027\"default_response_version\" option in list_endpoints \u0027"},{"line_number":101,"context_line":"                \u0027middleware configuration section, using v1 response \u0027"},{"line_number":102,"context_line":"                \u0027as default\u0027, response_version_option)"},{"line_number":103,"context_line":"            self.default_response_version \u003d 1.0"},{"line_number":104,"context_line":"        self.response_map \u003d {"},{"line_number":105,"context_line":"            1.0: self.v1_format_response,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_1f7e1aaf","line":102,"updated":"2014-06-20 23:44:29.000000000","message":"The default should just be hardcoded to v1.0  otherwise different providers could have different responses which will be a pain to handle with the clients\n\nFrom a RESTful purity perspective, a request to / should 301 redirect to /v1.0, but I\u0027m not sure how clients would respond to that.","commit_id":"6f44b675f4b3ff5331ba1af1bdb2fa2c66fe7f95"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"89b45c039d10f0ea3b09aa94c11fb7f43d5f0ae9","unresolved":false,"context_lines":[{"line_number":99,"context_line":"                \u0027Unknown response version %r specified for \u0027"},{"line_number":100,"context_line":"                \u0027\"default_response_version\" option in list_endpoints \u0027"},{"line_number":101,"context_line":"                \u0027middleware configuration section, using v1 response \u0027"},{"line_number":102,"context_line":"                \u0027as default\u0027, response_version_option)"},{"line_number":103,"context_line":"            self.default_response_version \u003d 1.0"},{"line_number":104,"context_line":"        self.response_map \u003d {"},{"line_number":105,"context_line":"            1.0: self.v1_format_response,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_4048955c","line":102,"in_reply_to":"1ae5cdf2_1f7e1aaf","updated":"2014-06-23 20:03:31.000000000","message":"meh, i like it from discoverability - but I agree not all clients are likely to respond to that as one might desire.","commit_id":"6f44b675f4b3ff5331ba1af1bdb2fa2c66fe7f95"},{"author":{"_account_id":917,"name":"Chuck Thier","email":"cthier@gmail.com","username":"cthier"},"change_message_id":"f4537b731599c45cd8eb2e9fa0252343a0c3414a","unresolved":false,"context_lines":[{"line_number":116,"context_line":"        return POLICIES.get_object_ring(policy_idx, self.swift_dir)"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"    def _parse_version(self, raw_version):"},{"line_number":119,"context_line":"        err_msg \u003d \u0027Unsupport version %r\u0027 % raw_version"},{"line_number":120,"context_line":"        try:"},{"line_number":121,"context_line":"            version \u003d float(raw_version.lstrip(\u0027v\u0027))"},{"line_number":122,"context_line":"        except ValueError:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_df5e7244","line":119,"updated":"2014-06-20 23:44:29.000000000","message":"Unsupported","commit_id":"6f44b675f4b3ff5331ba1af1bdb2fa2c66fe7f95"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"89b45c039d10f0ea3b09aa94c11fb7f43d5f0ae9","unresolved":false,"context_lines":[{"line_number":116,"context_line":"        return POLICIES.get_object_ring(policy_idx, self.swift_dir)"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"    def _parse_version(self, raw_version):"},{"line_number":119,"context_line":"        err_msg \u003d \u0027Unsupport version %r\u0027 % raw_version"},{"line_number":120,"context_line":"        try:"},{"line_number":121,"context_line":"            version \u003d float(raw_version.lstrip(\u0027v\u0027))"},{"line_number":122,"context_line":"        except ValueError:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_c0a2e5fb","line":119,"in_reply_to":"1ae5cdf2_df5e7244","updated":"2014-06-23 20:03:31.000000000","message":"Done","commit_id":"6f44b675f4b3ff5331ba1af1bdb2fa2c66fe7f95"},{"author":{"_account_id":7479,"name":"paul luse","email":"paul.e.luse@intel.com","username":"peluse"},"change_message_id":"6381542ce7e253941cfa2c5ddd696440aaa84b6e","unresolved":false,"context_lines":[{"line_number":140,"context_line":"        :raises: ValueError if path is invalid, message will say why."},{"line_number":141,"context_line":"        \"\"\""},{"line_number":142,"context_line":"        clean_path \u003d request.path[len(self.endpoints_path) - 1:]"},{"line_number":143,"context_line":"        # try to peal off version"},{"line_number":144,"context_line":"        try:"},{"line_number":145,"context_line":"            raw_version, rest \u003d split_path(clean_path, 1, 2, True)"},{"line_number":146,"context_line":"        except ValueError:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_5a27d0b5","line":143,"updated":"2014-06-20 23:56:48.000000000","message":"peel","commit_id":"6f44b675f4b3ff5331ba1af1bdb2fa2c66fe7f95"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"89b45c039d10f0ea3b09aa94c11fb7f43d5f0ae9","unresolved":false,"context_lines":[{"line_number":140,"context_line":"        :raises: ValueError if path is invalid, message will say why."},{"line_number":141,"context_line":"        \"\"\""},{"line_number":142,"context_line":"        clean_path \u003d request.path[len(self.endpoints_path) - 1:]"},{"line_number":143,"context_line":"        # try to peal off version"},{"line_number":144,"context_line":"        try:"},{"line_number":145,"context_line":"            raw_version, rest \u003d split_path(clean_path, 1, 2, True)"},{"line_number":146,"context_line":"        except ValueError:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_e0a7e109","line":143,"in_reply_to":"1ae5cdf2_5a27d0b5","updated":"2014-06-23 20:03:31.000000000","message":"Done","commit_id":"6f44b675f4b3ff5331ba1af1bdb2fa2c66fe7f95"},{"author":{"_account_id":917,"name":"Chuck Thier","email":"cthier@gmail.com","username":"cthier"},"change_message_id":"f4537b731599c45cd8eb2e9fa0252343a0c3414a","unresolved":false,"context_lines":[{"line_number":172,"context_line":"                           **kwargs):"},{"line_number":173,"context_line":"        resp \u003d {"},{"line_number":174,"context_line":"            \u0027endpoints\u0027: endpoints"},{"line_number":175,"context_line":"        }"},{"line_number":176,"context_line":"        if storage_policy_index is not None:"},{"line_number":177,"context_line":"            resp[\u0027storage_policy_index\u0027] \u003d int(storage_policy_index)"},{"line_number":178,"context_line":"        return Response(json.dumps(resp),"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_1f2c5aab","line":175,"updated":"2014-06-20 23:44:29.000000000","message":"to make it more future-proof, I wonder if we should instead return a \u0027headers\u0027 element which is a dict of the headers that need to be sent along with the url.","commit_id":"6f44b675f4b3ff5331ba1af1bdb2fa2c66fe7f95"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"89b45c039d10f0ea3b09aa94c11fb7f43d5f0ae9","unresolved":false,"context_lines":[{"line_number":172,"context_line":"                           **kwargs):"},{"line_number":173,"context_line":"        resp \u003d {"},{"line_number":174,"context_line":"            \u0027endpoints\u0027: endpoints"},{"line_number":175,"context_line":"        }"},{"line_number":176,"context_line":"        if storage_policy_index is not None:"},{"line_number":177,"context_line":"            resp[\u0027storage_policy_index\u0027] \u003d int(storage_policy_index)"},{"line_number":178,"context_line":"        return Response(json.dumps(resp),"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_40b6d53f","line":175,"in_reply_to":"1ae5cdf2_1f2c5aab","updated":"2014-06-23 20:03:31.000000000","message":"yeah that\u0027s a pretty good idea, makes it easier to add the key to every response too!","commit_id":"6f44b675f4b3ff5331ba1af1bdb2fa2c66fe7f95"},{"author":{"_account_id":917,"name":"Chuck Thier","email":"cthier@gmail.com","username":"cthier"},"change_message_id":"f4537b731599c45cd8eb2e9fa0252343a0c3414a","unresolved":false,"context_lines":[{"line_number":238,"context_line":"            \u0027storage_policy_index\u0027: storage_policy_index,"},{"line_number":239,"context_line":"        }"},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"        resp \u003d self.response_map[version](request, **resp_info)"},{"line_number":242,"context_line":"        return resp(env, start_response)"},{"line_number":243,"context_line":""},{"line_number":244,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_9f386aef","line":241,"updated":"2014-06-20 23:44:29.000000000","message":"Please just put the args rather than using the dict :)\n\nDon\u0027t make me start an openstack-dev mailing list post :)","commit_id":"6f44b675f4b3ff5331ba1af1bdb2fa2c66fe7f95"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"89b45c039d10f0ea3b09aa94c11fb7f43d5f0ae9","unresolved":false,"context_lines":[{"line_number":238,"context_line":"            \u0027storage_policy_index\u0027: storage_policy_index,"},{"line_number":239,"context_line":"        }"},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"        resp \u003d self.response_map[version](request, **resp_info)"},{"line_number":242,"context_line":"        return resp(env, start_response)"},{"line_number":243,"context_line":""},{"line_number":244,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_c0f02500","line":241,"in_reply_to":"1ae5cdf2_9f386aef","updated":"2014-06-23 20:03:31.000000000","message":"meh.","commit_id":"6f44b675f4b3ff5331ba1af1bdb2fa2c66fe7f95"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"7e0af56113bbd90b20433cdc45dccc6fb99f9107","unresolved":false,"context_lines":[{"line_number":146,"context_line":"            version \u003d self.default_response_version"},{"line_number":147,"context_line":"            rest \u003d clean_path"},{"line_number":148,"context_line":"        else:"},{"line_number":149,"context_line":"            rest \u003d \u0027/\u0027 + rest"},{"line_number":150,"context_line":"        try:"},{"line_number":151,"context_line":"            account, container, obj \u003d split_path(rest, 1, 3, True)"},{"line_number":152,"context_line":"        except ValueError:"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_9b11fd06","line":149,"updated":"2014-07-17 11:47:07.000000000","message":"raises TypeError if rest is None (no account after version)","commit_id":"be5318768c7f4a1f029bee130c8523d5e490a795"}],"test/unit/common/middleware/test_list_endpoints.py":[{"author":{"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},"change_message_id":"31057612d96c475555cbceb3d93c1b72357266da","unresolved":false,"context_lines":[{"line_number":148,"context_line":""},{"line_number":149,"context_line":"    def test_parse_version_that_looks_like_account(self):"},{"line_number":150,"context_line":"        \"\"\""},{"line_number":151,"context_line":"        Demonstrate the failure mode for version\u0027s that looks like accounts,"},{"line_number":152,"context_line":"        if you can make _parse_path better and this is the *only* test that"},{"line_number":153,"context_line":"        fails you can delete it ;)"},{"line_number":154,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_15385f3a","line":151,"updated":"2014-06-24 18:32:14.000000000","message":"nit: *versions\n\nnit: *look like","commit_id":"be5318768c7f4a1f029bee130c8523d5e490a795"}]}
