)]}'
{"swift/common/internal_client.py":[{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"034fb5a980f35112b8b152023c548df0b66ff47f","unresolved":false,"context_lines":[{"line_number":804,"context_line":"            try:"},{"line_number":805,"context_line":"                return self.base_request(method, **kwargs)"},{"line_number":806,"context_line":"            except (socket.error, httplib.HTTPException, urllib2.URLError):"},{"line_number":807,"context_line":"                if self.attempts \u003e self.retries:"},{"line_number":808,"context_line":"                    raise"},{"line_number":809,"context_line":"            sleep(backoff)"},{"line_number":810,"context_line":"            backoff \u003d min(backoff * 2, self.max_backoff)"}],"source_content_type":"text/x-python","patch_set":5,"id":"baada198_a65b2c53","line":807,"updated":"2014-07-01 15:55:40.000000000","message":"I think self.retries needs to be retries.\n\nThe test passes retries \u003d 0 in kwargs , so exceptions are never raised with self.retries being 5. If I make the change though the test is raising a timed out error not an HTTPError??","commit_id":"c77f38d12ede4912a2361ed27953552d3b0c420c"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"8ec8f293d0d77245430f5c3ed866f9f502fb4982","unresolved":false,"context_lines":[{"line_number":804,"context_line":"            try:"},{"line_number":805,"context_line":"                return self.base_request(method, **kwargs)"},{"line_number":806,"context_line":"            except (socket.error, httplib.HTTPException, urllib2.URLError):"},{"line_number":807,"context_line":"                if self.attempts \u003e self.retries:"},{"line_number":808,"context_line":"                    raise"},{"line_number":809,"context_line":"            sleep(backoff)"},{"line_number":810,"context_line":"            backoff \u003d min(backoff * 2, self.max_backoff)"}],"source_content_type":"text/x-python","patch_set":5,"id":"baada198_207a9c88","line":807,"in_reply_to":"baada198_a65b2c53","updated":"2014-07-01 18:00:00.000000000","message":"nice catch, the timeout is cause the server isn\u0027t responding with anything - the test is still valid, but might be clearer if sent a valid HTTP status line on accept before closing the conn.","commit_id":"c77f38d12ede4912a2361ed27953552d3b0c420c"}]}