)]}'
{"swift/common/utils.py":[{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"b450c6b21ac07e937734ec956cc6acbf21e4ef51","unresolved":false,"context_lines":[{"line_number":1612,"context_line":"                    if err.errno !\u003d errno.EAGAIN:"},{"line_number":1613,"context_line":"                        raise"},{"line_number":1614,"context_line":"                if time_slept \u003e timeout * 0.01:"},{"line_number":1615,"context_line":"                    timeout_len \u003d max(timeout * 0.01, timeout_len)"},{"line_number":1616,"context_line":"                sleep(timeout_len)"},{"line_number":1617,"context_line":"                time_slept +\u003d timeout_len"},{"line_number":1618,"context_line":"        yield True"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_c434b44b","line":1615,"updated":"2014-08-13 02:58:58.000000000","message":"Seeing as the value \u0027timeout * 0.01\u0027 is constant, in terms of inside the while loop. And this is the only line that modifies timeout_len, then max is redundant. \n\n  timeout_len \u003d timeout * 0.01\n\nwill do the same thing. As after time_slept \u003e timeout * 0.01, timeout_len will always be the value of timeout * 0.01 (as the max of (timeout * 0.01) and (timeout * 0.01) \u003d\u003d (timeout * 0.01))","commit_id":"d439df3c90557ea66d26b41966ce227a4e11394d"},{"author":{"_account_id":995,"name":"David Goetz","email":"david.goetz@rackspace.com","username":"david-goetz"},"change_message_id":"e93e5c76deb9409a33523d27cad7e8a723316d3b","unresolved":false,"context_lines":[{"line_number":1612,"context_line":"                    if err.errno !\u003d errno.EAGAIN:"},{"line_number":1613,"context_line":"                        raise"},{"line_number":1614,"context_line":"                if time_slept \u003e timeout * 0.01:"},{"line_number":1615,"context_line":"                    timeout_len \u003d max(timeout * 0.01, timeout_len)"},{"line_number":1616,"context_line":"                sleep(timeout_len)"},{"line_number":1617,"context_line":"                time_slept +\u003d timeout_len"},{"line_number":1618,"context_line":"        yield True"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_1f5c351a","line":1615,"in_reply_to":"baada198_c434b44b","updated":"2014-08-13 03:11:38.000000000","message":"if timeout started as .5 then not using the max would decrease the time slept from 0.01 to 0.005 which would makes things worse. go ahead and leave the -1, i\u0027ll move this line out of the while loop so the code\u0027s a little clearer.","commit_id":"d439df3c90557ea66d26b41966ce227a4e11394d"}]}