)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"9a0832c5da2c15f2596aa0cbe8c0bd7f5c55ed41","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Make ec_object_segment_size configurable per EC policy"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Using one segment size in different EC ratio will resulting"},{"line_number":10,"context_line":"extra padding contents, e.g, using 1048576 in 8+2 is perfect while"},{"line_number":11,"context_line":"in 10+4 will have extra padding bytes in each segment."},{"line_number":12,"context_line":"This patch makes this parameter configurable in each EC policy. If"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7ac7a964_321bc01c","line":9,"updated":"2014-08-15 08:08:25.000000000","message":"The sentence could use a little rewording, maybe something like:\n\nUsing one segment size with different EC ratios will result in extra padding per segment,","commit_id":"eb48379aa2b2cb848381847afe9a3eb7cc3986bd"}],"swift/common/constraints.py":[{"author":{"_account_id":7485,"name":"Tushar Gohad","email":"tushar.gohad@intel.com","username":"tsg"},"change_message_id":"89263ff0f56858ee1221645bd549bb605baeced0","unresolved":false,"context_lines":[{"line_number":33,"context_line":"ACCOUNT_LISTING_LIMIT \u003d 10000"},{"line_number":34,"context_line":"MAX_ACCOUNT_NAME_LENGTH \u003d 256"},{"line_number":35,"context_line":"MAX_CONTAINER_NAME_LENGTH \u003d 256"},{"line_number":36,"context_line":"EC_OBJECT_SEGMENT_SIZE \u003d 1048576"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"# If adding an entry to DEFAULT_CONSTRAINTS, note that"},{"line_number":39,"context_line":"# these constraints are automatically published by the"}],"source_content_type":"text/x-python","patch_set":2,"id":"1abeadc6_eb9fcc4e","line":36,"updated":"2014-08-18 05:51:28.000000000","message":"Already part of the PUT patch .. (EC_OBJECT_SEGMENT_SIZE should be introduced by the PUT patch and moved to storage_policy by this patch) .. \n\nhttps://review.openstack.org/#/c/111615/4/swift/common/constraints.py","commit_id":"dd62a3d209c832ab22c53c74c3a837c1f0cdcb2a"},{"author":{"_account_id":7485,"name":"Tushar Gohad","email":"tushar.gohad@intel.com","username":"tsg"},"change_message_id":"89263ff0f56858ee1221645bd549bb605baeced0","unresolved":false,"context_lines":[{"line_number":51,"context_line":"    \u0027account_listing_limit\u0027: ACCOUNT_LISTING_LIMIT,"},{"line_number":52,"context_line":"    \u0027max_account_name_length\u0027: MAX_ACCOUNT_NAME_LENGTH,"},{"line_number":53,"context_line":"    \u0027max_container_name_length\u0027: MAX_CONTAINER_NAME_LENGTH,"},{"line_number":54,"context_line":"    \u0027ec_object_segment_size\u0027: EC_OBJECT_SEGMENT_SIZE,"},{"line_number":55,"context_line":"}"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"SWIFT_CONSTRAINTS_LOADED \u003d False"}],"source_content_type":"text/x-python","patch_set":2,"id":"1abeadc6_4bb600de","line":54,"updated":"2014-08-18 05:51:28.000000000","message":"Ditto (PUT patch)","commit_id":"dd62a3d209c832ab22c53c74c3a837c1f0cdcb2a"}],"swift/common/storage_policy.py":[{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"9a0832c5da2c15f2596aa0cbe8c0bd7f5c55ed41","unresolved":false,"context_lines":[{"line_number":195,"context_line":"        # Define _ec_seg_size as the size of the encoding segment"},{"line_number":196,"context_line":"        # Accessible as the property \"ec_seg_size\""},{"line_number":197,"context_line":"        if ec_seg_size is None:"},{"line_number":198,"context_line":"            ec_seg_size \u003d EC_OBJECT_SEGMENT_SIZE"},{"line_number":199,"context_line":"        try:"},{"line_number":200,"context_line":"            value \u003d config_auto_int_value(ec_seg_size, -1)"},{"line_number":201,"context_line":"            if value \u003c\u003d 0:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7ac7a964_72645822","line":198,"updated":"2014-08-15 08:08:25.000000000","message":"Instead of an if statement to check to see if the value it none, why not set the default in the constructor signature? e.g.\n\n  def __init__(self, idx, name\u003d\u0027\u0027, is_default\u003dFalse,\n               is_deprecated\u003dFalse, object_ring\u003dNone, \n               ec_seg_size\u003dEC_OBJECT_SEGMENT_SIZE,\n               ec_type\u003dNone, ec_ndata\u003dNone, ec_nparity\u003dNone):","commit_id":"eb48379aa2b2cb848381847afe9a3eb7cc3986bd"},{"author":{"_account_id":7479,"name":"paul luse","email":"paul.e.luse@intel.com","username":"peluse"},"change_message_id":"64256e531ebdc44cc1ebb8413ad882ce78e516bc","unresolved":false,"context_lines":[{"line_number":430,"context_line":"                policy_entry[\u0027default\u0027] \u003d pol.is_default"},{"line_number":431,"context_line":"            if pol.policy_type \u003d\u003d EC_POLICY:"},{"line_number":432,"context_line":"                policy_entry[\u0027ec_type\u0027] \u003d pol.ec_type"},{"line_number":433,"context_line":"                policy_entry[\u0027ec_seg_size\u0027] \u003d pol.ec_seg_size"},{"line_number":434,"context_line":"                policy_entry[\u0027ec_ndata\u0027] \u003d pol.ec_ndata"},{"line_number":435,"context_line":"                policy_entry[\u0027ec_nparity\u0027] \u003d pol.ec_nparity"},{"line_number":436,"context_line":"            policy_info.append(policy_entry)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1abeadc6_dfe3ae03","line":433,"updated":"2014-08-18 01:24:02.000000000","message":"I\u0027m not sure that this is useful in /info, would like to hear from torgomatic - what value is seg size to consumers or /info?","commit_id":"dd62a3d209c832ab22c53c74c3a837c1f0cdcb2a"}],"test/unit/proxy/test_server.py":[{"author":{"_account_id":7485,"name":"Tushar Gohad","email":"tushar.gohad@intel.com","username":"tsg"},"change_message_id":"89263ff0f56858ee1221645bd549bb605baeced0","unresolved":false,"context_lines":[{"line_number":6876,"context_line":"        self.assertEqual(si[\u0027max_object_name_length\u0027],"},{"line_number":6877,"context_line":"                         constraints.MAX_OBJECT_NAME_LENGTH)"},{"line_number":6878,"context_line":"        self.assertEqual(si[\u0027ec_object_segment_size\u0027],"},{"line_number":6879,"context_line":"                         constraints.EC_OBJECT_SEGMENT_SIZE)"},{"line_number":6880,"context_line":"        self.assertTrue(\u0027strict_cors_mode\u0027 in si)"},{"line_number":6881,"context_line":"        # this next test is deliberately brittle in order to alert if"},{"line_number":6882,"context_line":"        # other items are added to swift info"}],"source_content_type":"text/x-python","patch_set":2,"id":"1abeadc6_95b597cf","line":6879,"updated":"2014-08-18 05:51:28.000000000","message":"Already covered in the PUT patch ..","commit_id":"dd62a3d209c832ab22c53c74c3a837c1f0cdcb2a"}]}