)]}'
{"swift/common/db_replicator.py":[{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"69f9d2c4fa93484da252569aa7c526f46d881135","unresolved":false,"context_lines":[{"line_number":352,"context_line":"            conn.connect()"},{"line_number":353,"context_line":"            return conn"},{"line_number":354,"context_line":"        except Exception:"},{"line_number":355,"context_line":"            return None"},{"line_number":356,"context_line":""},{"line_number":357,"context_line":"    def _gather_sync_args(self, info):"},{"line_number":358,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"1abeadc6_78d3b95f","line":355,"updated":"2014-08-25 18:31:44.000000000","message":"The bare except here is no beuno.  Need a self.logger.exception me thinks.","commit_id":"437031875ca01a147f8275a84e3632b548973547"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"c0985eeb4a0cfa12290d4eb2b16b930c81e49aee","unresolved":false,"context_lines":[{"line_number":371,"context_line":"        :returns: True if successful, False otherwise"},{"line_number":372,"context_line":"        \"\"\""},{"line_number":373,"context_line":"        with ConnectionTimeout(self.conn_timeout):"},{"line_number":374,"context_line":"            http \u003d self._http_connect(node, partition, broker.db_file)"},{"line_number":375,"context_line":"        if not http:"},{"line_number":376,"context_line":"            self.logger.error("},{"line_number":377,"context_line":"                _(\u0027ERROR Unable to connect to remote server: %s\u0027), node)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a890539_5269c88a","side":"PARENT","line":374,"updated":"2014-11-24 17:01:59.000000000","message":"creating the ReplConnection class doesn\u0027t connect, won\u0027t ever take .5 seconds, won\u0027t even yield.","commit_id":"308c6a5e73ad8f9c1c669d7406b7f55bf46e1af0"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"c0985eeb4a0cfa12290d4eb2b16b930c81e49aee","unresolved":false,"context_lines":[{"line_number":372,"context_line":"        \"\"\""},{"line_number":373,"context_line":"        with ConnectionTimeout(self.conn_timeout):"},{"line_number":374,"context_line":"            http \u003d self._http_connect(node, partition, broker.db_file)"},{"line_number":375,"context_line":"        if not http:"},{"line_number":376,"context_line":"            self.logger.error("},{"line_number":377,"context_line":"                _(\u0027ERROR Unable to connect to remote server: %s\u0027), node)"},{"line_number":378,"context_line":"            return False"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a890539_72e16429","side":"PARENT","line":375,"updated":"2014-11-24 17:01:59.000000000","message":"yeah, _http_connect just creates the ReplConnection instance, it can\u0027t return None.","commit_id":"308c6a5e73ad8f9c1c669d7406b7f55bf46e1af0"}],"test/unit/common/test_db_replicator.py":[{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"c0985eeb4a0cfa12290d4eb2b16b930c81e49aee","unresolved":false,"context_lines":[{"line_number":1233,"context_line":"    def test_repl_to_node_http_connect_fails(self):"},{"line_number":1234,"context_line":"        self.replicator._http_connect \u003d lambda *args: None"},{"line_number":1235,"context_line":"        self.assertEquals(self.replicator._repl_to_node("},{"line_number":1236,"context_line":"            self.fake_node, FakeBroker(), \u00270\u0027, self.fake_info), False)"},{"line_number":1237,"context_line":""},{"line_number":1238,"context_line":"    def test_repl_to_node_not_response(self):"},{"line_number":1239,"context_line":"        self.http \u003d mock.Mock(replicate\u003dmock.Mock(return_value\u003dNone))"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a890539_9206d0cc","side":"PARENT","line":1236,"updated":"2014-11-24 17:01:59.000000000","message":"there\u0027s really not much left to test is there...","commit_id":"308c6a5e73ad8f9c1c669d7406b7f55bf46e1af0"}]}