)]}'
{"swift/common/__init__.py":[{"author":{"_account_id":330,"name":"John Dickinson","email":"me@not.mn","username":"notmyname"},"change_message_id":"c4e50c89acbfd4276e14616c2c5bcc70ed0d7e45","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"import os"},{"line_number":19,"context_line":"import sys"},{"line_number":20,"context_line":"import oslo.utils.strutils as strutils"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"try:"},{"line_number":23,"context_line":"    import dns  # NOQA"}],"source_content_type":"text/x-python","patch_set":10,"id":"3a961159_1e90cb94","line":20,"updated":"2014-12-08 05:37:42.000000000","message":"if you using swift\u0027s existing \"utils.config_true_value()\" you can avoid this entire dependency","commit_id":"d8e032a65585276c9c7aef568aedd2cd518c7d6e"},{"author":{"_account_id":7823,"name":"Xiang Hui","email":"xianghuir@gmail.com","username":"xianghui"},"change_message_id":"de6c64626b2093f521617df9550ed4679d8bf876","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"import os"},{"line_number":19,"context_line":"import sys"},{"line_number":20,"context_line":"import oslo.utils.strutils as strutils"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"try:"},{"line_number":23,"context_line":"    import dns  # NOQA"}],"source_content_type":"text/x-python","patch_set":10,"id":"3a961159_ded003fa","line":20,"in_reply_to":"3a961159_1e90cb94","updated":"2014-12-08 05:59:01.000000000","message":"From swift/common/__init__.py import swift/common/utils.py might be a bad loop, any other ideas?","commit_id":"d8e032a65585276c9c7aef568aedd2cd518c7d6e"},{"author":{"_account_id":10717,"name":"Sergey Shepelev","email":"temotor@gmail.com"},"change_message_id":"f8f64f28f97eccc22256b47298db2b8953cfc76b","unresolved":false,"context_lines":[{"line_number":49,"context_line":"                       \"imported prior to this env var being set to \u0027yes\u0027.\")"},{"line_number":50,"context_line":"                raise ImportError(msg % (nogreendns))"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"            os.environ[\u0027EVENTLET_NO_GREENDNS\u0027] \u003d \u0027yes\u0027"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"fix_greendns_ipv6()"}],"source_content_type":"text/x-python","patch_set":11,"id":"3a961159_99849fd5","line":52,"updated":"2014-12-09 14:41:20.000000000","message":"os.environ[nogreendns] \u003d \u0027yes\u0027","commit_id":"1897e4ca106743fdc1afa2b5f1b403bca0909497"}],"test/unit/common/test_wsgi_ipv6.py":[{"author":{"_account_id":10717,"name":"Sergey Shepelev","email":"temotor@gmail.com"},"change_message_id":"f8f64f28f97eccc22256b47298db2b8953cfc76b","unresolved":false,"context_lines":[{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    def test_no_evnetlet_no_dnspython(self):"},{"line_number":65,"context_line":"        \"\"\"Test eventlet not imported and dnspython not installed\"\"\""},{"line_number":66,"context_line":"        rc \u003d subprocess.call([\u0027python\u0027, \u0027-c\u0027, no_eventlet_no_dns])"},{"line_number":67,"context_line":"        self.assertEqual(0, rc)"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    def test_evnetlet_no_dnspython(self):"}],"source_content_type":"text/x-python","patch_set":11,"id":"3a961159_594b1787","line":66,"updated":"2014-12-09 14:41:20.000000000","message":"subprocess.call([sys.executable, ...]) is more robust in case you run tests without activating virtualenv, like venv-{2.7,3.3,3.4}/bin/nose ...","commit_id":"1897e4ca106743fdc1afa2b5f1b403bca0909497"},{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"ee127dd68e8c879c57ae06566a6905ed3dd371df","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    sys.exit(%d)"},{"line_number":43,"context_line":"else:"},{"line_number":44,"context_line":"    sys.exit(%d)"},{"line_number":45,"context_line":"\"\"\""},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"eventlet_no_dns \u003d script % (True, \u0027import eventlet\u0027,"},{"line_number":48,"context_line":"                            \u0027fake\u0027, \u0027foo\u0027, \u0027not\u0027, 1, 0)"}],"source_content_type":"text/x-python","patch_set":12,"id":"da86d52c_22fa6475","line":45,"updated":"2015-02-03 23:41:37.000000000","message":"To make these more readable can you use the \u0027%(variable)d\u0027 or %(variable)s\u0027 form: \n\n  ...\n  mockdns \u003d %(mockdns)s\n  %(import_statement)s\n  ...\n\nThen when you pass in variables below: \n\n  eventlet_no_dns \u003d script % dict(mockdns\u003dTrue, import_statment\u003d\u0027import eventlet\u0027, ...\n\nThat will make the test much more maintainable and readable.","commit_id":"eda9c56602d65a472f2423dc01ccd25dca77bf9b"}]}