)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"a61d6dd605a9a02a01bbb71db862ea0d71f9adfc","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Currently, when \"swift-init restart \u003cservice(s)\u003e\" is run and any of"},{"line_number":10,"context_line":"services selected don\u0027t stop cleanly (generally due to taking longer"},{"line_number":11,"context_line":"than the max time of 15sec), the code still tries to start a new"},{"line_number":12,"context_line":"process and the following warning is observed:"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"WARNING: Unable to modify max process limit. Running as non-root?"},{"line_number":15,"context_line":"\u003cservice\u003e running (\u003cpid\u003e - /etc/swift/\u003cconf_file\u003e)"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"fa98f980_b911c75e","line":12,"updated":"2014-09-05 13:10:49.000000000","message":"This comment threw me at first - it does try to start a new service - see swift/common/manager.py line 645 - after printing the lines starting \u003cservice\u003e below the launch method returns without launching a new process.\n\nBut it does call the Manager.start() method which causes this WARNING","commit_id":"cb623d7c1f654d3bf35868d34c2fc52f55b7dfad"}],"swift/common/manager.py":[{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"a61d6dd605a9a02a01bbb71db862ea0d71f9adfc","unresolved":false,"context_lines":[{"line_number":294,"context_line":"                # If service stops cleanly"},{"line_number":295,"context_line":"                    status +\u003d m.start(**kwargs)"},{"line_number":296,"context_line":"                else:"},{"line_number":297,"context_line":"                    print \"Not starting \" + str(server) + \" as it hasn\u0027t \\"},{"line_number":298,"context_line":"                          stopped cleanly.\""},{"line_number":299,"context_line":"                    status +\u003d ser_status"},{"line_number":300,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"fa98f980_2033cff6","line":297,"updated":"2014-09-05 13:10:49.000000000","message":"print (_(\"Not starting %s as it hasn\u0027t stopped cleanly.\")\n       % server)","commit_id":"cb623d7c1f654d3bf35868d34c2fc52f55b7dfad"}],"test/unit/common/test_manager.py":[{"author":{"_account_id":9625,"name":"Thiago da Silva","email":"thiagodasilva@gmail.com","username":"thiago"},"change_message_id":"17f13a2bc46d721f8ad1fd907155d11539404f57","unresolved":false,"context_lines":[{"line_number":1734,"context_line":"        self.assertEquals(m.stop_was_called, True)"},{"line_number":1735,"context_line":""},{"line_number":1736,"context_line":"    def test_restart(self):"},{"line_number":1737,"context_line":"        m \u003d manager.Manager([\u0027test\u0027])"},{"line_number":1738,"context_line":"        status \u003d m.restart()"},{"line_number":1739,"context_line":"        self.assertEquals(status, 0)"},{"line_number":1740,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"ba7be1f8_d034454c","line":1737,"updated":"2015-02-27 16:19:37.000000000","message":"I\u0027d suggest adding more tests. Current tests only covers the first \u0027if\u0027 in the code, because the server returns with a status of 1. None of the new code (after else) is covered.","commit_id":"9e3d88471fec98d49b0368715d938cea74aa29c4"},{"author":{"_account_id":16233,"name":"Mauricio Lima","email":"mauriciolimab@gmail.com","username":"limamauricio"},"change_message_id":"cd496a138ad7f70dde35cef4c2d3bfbc9efc8725","unresolved":false,"context_lines":[{"line_number":1737,"context_line":"        m \u003d manager.Manager([\u0027test\u0027])"},{"line_number":1738,"context_line":"        status \u003d m.restart()"},{"line_number":1739,"context_line":"        self.assertEquals(status, 0)"},{"line_number":1740,"context_line":""},{"line_number":1741,"context_line":"    def test_reload(self):"},{"line_number":1742,"context_line":"        class MockManager(object):"},{"line_number":1743,"context_line":"            called \u003d defaultdict(list)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a016987_bf55471e","line":1740,"updated":"2015-05-14 19:56:52.000000000","message":"Few tests, I believe it is necessary to add some more to ensure better coverage of scenarios.","commit_id":"9e3d88471fec98d49b0368715d938cea74aa29c4"}]}
