)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"51f36664d6f58c04eadf43a69953d8b85e3f1423","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Limit value should always be an integer"},{"line_number":10,"context_line":"for the listing of continers and objects."},{"line_number":11,"context_line":"Here added a check for the limit value."},{"line_number":12,"context_line":"DocImpact"},{"line_number":13,"context_line":"Closes-Bug: 1364071"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I87abbb02af101d0c198977dd3b3462ee4445687c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"baa201ad_08b3904d","line":12,"updated":"2014-10-16 06:09:56.000000000","message":"Add a blank line before DocImpact, otherwise the trigger wont happen in the system:\n\n  Added a check for limit value\n\n  Limit value should always be an integer\n  for the listing of continers and objects.\n  Here added a check for the limit value.\n\n  DocImpact\n  Closes-Bug: 1364071\n\n  Change-Id: I87abbb02af101d0c198977dd3b3462ee4445687c","commit_id":"1d7fe681187c82a310093b015a7d63fdd5637556"}],"swift/account/server.py":[{"author":{"_account_id":330,"name":"John Dickinson","email":"me@not.mn","username":"notmyname"},"change_message_id":"22127c5a0d02e0e9389b2d80cfc98ef6c4d7d5ca","unresolved":false,"context_lines":[{"line_number":193,"context_line":"        given_limit \u003d get_param(req, \u0027limit\u0027)"},{"line_number":194,"context_line":"        if given_limit and not given_limit.isdigit():"},{"line_number":195,"context_line":"           return HTTPPreconditionFailed(\"limit must be an integer value\\n\")"},{"line_number":196,"context_line":"        if given_limit and given_limit.isdigit():"},{"line_number":197,"context_line":"            limit \u003d int(given_limit)"},{"line_number":198,"context_line":"            if limit \u003e constraints.ACCOUNT_LISTING_LIMIT:"},{"line_number":199,"context_line":"                return HTTPPreconditionFailed("}],"source_content_type":"text/x-python","patch_set":1,"id":"fa98f980_22cd4c32","line":196,"updated":"2014-09-01 16:40:39.000000000","message":"Can these two conditional be rewritten to be simpler? maybe:\n\n    if given_limit:\n        if given_limit.isdigit():\n            ....\n        else:\n            return ....","commit_id":"5ff58f58e61273a65d059abd47ebf422faef025c"},{"author":{"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},"change_message_id":"4ab3d425ea8f44583e06d8accf6d79801392cb3e","unresolved":false,"context_lines":[{"line_number":192,"context_line":"        limit \u003d constraints.ACCOUNT_LISTING_LIMIT"},{"line_number":193,"context_line":"        given_limit \u003d get_param(req, \u0027limit\u0027)"},{"line_number":194,"context_line":"        if given_limit and not given_limit.isdigit():"},{"line_number":195,"context_line":"            return HTTPPreconditionFailed(\"limit must be an integer value\\n\")"},{"line_number":196,"context_line":"        if given_limit and given_limit.isdigit():"},{"line_number":197,"context_line":"            limit \u003d int(given_limit)"},{"line_number":198,"context_line":"            if limit \u003e constraints.ACCOUNT_LISTING_LIMIT:"}],"source_content_type":"text/x-python","patch_set":4,"id":"baa201ad_13178aa4","line":195,"updated":"2014-10-02 13:49:58.000000000","message":"This is not a precondition. Those are things like If-Match, If-Unmodified-Since, If-Range, and so on.\n\nThe right response status here is just 400 Bad Request.","commit_id":"c008b0a45249d33c2177083c81d83db3aef10af3"},{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"e84e5eca90b956b1f4e20740bfedd421620dee16","unresolved":false,"context_lines":[{"line_number":192,"context_line":"        limit \u003d constraints.ACCOUNT_LISTING_LIMIT"},{"line_number":193,"context_line":"        given_limit \u003d get_param(req, \u0027limit\u0027)"},{"line_number":194,"context_line":"        if given_limit and not given_limit.isdigit():"},{"line_number":195,"context_line":"            return HTTPBadRequest(\"limit must be an integer value\\n\")"},{"line_number":196,"context_line":"        if given_limit and given_limit.isdigit():"},{"line_number":197,"context_line":"            limit \u003d int(given_limit)"},{"line_number":198,"context_line":"            if limit \u003e constraints.ACCOUNT_LISTING_LIMIT:"}],"source_content_type":"text/x-python","patch_set":5,"id":"baa201ad_efa82879","line":195,"updated":"2014-10-06 03:31:37.000000000","message":"I\u0027d prefer the error body to begin with a capital:\n\n  Limit must be an integer value\n\nBut if you don\u0027t want to capitalise \u0027limit\u0027 as it references a variable, maybe we can reword it?\n\n  The limit must be an integer value.\n\nor\n\n  An integer value is expected for limit.","commit_id":"3342a1131438186d8b12bddfc38d26382f69098d"},{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"fe0f582240a113fbc030bd615ce7fa842bba6014","unresolved":false,"context_lines":[{"line_number":192,"context_line":"        limit \u003d constraints.ACCOUNT_LISTING_LIMIT"},{"line_number":193,"context_line":"        given_limit \u003d get_param(req, \u0027limit\u0027)"},{"line_number":194,"context_line":"        if given_limit and not given_limit.isdigit():"},{"line_number":195,"context_line":"            return HTTPBadRequest(\"Value of limit must be an integer\\n\")"},{"line_number":196,"context_line":"        if given_limit and given_limit.isdigit():"},{"line_number":197,"context_line":"            limit \u003d int(given_limit)"},{"line_number":198,"context_line":"            if limit \u003e constraints.ACCOUNT_LISTING_LIMIT:"}],"source_content_type":"text/x-python","patch_set":6,"id":"baa201ad_691cb8c2","line":195,"updated":"2014-10-10 06:03:07.000000000","message":"I don\u0027t mean to be picky, but because you are using the isdigit() string method, a negative number e.g -1 will fail.. as it should because that isn\u0027t a valid limit value, however the error will say that the value must be an integer and -1 is just that, a valid integer. \n\nThis shouldn\u0027t happen and I know I\u0027m being pedantic (maybe it\u0027s because its Friday arvo :P) but if we change the message to:\n\n   \"Value of limit must be a positive integer\\n\"\n\nWe might save ourselves a potential bug report in the future.","commit_id":"3cfe1fcc84e74f264b60c68a42e3c5bc4599b738"},{"author":{"_account_id":8085,"name":"anju Tiwari","email":"anjutiwari5@gmail.com","username":"Anju"},"change_message_id":"c71453333cb03799646a727294eae5b3f135ff0b","unresolved":false,"context_lines":[{"line_number":192,"context_line":"        limit \u003d constraints.ACCOUNT_LISTING_LIMIT"},{"line_number":193,"context_line":"        given_limit \u003d get_param(req, \u0027limit\u0027)"},{"line_number":194,"context_line":"        if given_limit and not given_limit.isdigit():"},{"line_number":195,"context_line":"            return HTTPBadRequest(\"Value of limit must be an integer\\n\")"},{"line_number":196,"context_line":"        if given_limit and given_limit.isdigit():"},{"line_number":197,"context_line":"            limit \u003d int(given_limit)"},{"line_number":198,"context_line":"            if limit \u003e constraints.ACCOUNT_LISTING_LIMIT:"}],"source_content_type":"text/x-python","patch_set":6,"id":"baa201ad_8962bc14","line":195,"in_reply_to":"baa201ad_691cb8c2","updated":"2014-10-10 06:11:06.000000000","message":"Hi Matthew,\nI agree.\n\nCorrect.","commit_id":"3cfe1fcc84e74f264b60c68a42e3c5bc4599b738"},{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"11fca9299aa305a77fd87180fb8d96680cea8f84","unresolved":false,"context_lines":[{"line_number":193,"context_line":"        given_limit \u003d get_param(req, \u0027limit\u0027)"},{"line_number":194,"context_line":"        if given_limit and not given_limit.isdigit():"},{"line_number":195,"context_line":"            return HTTPBadRequest("},{"line_number":196,"context_line":"                \"Value of limit must be positive integer\\n\")"},{"line_number":197,"context_line":"        if given_limit and given_limit.isdigit():"},{"line_number":198,"context_line":"            limit \u003d int(given_limit)"},{"line_number":199,"context_line":"            if limit \u003e constraints.ACCOUNT_LISTING_LIMIT:"}],"source_content_type":"text/x-python","patch_set":11,"id":"baa201ad_1dcdb4b7","line":196,"updated":"2014-10-15 04:10:01.000000000","message":"Missing the \u0027a\u0027:\n\n  Value of limit must be a positive integer\n\nAs it is in container/server.py","commit_id":"b6aefae067408aa04e1724f447d89efefb55bd27"},{"author":{"_account_id":8085,"name":"anju Tiwari","email":"anjutiwari5@gmail.com","username":"Anju"},"change_message_id":"8eb4243b023020593dd5bc86ab44a44c6d8a16ac","unresolved":false,"context_lines":[{"line_number":193,"context_line":"        given_limit \u003d get_param(req, \u0027limit\u0027)"},{"line_number":194,"context_line":"        if given_limit and not given_limit.isdigit():"},{"line_number":195,"context_line":"            return HTTPBadRequest("},{"line_number":196,"context_line":"                \"Value of limit must be positive integer\\n\")"},{"line_number":197,"context_line":"        if given_limit and given_limit.isdigit():"},{"line_number":198,"context_line":"            limit \u003d int(given_limit)"},{"line_number":199,"context_line":"            if limit \u003e constraints.ACCOUNT_LISTING_LIMIT:"}],"source_content_type":"text/x-python","patch_set":11,"id":"baa201ad_059c6469","line":196,"in_reply_to":"baa201ad_1dcdb4b7","updated":"2014-10-15 19:09:46.000000000","message":"Thanks,\n\nI missed it in account/server.py only.","commit_id":"b6aefae067408aa04e1724f447d89efefb55bd27"}],"swift/container/server.py":[{"author":{"_account_id":330,"name":"John Dickinson","email":"me@not.mn","username":"notmyname"},"change_message_id":"22127c5a0d02e0e9389b2d80cfc98ef6c4d7d5ca","unresolved":false,"context_lines":[{"line_number":445,"context_line":"        given_limit \u003d get_param(req, \u0027limit\u0027)"},{"line_number":446,"context_line":"        if given_limit and not given_limit.isdigit():"},{"line_number":447,"context_line":"           return HTTPPreconditionFailed(\"limit must be an integer value\\n\")"},{"line_number":448,"context_line":"        if given_limit and given_limit.isdigit():"},{"line_number":449,"context_line":"            limit \u003d int(given_limit)"},{"line_number":450,"context_line":"            if limit \u003e constraints.CONTAINER_LISTING_LIMIT:"},{"line_number":451,"context_line":"                return HTTPPreconditionFailed("}],"source_content_type":"text/x-python","patch_set":1,"id":"fa98f980_a2513c64","line":448,"updated":"2014-09-01 16:40:39.000000000","message":"Can these two conditional be rewritten to be simpler? maybe:\n\n    if given_limit:\n        if given_limit.isdigit():\n            ....\n        else:\n            return ....","commit_id":"5ff58f58e61273a65d059abd47ebf422faef025c"}]}