)]}'
{"bin/swift-dispersion-populate":[{"author":{"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},"change_message_id":"b0271900a2ae5f55d174abaa999c449b6bfc1f95","unresolved":false,"context_lines":[{"line_number":205,"context_line":"                                                  full_listing\u003dTrue)[1]]"},{"line_number":206,"context_line":"                for my_object in objects:"},{"line_number":207,"context_line":"                    partition, null \u003d object_ring.get_nodes(account, container,"},{"line_number":208,"context_line":"                                                            my_object)"},{"line_number":209,"context_line":"                    if partition in parts_left:"},{"line_number":210,"context_line":"                        del parts_left[partition]"},{"line_number":211,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":2,"id":"fa98f980_7e0ab67a","line":208,"updated":"2014-09-16 18:02:39.000000000","message":"nit: there\u0027s a get_part() method that just gives you the partition, and it does slightly less work than calling get_nodes() and throwing away the nodes.\n\nof course, swift-dispersion-populate\u0027s runtime is normally dominated by the vast number of HTTP requests it makes. that\u0027s why this is in the \"nit\" category instead of the \"please fix\" category.","commit_id":"24e22b34d02e9e122531394d6dd25e490b5aa9cc"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"d655ce16941bf2b8726cd242da59bbdf01761697","unresolved":false,"context_lines":[{"line_number":169,"context_line":"        begun \u003d next_report \u003d time()"},{"line_number":170,"context_line":"        next_report +\u003d 2"},{"line_number":171,"context_line":"        suffix \u003d 0"},{"line_number":172,"context_line":"        while need_to_queue \u003e\u003d 1:"},{"line_number":173,"context_line":"            container \u003d \u0027dispersion_%d\u0027 % suffix"},{"line_number":174,"context_line":"            part \u003d container_ring.get_part(account, container)"},{"line_number":175,"context_line":"            if part in parts_left:"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"fa98f980_9a866615","line":172,"updated":"2014-09-17 17:45:43.000000000","message":"if you run with --no-overlap enough times, in particular with small part power (e.g. on SAIO) and large dispersion coverage, then eventually this loop ain\u0027t coming back...\n\nneeds:\n  while need_to_queue \u003e\u003d 1 and parts_left:\n\nsame for objects below.","commit_id":"aa988c7f3410ccb25bc802ae9b39b8162a025440"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"d655ce16941bf2b8726cd242da59bbdf01761697","unresolved":false,"context_lines":[{"line_number":185,"context_line":"        elapsed, elapsed_unit \u003d get_time_units(time() - begun)"},{"line_number":186,"context_line":"        print \u0027\\r\\x1B[KCreated %d containers for dispersion reporting, \u0027 \\"},{"line_number":187,"context_line":"              \u0027%d%s, %d retries\u0027 % \\"},{"line_number":188,"context_line":"              (need_to_create, round(elapsed), elapsed_unit, retries_done)"},{"line_number":189,"context_line":"        stdout.flush()"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"    if object_populate:"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"fa98f980_fab3f2e6","line":188,"updated":"2014-09-17 17:45:43.000000000","message":"If the while condition is changed then the reported number of created containers should be (need_to_create - need_to_queue)\n\nMight be nice to print the resulting dispersion coverage \u003d (partition_count - len(parts_left)) / partition_count","commit_id":"aa988c7f3410ccb25bc802ae9b39b8162a025440"}]}
