)]}'
{"swift/obj/expirer.py":[{"author":{"_account_id":7479,"name":"paul luse","email":"paul.e.luse@intel.com","username":"peluse"},"change_message_id":"10f5e086bcc0a75027c80613a3bd16afc608ad84","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"from swift.container.reconciler import direct_delete_container_entry"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"MAX_OBJECTS_TO_CACHE \u003d 100000"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"class ObjectExpirer(Daemon):"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa98f980_9b6bf71e","line":34,"updated":"2014-09-06 22:37:14.000000000","message":"any specific reason for choosing this value?","commit_id":"6c4a717fbd148dac59d46c5a7bd3dc490455479b"},{"author":{"_account_id":995,"name":"David Goetz","email":"david.goetz@rackspace.com","username":"david-goetz"},"change_message_id":"15dc2d3ddd3cde177a2573a2a227d1f23476ac29","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"from swift.container.reconciler import direct_delete_container_entry"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"MAX_OBJECTS_TO_CACHE \u003d 100000"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"class ObjectExpirer(Daemon):"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa98f980_3424bcc5","line":34,"in_reply_to":"fa98f980_9b6bf71e","updated":"2014-09-08 14:53:29.000000000","message":"no- not really. just wanted  big enough number to get a bunch of containers but not so much to take a lot of memory.","commit_id":"6c4a717fbd148dac59d46c5a7bd3dc490455479b"},{"author":{"_account_id":6968,"name":"Christian Schwede","email":"cschwede@nvidia.com","username":"cschwede"},"change_message_id":"01c15b12e79e9f83c4bc6614984c1d6bc120c031","unresolved":false,"context_lines":[{"line_number":114,"context_line":"                        split_path(\u0027/\u0027 + actual_obj, 3, 3, True)"},{"line_number":115,"context_line":"                    cache_key \u003d \u0027%s/%s\u0027 % (cust_account, cust_cont)"},{"line_number":116,"context_line":"                except ValueError:"},{"line_number":117,"context_line":"                    cache_key \u003d None"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"                if self.processes \u003e 0:"},{"line_number":120,"context_line":"                    obj_process \u003d int("}],"source_content_type":"text/x-python","patch_set":2,"id":"fa98f980_bb6d1b9c","line":117,"updated":"2014-09-06 21:15:41.000000000","message":"Probably I miss something here, but when does this exception gets raised?","commit_id":"6c4a717fbd148dac59d46c5a7bd3dc490455479b"},{"author":{"_account_id":995,"name":"David Goetz","email":"david.goetz@rackspace.com","username":"david-goetz"},"change_message_id":"15dc2d3ddd3cde177a2573a2a227d1f23476ac29","unresolved":false,"context_lines":[{"line_number":114,"context_line":"                        split_path(\u0027/\u0027 + actual_obj, 3, 3, True)"},{"line_number":115,"context_line":"                    cache_key \u003d \u0027%s/%s\u0027 % (cust_account, cust_cont)"},{"line_number":116,"context_line":"                except ValueError:"},{"line_number":117,"context_line":"                    cache_key \u003d None"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"                if self.processes \u003e 0:"},{"line_number":120,"context_line":"                    obj_process \u003d int("}],"source_content_type":"text/x-python","patch_set":2,"id":"fa98f980_771c866b","line":117,"in_reply_to":"fa98f980_bb6d1b9c","updated":"2014-09-08 14:53:29.000000000","message":"it shouldn\u0027t get raised but i usually put a try except ValueError around split_path so I guess its just habit. also, the old code would have run the delete on the path even if this throws an error so this should maintain that behavior.","commit_id":"6c4a717fbd148dac59d46c5a7bd3dc490455479b"},{"author":{"_account_id":7479,"name":"paul luse","email":"paul.e.luse@intel.com","username":"peluse"},"change_message_id":"10f5e086bcc0a75027c80613a3bd16afc608ad84","unresolved":false,"context_lines":[{"line_number":224,"context_line":"        \"\"\""},{"line_number":225,"context_line":"        Gets the processes, process from the kwargs if those values exist."},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"        Otherwise, return processes, process set in the config file."},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"        :param kwargs: Keyword args passed into the run_forever(), run_once()"},{"line_number":230,"context_line":"                       methods.  They have values specified on the command"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa98f980_1bc62717","line":227,"updated":"2014-09-06 22:37:14.000000000","message":"no longer returning anything","commit_id":"6c4a717fbd148dac59d46c5a7bd3dc490455479b"},{"author":{"_account_id":995,"name":"David Goetz","email":"david.goetz@rackspace.com","username":"david-goetz"},"change_message_id":"15dc2d3ddd3cde177a2573a2a227d1f23476ac29","unresolved":false,"context_lines":[{"line_number":224,"context_line":"        \"\"\""},{"line_number":225,"context_line":"        Gets the processes, process from the kwargs if those values exist."},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"        Otherwise, return processes, process set in the config file."},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"        :param kwargs: Keyword args passed into the run_forever(), run_once()"},{"line_number":230,"context_line":"                       methods.  They have values specified on the command"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa98f980_57ab02d6","line":227,"in_reply_to":"fa98f980_1bc62717","updated":"2014-09-08 14:53:29.000000000","message":"i\u0027ll change this","commit_id":"6c4a717fbd148dac59d46c5a7bd3dc490455479b"}]}