)]}'
{"swift/common/ring/builder.py":[{"author":{"_account_id":8996,"name":"Florent Flament","email":"contact@florentflament.com","username":"florent"},"change_message_id":"da5d31c90fec6a9a6ea3ee681d316bcd1065d55f","unresolved":false,"context_lines":[{"line_number":374,"context_line":"                # decreased, and that actually means the partition has changed"},{"line_number":375,"context_line":"                try:"},{"line_number":376,"context_line":"                    old \u003d old_replica2part2dev[rep_id][part_id]"},{"line_number":377,"context_line":"                    new \u003d self._replica2part2dev[rep_id][part_id]"},{"line_number":378,"context_line":"                except IndexError:"},{"line_number":379,"context_line":"                    changed_parts +\u003d 1"},{"line_number":380,"context_line":"                    continue"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa98f980_7b3e53dc","line":377,"updated":"2014-09-16 12:32:43.000000000","message":"IMHO, you may use `_part` here, instead of fetching `self._replica2part2dev[rep_id][part_id]`, which value should be the same.","commit_id":"ec04595995ee0728704f3d1b1b4fd564d586eecb"},{"author":{"_account_id":6968,"name":"Christian Schwede","email":"cschwede@nvidia.com","username":"cschwede"},"change_message_id":"086d42fe76e80389b821d4eb027dfbfb4f404602","unresolved":false,"context_lines":[{"line_number":374,"context_line":"                # decreased, and that actually means the partition has changed"},{"line_number":375,"context_line":"                try:"},{"line_number":376,"context_line":"                    old \u003d old_replica2part2dev[rep_id][part_id]"},{"line_number":377,"context_line":"                    new \u003d self._replica2part2dev[rep_id][part_id]"},{"line_number":378,"context_line":"                except IndexError:"},{"line_number":379,"context_line":"                    changed_parts +\u003d 1"},{"line_number":380,"context_line":"                    continue"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa98f980_86eabaaa","line":377,"in_reply_to":"fa98f980_7b3e53dc","updated":"2014-09-16 12:54:11.000000000","message":"Oh, you\u0027re right. And actually _part is not a partition, but a device. I will change this, thanks!","commit_id":"ec04595995ee0728704f3d1b1b4fd564d586eecb"},{"author":{"_account_id":8996,"name":"Florent Flament","email":"contact@florentflament.com","username":"florent"},"change_message_id":"da5d31c90fec6a9a6ea3ee681d316bcd1065d55f","unresolved":false,"context_lines":[{"line_number":377,"context_line":"                    new \u003d self._replica2part2dev[rep_id][part_id]"},{"line_number":378,"context_line":"                except IndexError:"},{"line_number":379,"context_line":"                    changed_parts +\u003d 1"},{"line_number":380,"context_line":"                    continue"},{"line_number":381,"context_line":""},{"line_number":382,"context_line":"                if old !\u003d new:"},{"line_number":383,"context_line":"                    changed_parts +\u003d 1"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa98f980_7b7013dd","line":380,"updated":"2014-09-16 12:32:43.000000000","message":"I think this \u0027continue\u0027 can be removed","commit_id":"ec04595995ee0728704f3d1b1b4fd564d586eecb"},{"author":{"_account_id":8996,"name":"Florent Flament","email":"contact@florentflament.com","username":"florent"},"change_message_id":"24fef0f97b67985f9f9bfff7fb25894a04332450","unresolved":false,"context_lines":[{"line_number":377,"context_line":"                    new \u003d self._replica2part2dev[rep_id][part_id]"},{"line_number":378,"context_line":"                except IndexError:"},{"line_number":379,"context_line":"                    changed_parts +\u003d 1"},{"line_number":380,"context_line":"                    continue"},{"line_number":381,"context_line":""},{"line_number":382,"context_line":"                if old !\u003d new:"},{"line_number":383,"context_line":"                    changed_parts +\u003d 1"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa98f980_4666122b","line":380,"in_reply_to":"fa98f980_46ec522a","updated":"2014-09-16 13:04:50.000000000","message":"Indeed you\u0027re right.","commit_id":"ec04595995ee0728704f3d1b1b4fd564d586eecb"},{"author":{"_account_id":6968,"name":"Christian Schwede","email":"cschwede@nvidia.com","username":"cschwede"},"change_message_id":"6f2e518b00b9fccbf221e07b471e8b5552e5df66","unresolved":false,"context_lines":[{"line_number":377,"context_line":"                    new \u003d self._replica2part2dev[rep_id][part_id]"},{"line_number":378,"context_line":"                except IndexError:"},{"line_number":379,"context_line":"                    changed_parts +\u003d 1"},{"line_number":380,"context_line":"                    continue"},{"line_number":381,"context_line":""},{"line_number":382,"context_line":"                if old !\u003d new:"},{"line_number":383,"context_line":"                    changed_parts +\u003d 1"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa98f980_06e08a95","line":380,"in_reply_to":"fa98f980_46ec522a","updated":"2014-09-16 13:01:04.000000000","message":"OK, it\u0027s a list, not a dict, so I can\u0027t use .get() here - so keeping the try..except block.","commit_id":"ec04595995ee0728704f3d1b1b4fd564d586eecb"},{"author":{"_account_id":6968,"name":"Christian Schwede","email":"cschwede@nvidia.com","username":"cschwede"},"change_message_id":"086d42fe76e80389b821d4eb027dfbfb4f404602","unresolved":false,"context_lines":[{"line_number":377,"context_line":"                    new \u003d self._replica2part2dev[rep_id][part_id]"},{"line_number":378,"context_line":"                except IndexError:"},{"line_number":379,"context_line":"                    changed_parts +\u003d 1"},{"line_number":380,"context_line":"                    continue"},{"line_number":381,"context_line":""},{"line_number":382,"context_line":"                if old !\u003d new:"},{"line_number":383,"context_line":"                    changed_parts +\u003d 1"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa98f980_46ec522a","line":380,"in_reply_to":"fa98f980_7b7013dd","updated":"2014-09-16 12:54:11.000000000","message":"No, otherwise it will hit the comparison in the next line and that will either fail, because old is not set or set to a wrong value from a former forloop-iteration.\nOf course I could set this in the try... block, but I like to keep try..except blocks small to only catch the expected errors.\nBut then I could use .get() as well... Hmm.","commit_id":"ec04595995ee0728704f3d1b1b4fd564d586eecb"}]}