)]}'
{"swift/common/data_migrator_drivers.py":[{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"a2e7118f0c90a465523a3ae193c7dec1f57ef0ff","unresolved":false,"context_lines":[{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    @classmethod"},{"line_number":78,"context_line":"    def check_headers(cls, headers):"},{"line_number":79,"context_line":"        data_source \u003d headers.get(\u0027X-Container-Migration-Source\u0027)"},{"line_number":80,"context_line":"        if data_source.strip() \u003d\u003d \u0027\u0027 or data_source.find(\u0027..\u0027) \u003e\u003d 0:"},{"line_number":81,"context_line":"            raise DataMigrationDriverError(\u0027Migration source \u0027 +"},{"line_number":82,"context_line":"                                           \u0027{0} \u0027.format((data_source)) +"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa98f980_3b7f52ad","line":79,"updated":"2014-09-17 06:02:52.000000000","message":"If the header doesn\u0027t exist, then data_source will be none, bombing out of the code. \nYou need to a:\n\n  if not data_source:\n\nLike you did in check_conf.. but now check_headers and check_conf are very similar  and is_valid_path below is no longer used (at all).. maybe we can grab the path in the checks and call/modify is_valid_path to do what we want, so we don\u0027t have code duplication?","commit_id":"56c34bc38fd06e2be6980dd17788b1d41598352d"}]}