)]}'
{"swift/common/manager.py":[{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"6819ee53995a2e3a51cc34d3fd1063784abd6870","unresolved":false,"context_lines":[{"line_number":624,"context_line":"        \"\"\""},{"line_number":625,"context_line":"        conf_files \u003d self.conf_files(**kwargs)"},{"line_number":626,"context_line":"        if not conf_files:"},{"line_number":627,"context_line":"            return {}"},{"line_number":628,"context_line":""},{"line_number":629,"context_line":"        pids \u003d self.get_running_pids(**kwargs)"},{"line_number":630,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa98f980_364767be","line":627,"updated":"2014-09-17 06:29:39.000000000","message":"Why did you change the return of an empty list \u0027[]\u0027 to an empty dict \u0027{}\u0027?\n\nThis doesn\u0027t affect your change and seems unneeded.","commit_id":"105c7b1bfad41f6b89eed8004f27af6cf20ebab4"},{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"ebe93ab6c5355c1e937e587ca86a3d66703c9237","unresolved":false,"context_lines":[{"line_number":624,"context_line":"        \"\"\""},{"line_number":625,"context_line":"        conf_files \u003d self.conf_files(**kwargs)"},{"line_number":626,"context_line":"        if not conf_files:"},{"line_number":627,"context_line":"            return {}"},{"line_number":628,"context_line":""},{"line_number":629,"context_line":"        pids \u003d self.get_running_pids(**kwargs)"},{"line_number":630,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"da9df570_010688ce","line":627,"in_reply_to":"da9df570_36ce8284","updated":"2014-09-23 04:05:36.000000000","message":"I think David is obviously correct about the return type, tactically. But in practice, nobody ever cares for the correct type... Not in the known code anyway. So strategically I think we\u0027re free to replace it with a bool. Maybe some other time.","commit_id":"105c7b1bfad41f6b89eed8004f27af6cf20ebab4"},{"author":{"_account_id":995,"name":"David Goetz","email":"david.goetz@rackspace.com","username":"david-goetz"},"change_message_id":"15e4b29da2dd3985f21c750412aa3a03aeca5b3b","unresolved":false,"context_lines":[{"line_number":624,"context_line":"        \"\"\""},{"line_number":625,"context_line":"        conf_files \u003d self.conf_files(**kwargs)"},{"line_number":626,"context_line":"        if not conf_files:"},{"line_number":627,"context_line":"            return {}"},{"line_number":628,"context_line":""},{"line_number":629,"context_line":"        pids \u003d self.get_running_pids(**kwargs)"},{"line_number":630,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"da9df570_36ce8284","line":627,"in_reply_to":"fa98f980_364767be","updated":"2014-09-22 15:57:54.000000000","message":"I noticed when writing my unit tests. On success, this function returns a dictionary: pids[pid] \u003d conf_file, but when it doesn\u0027t launch anything it returns a list. That meant if you wanted to look at the results you had to check their type first. I figured it was a mistake, imo its a lot better to return a dictionary in both cases. Pretty sure it doesn\u0027t affect any uses in the code.","commit_id":"105c7b1bfad41f6b89eed8004f27af6cf20ebab4"},{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"ebe93ab6c5355c1e937e587ca86a3d66703c9237","unresolved":false,"context_lines":[{"line_number":643,"context_line":"                already_started \u003d True"},{"line_number":644,"context_line":"                print _(\"%s running (%s - %s)\") % (self.server, pid, pid_file)"},{"line_number":645,"context_line":""},{"line_number":646,"context_line":"        if already_started and not conf_files:"},{"line_number":647,"context_line":"            print _(\"%s already started...\") % self.server"},{"line_number":648,"context_line":"            return {}"},{"line_number":649,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"da9df570_4a1265b2","line":646,"updated":"2014-09-23 04:05:36.000000000","message":"It looks to me that you can get rid of already_started completely if you make conf_files[] to track what remains to start. Just delete it and the code will continue to work like the one in this patch. Am I right?","commit_id":"105c7b1bfad41f6b89eed8004f27af6cf20ebab4"},{"author":{"_account_id":995,"name":"David Goetz","email":"david.goetz@rackspace.com","username":"david-goetz"},"change_message_id":"23a276ca1df121c349372c2cd69210f8b8a80e99","unresolved":false,"context_lines":[{"line_number":643,"context_line":"                already_started \u003d True"},{"line_number":644,"context_line":"                print _(\"%s running (%s - %s)\") % (self.server, pid, pid_file)"},{"line_number":645,"context_line":""},{"line_number":646,"context_line":"        if already_started and not conf_files:"},{"line_number":647,"context_line":"            print _(\"%s already started...\") % self.server"},{"line_number":648,"context_line":"            return {}"},{"line_number":649,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"baa201ad_cb5f5f71","line":646,"in_reply_to":"da9df570_4a1265b2","updated":"2014-09-29 16:40:21.000000000","message":"is that true? look at: \n\nelif not kwargs.get(\u0027number\u0027, 0):","commit_id":"105c7b1bfad41f6b89eed8004f27af6cf20ebab4"},{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"6819ee53995a2e3a51cc34d3fd1063784abd6870","unresolved":false,"context_lines":[{"line_number":645,"context_line":""},{"line_number":646,"context_line":"        if already_started and not conf_files:"},{"line_number":647,"context_line":"            print _(\"%s already started...\") % self.server"},{"line_number":648,"context_line":"            return {}"},{"line_number":649,"context_line":""},{"line_number":650,"context_line":"        if self.server not in START_ONCE_SERVERS:"},{"line_number":651,"context_line":"            kwargs[\u0027once\u0027] \u003d False"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa98f980_76100fac","line":648,"updated":"2014-09-17 06:29:39.000000000","message":"Change in return here isn\u0027t needed unless I\u0027ve missed something.","commit_id":"105c7b1bfad41f6b89eed8004f27af6cf20ebab4"}]}
