)]}'
{"swift/obj/auditor.py":[{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"715d37ecdbee946eecd331fcd91a1aab8b950d4c","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        raise DiskFileQuarantined(\u0027Disk partition %s\u0027"},{"line_number":53,"context_line":"                                  \u0027does not match object \u0027"},{"line_number":54,"context_line":"                                  \u0027rings partition %s\u0027 % (df.partition,"},{"line_number":55,"context_line":"                                                          obj_ring_part))"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"class AuditorWorker(object):"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa98f980_1a24360d","line":55,"updated":"2014-09-17 17:26:30.000000000","message":"Have you seen a specific scenario where this happened?  (some rouge proxy with a janky ring or messed up hash suffix/prefix?)\n\nI guess I\u0027m worried about the quarantine just cause I wonder if when this happens if all replicas might be in the wrong partition?  Could we just move the whole hashdir into the right part?","commit_id":"55c07a524479d36d69957f6f07399f41ce1fabaa"},{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"d335f081c1a3bd91b2d3b7fae4ad1e26caf9d87e","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        raise DiskFileQuarantined(\u0027Disk partition %s\u0027"},{"line_number":53,"context_line":"                                  \u0027does not match object \u0027"},{"line_number":54,"context_line":"                                  \u0027rings partition %s\u0027 % (df.partition,"},{"line_number":55,"context_line":"                                                          obj_ring_part))"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"class AuditorWorker(object):"}],"source_content_type":"text/x-python","patch_set":2,"id":"da9df570_c12f20a0","line":55,"updated":"2014-09-25 02:50:54.000000000","message":"Add the parameters to the doc string for completeness sake.","commit_id":"2e3bc29a291719c0e9e6a00fd062d395ffd4e213"}],"test/unit/obj/test_auditor.py":[{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"d335f081c1a3bd91b2d3b7fae4ad1e26caf9d87e","unresolved":false,"context_lines":[{"line_number":180,"context_line":"        self.assertEquals(auditor_worker.quarantines, pre_quarantines + 1)"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"    @mock.patch(\u0027swift.common.ring.Ring.get_part\u0027, mock_get_part)"},{"line_number":183,"context_line":"    def test_object_audit_invalid_partitions(self):"},{"line_number":184,"context_line":"        auditor_worker \u003d auditor.AuditorWorker(self.conf, self.logger,"},{"line_number":185,"context_line":"                                               self.rcache, self.devices)"},{"line_number":186,"context_line":"        data \u003d \u00270\u0027 * 1024"}],"source_content_type":"text/x-python","patch_set":2,"id":"da9df570_12dcd3e3","line":183,"updated":"2014-09-25 02:50:54.000000000","message":"Instead of defining a function up the top (mock_get_part) which doesn\u0027t do anything but return \u0027fake\u0027, we can get mock to replicate this with out it:\n\n  @mock.patch(\u0027swift.common.ring.Ring.get_part\u0027, return_value\u003d\u0027fake\u0027)\n  def test_object_audit_invalid_partitions(self, mocked_get_part):\n\nNote: it passes in the new mock object, but we don\u0027t have to do anything with it as the return_value has already been set.","commit_id":"2e3bc29a291719c0e9e6a00fd062d395ffd4e213"}]}
