)]}'
{"swift/common/middleware/xprofile.py":[{"author":{"_account_id":330,"name":"John Dickinson","email":"me@not.mn","username":"notmyname"},"change_message_id":"ec0bf76a03768f18514128e59d0d655d7f77d3ce","unresolved":false,"context_lines":[{"line_number":249,"context_line":"            app_iter \u003d _locals[\u0027app_iter_\u0027]"},{"line_number":250,"context_line":"            self.dump_checkpoint()"},{"line_number":251,"context_line":"            return app_iter"},{"line_number":252,"context_line":""},{"line_number":253,"context_line":"    def renew_profile(self):"},{"line_number":254,"context_line":"        self.profiler \u003d get_profiler(self.profile_module)"},{"line_number":255,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"da9df570_8fd083f7","line":252,"updated":"2014-09-25 18:07:11.000000000","message":"my only outstanding question is if this is good or if the bare except should remain and have a noqa","commit_id":"e567722c4ea125f4607093112396e16ae6c6dd42"},{"author":{"_account_id":2649,"name":"Zhang Hua","email":"zhuadl@cn.ibm.com","username":"zhang-hare"},"change_message_id":"a50a6372734d49641844e730ab9cdf947ac6ca1d","unresolved":false,"context_lines":[{"line_number":249,"context_line":"            app_iter \u003d _locals[\u0027app_iter_\u0027]"},{"line_number":250,"context_line":"            self.dump_checkpoint()"},{"line_number":251,"context_line":"            return app_iter"},{"line_number":252,"context_line":""},{"line_number":253,"context_line":"    def renew_profile(self):"},{"line_number":254,"context_line":"        self.profiler \u003d get_profiler(self.profile_module)"},{"line_number":255,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"da9df570_bdfad3ba","line":252,"in_reply_to":"da9df570_8fd083f7","updated":"2014-09-26 07:12:15.000000000","message":"look better to me.:-)","commit_id":"e567722c4ea125f4607093112396e16ae6c6dd42"}],"swift/container/reconciler.py":[{"author":{"_account_id":330,"name":"John Dickinson","email":"me@not.mn","username":"notmyname"},"change_message_id":"8b5666c9abc5cb30866fc4384f0dfc9d6f20c80c","unresolved":false,"context_lines":[{"line_number":732,"context_line":"        \"\"\""},{"line_number":733,"context_line":"        try:"},{"line_number":734,"context_line":"            self.reconcile()"},{"line_number":735,"context_line":"        except Exception:"},{"line_number":736,"context_line":"            self.logger.exception(\u0027Unhandled Exception trying to reconcile\u0027)"},{"line_number":737,"context_line":"        self.log_stats(force\u003dTrue)"},{"line_number":738,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"da9df570_17922f9f","line":735,"updated":"2014-09-23 18:36:19.000000000","message":"Please pay attention here. I think the Exception is correct, but the original bare except may have been right too (eg for Timeouts).","commit_id":"667413cf0452f3b0abf8b86a32fcd4e7db5731f6"}],"test/unit/cli/test_recon.py":[{"author":{"_account_id":9051,"name":"Keshava Bharadwaj","email":"kb.sankethi@gmail.com","username":"keshava"},"change_message_id":"3d8c21e7dfa788d57398d3095561f7892b7cb2b3","unresolved":false,"context_lines":[{"line_number":99,"context_line":"    def tearDown(self, *_args, **_kwargs):"},{"line_number":100,"context_line":"        try:"},{"line_number":101,"context_line":"            os.remove(self.tmpfile_name)"},{"line_number":102,"context_line":"        except OSError:"},{"line_number":103,"context_line":"            pass"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    def test_gen_stats(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"da9df570_fc4374ac","line":102,"updated":"2014-09-26 14:12:27.000000000","message":"why not #noqa here ?\nwe do #noqa in swift/container/reconciler.py..  \nI believe being consistent across is better.","commit_id":"e567722c4ea125f4607093112396e16ae6c6dd42"},{"author":{"_account_id":330,"name":"John Dickinson","email":"me@not.mn","username":"notmyname"},"change_message_id":"01591d80124c2cfc1eef97abb17ce992d2057611","unresolved":false,"context_lines":[{"line_number":99,"context_line":"    def tearDown(self, *_args, **_kwargs):"},{"line_number":100,"context_line":"        try:"},{"line_number":101,"context_line":"            os.remove(self.tmpfile_name)"},{"line_number":102,"context_line":"        except OSError:"},{"line_number":103,"context_line":"            pass"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    def test_gen_stats(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"da9df570_ff2e068b","line":102,"in_reply_to":"da9df570_fc4374ac","updated":"2014-09-26 14:24:41.000000000","message":"1) Because OSError is what can be raised here, and it\u0027s better to be explicit about the error handling.\n\n2) In the reconciler, the bare except is logged and the process moves on. Here, there is no error logging (which is fine). The intention of this code is to clean up at the end, so there\u0027s nothing to \"move on\" to after this.","commit_id":"e567722c4ea125f4607093112396e16ae6c6dd42"},{"author":{"_account_id":9051,"name":"Keshava Bharadwaj","email":"kb.sankethi@gmail.com","username":"keshava"},"change_message_id":"d1e97bfd6879043fc2f3c2ded45670e0814f1009","unresolved":false,"context_lines":[{"line_number":99,"context_line":"    def tearDown(self, *_args, **_kwargs):"},{"line_number":100,"context_line":"        try:"},{"line_number":101,"context_line":"            os.remove(self.tmpfile_name)"},{"line_number":102,"context_line":"        except OSError:"},{"line_number":103,"context_line":"            pass"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    def test_gen_stats(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"da9df570_1f390aa4","line":102,"in_reply_to":"da9df570_ff2e068b","updated":"2014-09-26 14:30:36.000000000","message":"Agree, but in both places, we do nothing other than passing. \nIn tearDown too, for any exception we just do a pass. If we would have been handling something for OSError, ( retrying, or rmtree),  i would agree.. but irrespective of error, we are passing..\n\nHence thought that handling uniformly is better.","commit_id":"e567722c4ea125f4607093112396e16ae6c6dd42"}]}