)]}'
{"swift/proxy/controllers/obj.py":[{"author":{"_account_id":5189,"name":"Yuan Zhou","email":"dunk007@gmail.com","username":"yuan-zhou"},"change_message_id":"6e0f5f7338f6defcc299c5f26a69cad042812941","unresolved":false,"context_lines":[{"line_number":559,"context_line":"                copy_headers \u003d {"},{"line_number":560,"context_line":"                    \u0027Destination\u0027: \u0027%s/%s\u0027 % (lcontainer, vers_obj_name)}"},{"line_number":561,"context_line":"                copy_environ \u003d {\u0027REQUEST_METHOD\u0027: \u0027COPY\u0027,"},{"line_number":562,"context_line":"                                \u0027swift_versioned_copy\u0027: True"},{"line_number":563,"context_line":"                                }"},{"line_number":564,"context_line":"                if \u0027X-Object-Manifest\u0027 in hresp.headers or \\"},{"line_number":565,"context_line":"                   \u0027X-Static-Large-Object\u0027 in hresp.headers:"}],"source_content_type":"text/x-python","patch_set":1,"id":"baa201ad_730e7a36","line":562,"updated":"2014-09-29 01:35:19.000000000","message":"Here the internal copy request is also issued with \u0027swift_versioned_copy\u0027 in the environ.","commit_id":"2007771e3e5be9ccec070375fe534daf24352b3c"},{"author":{"_account_id":9625,"name":"Thiago da Silva","email":"thiagodasilva@gmail.com","username":"thiago"},"change_message_id":"8dfa5b15df2fa59b6864f020a51b1b84528af946","unresolved":false,"context_lines":[{"line_number":561,"context_line":"                copy_environ \u003d {\u0027REQUEST_METHOD\u0027: \u0027COPY\u0027,"},{"line_number":562,"context_line":"                                \u0027swift_versioned_copy\u0027: True"},{"line_number":563,"context_line":"                                }"},{"line_number":564,"context_line":"                if \u0027X-Object-Manifest\u0027 in hresp.headers or \\"},{"line_number":565,"context_line":"                   \u0027X-Static-Large-Object\u0027 in hresp.headers:"},{"line_number":566,"context_line":"                    copy_environ[\u0027QUERY_STRING\u0027] \u003d \u0027multipart-manifest\u003dget\u0027"},{"line_number":567,"context_line":"                copy_req \u003d Request.blank(req.path_info, headers\u003dcopy_headers,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_7fbb50e5","line":564,"updated":"2014-12-09 16:20:19.000000000","message":"it doesn\u0027t seem correct to check X-Object-Manifest here as a DLO manifest file should never be versioned. I think there\u0027s some difference in behavior in how DLO and SLO manifests get versioned.","commit_id":"2007771e3e5be9ccec070375fe534daf24352b3c"},{"author":{"_account_id":8859,"name":"Daisuke Morita","email":"morita.daisuke@ntti3.com","username":"morrisson"},"change_message_id":"dc616132a5903d3ab1c962134951e8028fd9bbab","unresolved":false,"context_lines":[{"line_number":826,"context_line":"                                \u0027Destination\u0027: orig_container + \u0027/\u0027 + orig_obj"},{"line_number":827,"context_line":"                                }"},{"line_number":828,"context_line":"                copy_environ \u003d {\u0027REQUEST_METHOD\u0027: \u0027COPY\u0027,"},{"line_number":829,"context_line":"                                \u0027swift_internal_copy\u0027: True,"},{"line_number":830,"context_line":"                                \u0027swift_versioned_copy\u0027: True"},{"line_number":831,"context_line":"                                }"},{"line_number":832,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"da9df570_8355aefb","line":829,"updated":"2014-09-26 09:08:17.000000000","message":"This variable is used in COPY method but why do you have to add this variable other than \u0027swift_versioned_copy\u0027?","commit_id":"2007771e3e5be9ccec070375fe534daf24352b3c"},{"author":{"_account_id":5189,"name":"Yuan Zhou","email":"dunk007@gmail.com","username":"yuan-zhou"},"change_message_id":"6e0f5f7338f6defcc299c5f26a69cad042812941","unresolved":false,"context_lines":[{"line_number":826,"context_line":"                                \u0027Destination\u0027: orig_container + \u0027/\u0027 + orig_obj"},{"line_number":827,"context_line":"                                }"},{"line_number":828,"context_line":"                copy_environ \u003d {\u0027REQUEST_METHOD\u0027: \u0027COPY\u0027,"},{"line_number":829,"context_line":"                                \u0027swift_internal_copy\u0027: True,"},{"line_number":830,"context_line":"                                \u0027swift_versioned_copy\u0027: True"},{"line_number":831,"context_line":"                                }"},{"line_number":832,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"baa201ad_13260ebb","line":829,"in_reply_to":"da9df570_8355aefb","updated":"2014-09-29 01:35:19.000000000","message":"good point, I was trying to save one extra head request in the above PUT code by using a different environ variable. see L528","commit_id":"2007771e3e5be9ccec070375fe534daf24352b3c"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"6ec770c2cde75b1d67f0f05e889b0da2b68dbed3","unresolved":false,"context_lines":[{"line_number":634,"context_line":"            slo_header \u003d \u0027X-Static-Large-Object\u0027"},{"line_number":635,"context_line":"            if slo_header in source_resp.headers and \\"},{"line_number":636,"context_line":"               req.params.get(\u0027multipart-manifest\u0027) \u003d\u003d \u0027get\u0027:"},{"line_number":637,"context_line":"                sink_req.headers[slo_header] \u003d source_resp.headers[slo_header]"},{"line_number":638,"context_line":""},{"line_number":639,"context_line":"            req \u003d sink_req"},{"line_number":640,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_18ac91ec","line":637,"updated":"2014-12-23 16:48:20.000000000","message":"can this (lines 634-637) be achieved by installing the slo copy_hook from the original request into the copy request?","commit_id":"31a3502ed592bb7406154b2fec3e5b668f651acd"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"6ec770c2cde75b1d67f0f05e889b0da2b68dbed3","unresolved":false,"context_lines":[{"line_number":892,"context_line":"        # use multipart-manifest\u003dget"},{"line_number":893,"context_line":"        if req.environ.get(\u0027swift_internal_copy\u0027):"},{"line_number":894,"context_line":"            hresp \u003d self._check_object(req.path_info, policy_index, obj_ring,"},{"line_number":895,"context_line":"                                       partition)"},{"line_number":896,"context_line":"            if \u0027X-Static-Large-Object\u0027 in hresp.headers:"},{"line_number":897,"context_line":"                req.environ[\u0027QUERY_STRING\u0027] \u003d \u0027multipart-manifest\u003dget\u0027"},{"line_number":898,"context_line":"                del req.environ[\u0027swift_internal_copy\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_585b7921","line":895,"updated":"2014-12-23 16:48:20.000000000","message":"Is it necessary to do the extra HEAD request - I wonder, would anything break if the multipart-manifest\u003dget query was added to *every* internal COPY - I\u0027m assuming it only has any effect if the source headers have X-Static-Large-Object ?","commit_id":"31a3502ed592bb7406154b2fec3e5b668f651acd"}]}