)]}'
{"swift/account/auditor.py":[{"author":{"_account_id":2696,"name":"Darrell Bishop","email":"dbishop@nvidia.com","username":"darrellb"},"change_message_id":"46c698a82db06a1f428d1799c93b77ce56b84f14","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        self.logger \u003d get_logger(conf, log_route\u003d\u0027account-auditor\u0027)"},{"line_number":36,"context_line":"        self.devices \u003d conf.get(\u0027devices\u0027, \u0027/srv/node\u0027)"},{"line_number":37,"context_line":"        self.mount_check \u003d conf.get(\u0027mount_check\u0027, \u0027true\u0027).lower() in \\"},{"line_number":38,"context_line":"            (\u0027true\u0027, \u0027t\u0027, \u00271\u0027, \u0027on\u0027, \u0027yes\u0027, \u0027y\u0027)"},{"line_number":39,"context_line":"        self.interval \u003d int(conf.get(\u0027interval\u0027, 1800))"},{"line_number":40,"context_line":"        self.account_passes \u003d 0"},{"line_number":41,"context_line":"        self.account_failures \u003d 0"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALH%2F%2Fgas%3D","line":38,"updated":"2012-09-05 17:03:34.000000000","message":"I think this is trying to be TRUE_VALUES; can you improve it to use that?","commit_id":"655aea89397f17aaa39f00c09cb7633cb3b704fb"}],"swift/account/reaper.py":[{"author":{"_account_id":2696,"name":"Darrell Bishop","email":"dbishop@nvidia.com","username":"darrellb"},"change_message_id":"46c698a82db06a1f428d1799c93b77ce56b84f14","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        self.logger \u003d get_logger(conf, log_route\u003d\u0027account-reaper\u0027)"},{"line_number":58,"context_line":"        self.devices \u003d conf.get(\u0027devices\u0027, \u0027/srv/node\u0027)"},{"line_number":59,"context_line":"        self.mount_check \u003d conf.get(\u0027mount_check\u0027, \u0027true\u0027).lower() in \\"},{"line_number":60,"context_line":"            (\u0027true\u0027, \u0027t\u0027, \u00271\u0027, \u0027on\u0027, \u0027yes\u0027, \u0027y\u0027)"},{"line_number":61,"context_line":"        self.interval \u003d int(conf.get(\u0027interval\u0027, 3600))"},{"line_number":62,"context_line":"        self.swift_dir \u003d conf.get(\u0027swift_dir\u0027, \u0027/etc/swift\u0027)"},{"line_number":63,"context_line":"        self.account_ring \u003d None"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALH%2F%2FgbA%3D","line":60,"updated":"2012-09-05 17:03:34.000000000","message":"While you\u0027re here, can you change this to TRUE_VALUES?  That\u0027s probably what this is trying to say w/o using the constant.","commit_id":"655aea89397f17aaa39f00c09cb7633cb3b704fb"},{"author":{"_account_id":2696,"name":"Darrell Bishop","email":"dbishop@nvidia.com","username":"darrellb"},"change_message_id":"46c698a82db06a1f428d1799c93b77ce56b84f14","unresolved":false,"context_lines":[{"line_number":353,"context_line":"            anode \u003d account_nodes.pop()"},{"line_number":354,"context_line":"            try:"},{"line_number":355,"context_line":"                direct_delete_container(node, part, account, container,"},{"line_number":356,"context_line":"                                        conn_timeout\u003dself.conn_timeout,"},{"line_number":357,"context_line":"                                        response_timeout\u003dself.node_timeout,"},{"line_number":358,"context_line":"                                        headers\u003d{\u0027X-Account-Host\u0027:"},{"line_number":359,"context_line":"                                                 \u0027%(ip)s:%(port)s\u0027 % anode,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALH%2F%2Fga4%3D","line":356,"updated":"2012-09-05 17:03:34.000000000","message":"This version is noticeably harder to read.  Perhaps line-break after the open paren of direct_delete_container() so there\u0027s enough horizontal space to have keys like \u0027X-Account-Host\u0027 and their values on the same line?\n\nI think you can satisfy PEP8 here without damaging readability this much.","commit_id":"655aea89397f17aaa39f00c09cb7633cb3b704fb"},{"author":{"_account_id":2696,"name":"Darrell Bishop","email":"dbishop@nvidia.com","username":"darrellb"},"change_message_id":"46c698a82db06a1f428d1799c93b77ce56b84f14","unresolved":false,"context_lines":[{"line_number":415,"context_line":"        for node in nodes:"},{"line_number":416,"context_line":"            cnode \u003d container_nodes.pop()"},{"line_number":417,"context_line":"            try:"},{"line_number":418,"context_line":"                direct_delete_object(node, part, account, container, obj,"},{"line_number":419,"context_line":"                                     conn_timeout\u003dself.conn_timeout,"},{"line_number":420,"context_line":"                                     response_timeout\u003dself.node_timeout,"},{"line_number":421,"context_line":"                                     headers\u003d{\u0027X-Container-Host\u0027:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALH%2F%2Fga0%3D","line":418,"updated":"2012-09-05 17:03:34.000000000","message":"(ditto)","commit_id":"655aea89397f17aaa39f00c09cb7633cb3b704fb"}],"swift/account/server.py":[{"author":{"_account_id":2696,"name":"Darrell Bishop","email":"dbishop@nvidia.com","username":"darrellb"},"change_message_id":"46c698a82db06a1f428d1799c93b77ce56b84f14","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        self.logger \u003d get_logger(conf, log_route\u003d\u0027account-server\u0027)"},{"line_number":50,"context_line":"        self.root \u003d conf.get(\u0027devices\u0027, \u0027/srv/node\u0027)"},{"line_number":51,"context_line":"        self.mount_check \u003d conf.get(\u0027mount_check\u0027, \u0027true\u0027).lower() in \\"},{"line_number":52,"context_line":"            (\u0027true\u0027, \u0027t\u0027, \u00271\u0027, \u0027on\u0027, \u0027yes\u0027, \u0027y\u0027)"},{"line_number":53,"context_line":"        self.replicator_rpc \u003d ReplicatorRpc(self.root, DATADIR, AccountBroker,"},{"line_number":54,"context_line":"                                            self.mount_check,"},{"line_number":55,"context_line":"                                            logger\u003dself.logger)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALH%2F%2Fgag%3D","line":52,"updated":"2012-09-05 17:03:34.000000000","message":"I think this is trying to be TRUE_VALUES; can you change it to use that?","commit_id":"655aea89397f17aaa39f00c09cb7633cb3b704fb"},{"author":{"_account_id":5311,"name":"dk647","email":"meizu647@gmail.com","username":"meizu647"},"change_message_id":"62579dc5979b778be278800ea2c817f1cad63f7a","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        self.logger \u003d get_logger(conf, log_route\u003d\u0027account-server\u0027)"},{"line_number":50,"context_line":"        self.root \u003d conf.get(\u0027devices\u0027, \u0027/srv/node\u0027)"},{"line_number":51,"context_line":"        self.mount_check \u003d conf.get(\u0027mount_check\u0027, \u0027true\u0027).lower() in \\"},{"line_number":52,"context_line":"            (\u0027true\u0027, \u0027t\u0027, \u00271\u0027, \u0027on\u0027, \u0027yes\u0027, \u0027y\u0027)"},{"line_number":53,"context_line":"        self.replicator_rpc \u003d ReplicatorRpc(self.root, DATADIR, AccountBroker,"},{"line_number":54,"context_line":"                                            self.mount_check,"},{"line_number":55,"context_line":"                                            logger\u003dself.logger)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALH%2F%2FfyU%3D","line":52,"in_reply_to":"AAAALH%2F%2Fgag%3D","updated":"2012-09-06 05:10:10.000000000","message":"yeah, I will change it","commit_id":"655aea89397f17aaa39f00c09cb7633cb3b704fb"},{"author":{"_account_id":2696,"name":"Darrell Bishop","email":"dbishop@nvidia.com","username":"darrellb"},"change_message_id":"46c698a82db06a1f428d1799c93b77ce56b84f14","unresolved":false,"context_lines":[{"line_number":78,"context_line":"        if self.mount_check and not check_mount(self.root, drive):"},{"line_number":79,"context_line":"            self.logger.increment(\u0027DELETE.errors\u0027)"},{"line_number":80,"context_line":"            return HTTPInsufficientStorage(drive\u003ddrive, request\u003dreq)"},{"line_number":81,"context_line":"        if \u0027x-timestamp\u0027 not in req.headers or\\"},{"line_number":82,"context_line":"                not check_float(req.headers[\u0027x-timestamp\u0027]):"},{"line_number":83,"context_line":"            self.logger.increment(\u0027DELETE.errors\u0027)"},{"line_number":84,"context_line":"            return HTTPBadRequest(body\u003d\u0027Missing timestamp\u0027, request\u003dreq,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALH%2F%2Fgac%3D","line":81,"updated":"2012-09-05 17:03:34.000000000","message":"Someone please correct me if I\u0027m wrong, but isn\u0027t it convention to have a space in front of a line-joining backslash like this?\n\nI tried it and it still passes (new) PEP8 with a space in front of the backslash.","commit_id":"655aea89397f17aaa39f00c09cb7633cb3b704fb"},{"author":{"_account_id":5311,"name":"dk647","email":"meizu647@gmail.com","username":"meizu647"},"change_message_id":"62579dc5979b778be278800ea2c817f1cad63f7a","unresolved":false,"context_lines":[{"line_number":78,"context_line":"        if self.mount_check and not check_mount(self.root, drive):"},{"line_number":79,"context_line":"            self.logger.increment(\u0027DELETE.errors\u0027)"},{"line_number":80,"context_line":"            return HTTPInsufficientStorage(drive\u003ddrive, request\u003dreq)"},{"line_number":81,"context_line":"        if \u0027x-timestamp\u0027 not in req.headers or\\"},{"line_number":82,"context_line":"                not check_float(req.headers[\u0027x-timestamp\u0027]):"},{"line_number":83,"context_line":"            self.logger.increment(\u0027DELETE.errors\u0027)"},{"line_number":84,"context_line":"            return HTTPBadRequest(body\u003d\u0027Missing timestamp\u0027, request\u003dreq,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALH%2F%2Ff1g%3D","line":81,"in_reply_to":"AAAALH%2F%2Fgac%3D","updated":"2012-09-06 05:10:10.000000000","message":"sorry, it‘s my fault.I change it back","commit_id":"655aea89397f17aaa39f00c09cb7633cb3b704fb"}]}