)]}'
{"swift/obj/diskfile.py":[{"author":{"_account_id":330,"name":"John Dickinson","email":"me@not.mn","username":"notmyname"},"change_message_id":"4fc2d41e5daebf6e432d010996598def7ef54e9c","unresolved":false,"context_lines":[{"line_number":74,"context_line":"ASYNCDIR_BASE \u003d \u0027async_pending\u0027"},{"line_number":75,"context_line":"try:"},{"line_number":76,"context_line":"    HOST_ID \u003d \u0027_\u0027 + socket.gethostbyname(socket.gethostname()).replace(\".\","},{"line_number":77,"context_line":"                                                                       \"_\")"},{"line_number":78,"context_line":"except:"},{"line_number":79,"context_line":"    HOST_ID \u003d \u0027\u0027"},{"line_number":80,"context_line":"TMP_BASE \u003d \u0027tmp\u0027 + HOST_ID"}],"source_content_type":"text/x-python","patch_set":3,"id":"baa201ad_7a669052","line":77,"updated":"2014-10-16 16:25:21.000000000","message":"is there a reason you chose to do it this way instead of using \"utils.whataremyips()\"?","commit_id":"fa316165c0fc7e1244ba11ae7d51478c632bd830"},{"author":{"_account_id":10619,"name":"Simon Lorenz","email":"simon.lorenz@de.ibm.com","username":"silorenz"},"change_message_id":"8f0c146fcab25fa1d0a6148e3efc834be3d3a9aa","unresolved":false,"context_lines":[{"line_number":74,"context_line":"ASYNCDIR_BASE \u003d \u0027async_pending\u0027"},{"line_number":75,"context_line":"try:"},{"line_number":76,"context_line":"    HOST_ID \u003d \u0027_\u0027 + socket.gethostbyname(socket.gethostname()).replace(\".\","},{"line_number":77,"context_line":"                                                                       \"_\")"},{"line_number":78,"context_line":"except:"},{"line_number":79,"context_line":"    HOST_ID \u003d \u0027\u0027"},{"line_number":80,"context_line":"TMP_BASE \u003d \u0027tmp\u0027 + HOST_ID"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aa7fdbe_df56cbcd","line":77,"in_reply_to":"baa201ad_7a669052","updated":"2014-10-23 08:37:34.000000000","message":"Thanks for the review.\n1st, to be honest I did not look through the utils to find something similar. I did search in the code for socket, to ensure I\u0027m not writing duplicate code, but should have also checked in utils.\n2nd, after I ran some tests with whataremyips I found, that if the node has an adapter that is used for private networks, it could have the same ip as another node with an identical internal setup. I guess a very rare case, but possible (was the case with my virtualbox setup), so the goal to find a unique id would fail. This brought me to the idea of using mac addresses. I changed the code to use a mac address. Will update the patch soon.","commit_id":"fa316165c0fc7e1244ba11ae7d51478c632bd830"}]}