)]}'
{"swift/obj/replicator.py":[{"author":{"_account_id":2696,"name":"Darrell Bishop","email":"dbishop@nvidia.com","username":"darrellb"},"change_message_id":"84d53132e9cbfa5b2c99d6a6386f7e157746e44a","unresolved":false,"context_lines":[{"line_number":154,"context_line":"    \"\"\""},{"line_number":155,"context_line":"    Get a list of hashes for the suffix dir.  do_listdir causes it to mistrust"},{"line_number":156,"context_line":"    the hash cache for suffix existence at the (unexpectedly high) cost of a"},{"line_number":157,"context_line":"    listdir. reclaim_age is just passed on to hash_suffix."},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"    :param partition_dir: absolute path of partition to get hashes for"},{"line_number":160,"context_line":"    :param recalculate: list of suffixes which should be recalculated when got"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAALH%2F%2FbZY%3D","line":157,"updated":"2012-09-12 04:19:24.000000000","message":"Personally, I like two spaces between sentences (in general, you\u0027re supposed to only use one with the possible exception of mono-space font presentation like typewriters in the olden days, but code is generally dealt with using fixed-width fonts).","commit_id":"1b65b7790838ce58199c166953bc5e534b092963"},{"author":{"_account_id":2696,"name":"Darrell Bishop","email":"dbishop@nvidia.com","username":"darrellb"},"change_message_id":"84d53132e9cbfa5b2c99d6a6386f7e157746e44a","unresolved":false,"context_lines":[{"line_number":195,"context_line":"            modified \u003d True"},{"line_number":196,"context_line":"    if modified:"},{"line_number":197,"context_line":"        with lock_path(partition_dir):"},{"line_number":198,"context_line":"            if not os.path.exists(hashes_file) or (os.path."},{"line_number":199,"context_line":"                                                   getmtime(hashes_file) \u003d\u003d"},{"line_number":200,"context_line":"                                                   mtime):"},{"line_number":201,"context_line":"                write_pickle("}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAALH%2F%2FbZU%3D","line":198,"updated":"2012-09-12 04:19:24.000000000","message":"I think this is more readable broken after the or.","commit_id":"1b65b7790838ce58199c166953bc5e534b092963"},{"author":{"_account_id":2696,"name":"Darrell Bishop","email":"dbishop@nvidia.com","username":"darrellb"},"change_message_id":"84d53132e9cbfa5b2c99d6a6386f7e157746e44a","unresolved":false,"context_lines":[{"line_number":241,"context_line":"        self.devices_dir \u003d conf.get(\u0027devices\u0027, \u0027/srv/node\u0027)"},{"line_number":242,"context_line":"        self.mount_check \u003d conf.get(\u0027mount_check\u0027, \u0027true\u0027).lower() in \\"},{"line_number":243,"context_line":"            TRUE_VALUES"},{"line_number":244,"context_line":"        self.vm_test_mode \u003d conf.get("},{"line_number":245,"context_line":"            \u0027vm_test_mode\u0027, \u0027no\u0027).lower() in (\u0027yes\u0027, \u0027true\u0027, \u0027on\u0027, \u00271\u0027)"},{"line_number":246,"context_line":"        self.swift_dir \u003d conf.get(\u0027swift_dir\u0027, \u0027/etc/swift\u0027)"},{"line_number":247,"context_line":"        self.port \u003d int(conf.get(\u0027bind_port\u0027, 6000))"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAALH%2F%2FbZQ%3D","line":244,"updated":"2012-09-12 04:19:24.000000000","message":"I think you missed another place TRUE_VALUES should have been used.","commit_id":"1b65b7790838ce58199c166953bc5e534b092963"},{"author":{"_account_id":2696,"name":"Darrell Bishop","email":"dbishop@nvidia.com","username":"darrellb"},"change_message_id":"84d53132e9cbfa5b2c99d6a6386f7e157746e44a","unresolved":false,"context_lines":[{"line_number":648,"context_line":"                _(\"Object replication complete. (%.02f minutes)\"), total)"},{"line_number":649,"context_line":"            dump_recon_cache({\u0027object_replication_time\u0027: total},"},{"line_number":650,"context_line":"                             self.rcache, self.logger)"},{"line_number":651,"context_line":"            self.logger.debug("},{"line_number":652,"context_line":"                _(\u0027Replication sleeping for %s seconds.\u0027),"},{"line_number":653,"context_line":"                self.run_pause)"},{"line_number":654,"context_line":"            sleep(self.run_pause)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAALH%2F%2FbZM%3D","line":651,"updated":"2012-09-12 04:19:24.000000000","message":"Similar situations above were resolved by leaving the _(\u0027...\u0027), on the first line and aligning the 2nd line just after the first line\u0027s function call open-paren.\n\ni.e.\n\n    self.logger.debug(_(\u0027Replication sleeping for %s seconds.\u0027),\n                      self.run_pause)\n\n(hopefully that\u0027ll end up with a fixed-width font?)","commit_id":"1b65b7790838ce58199c166953bc5e534b092963"}]}