)]}'
{"swift/obj/ssync_sender.py":[{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"b8dd860a50f59fa5fd2e29f675d82cbf3a25cafd","unresolved":false,"context_lines":[{"line_number":276,"context_line":"        Sends a DELETE subrequest with the given information."},{"line_number":277,"context_line":"        \"\"\""},{"line_number":278,"context_line":"        if isinstance(timestamp, Timestamp):"},{"line_number":279,"context_line":"            timestamp \u003d timestamp.normal"},{"line_number":280,"context_line":"        msg \u003d [\u0027DELETE \u0027 + url_path, \u0027X-Timestamp: \u0027 + timestamp]"},{"line_number":281,"context_line":"        msg \u003d \u0027\\r\\n\u0027.join(msg) + \u0027\\r\\n\\r\\n\u0027"},{"line_number":282,"context_line":"        with exceptions.MessageTimeout("}],"source_content_type":"text/x-python","patch_set":2,"id":"9aa7fdbe_557cfc72","line":279,"updated":"2014-10-17 23:40:17.000000000","message":"is it sometimes *not* a timestamp?\n\nDoes this show up when you run probetests with ssync?","commit_id":"08567d80fe53f3aadd672e7da4d7b638eaf679d4"},{"author":{"_account_id":13297,"name":"Alan Erwin","email":"alan.erwin@rackspace.com","username":"aerwin3"},"change_message_id":"78623b9ce6dead245a9b9da633b7d8522ba2d413","unresolved":false,"context_lines":[{"line_number":276,"context_line":"        Sends a DELETE subrequest with the given information."},{"line_number":277,"context_line":"        \"\"\""},{"line_number":278,"context_line":"        if isinstance(timestamp, Timestamp):"},{"line_number":279,"context_line":"            timestamp \u003d timestamp.normal"},{"line_number":280,"context_line":"        msg \u003d [\u0027DELETE \u0027 + url_path, \u0027X-Timestamp: \u0027 + timestamp]"},{"line_number":281,"context_line":"        msg \u003d \u0027\\r\\n\u0027.join(msg) + \u0027\\r\\n\\r\\n\u0027"},{"line_number":282,"context_line":"        with exceptions.MessageTimeout("}],"source_content_type":"text/x-python","patch_set":2,"id":"9aa7fdbe_d4ed338d","line":279,"in_reply_to":"9aa7fdbe_3e3cb593","updated":"2014-10-20 15:15:17.000000000","message":"I originally thought about coding the fix assuming the send_delete method would only be called with a TimeStamp type parameter. What changed my mind were the tests for the send delete method. In the tests, originally, a string was used as the parameter for the timestamp header. This led me to assume the send_delete method could be used with a string. But in Sender class a TimeStamp type parameter was being passed. So, I made sure that both cases were covered.","commit_id":"08567d80fe53f3aadd672e7da4d7b638eaf679d4"},{"author":{"_account_id":7479,"name":"paul luse","email":"paul.e.luse@intel.com","username":"peluse"},"change_message_id":"27476b3e9fb8675d03587382c099de1a032b5785","unresolved":false,"context_lines":[{"line_number":276,"context_line":"        Sends a DELETE subrequest with the given information."},{"line_number":277,"context_line":"        \"\"\""},{"line_number":278,"context_line":"        if isinstance(timestamp, Timestamp):"},{"line_number":279,"context_line":"            timestamp \u003d timestamp.normal"},{"line_number":280,"context_line":"        msg \u003d [\u0027DELETE \u0027 + url_path, \u0027X-Timestamp: \u0027 + timestamp]"},{"line_number":281,"context_line":"        msg \u003d \u0027\\r\\n\u0027.join(msg) + \u0027\\r\\n\\r\\n\u0027"},{"line_number":282,"context_line":"        with exceptions.MessageTimeout("}],"source_content_type":"text/x-python","patch_set":2,"id":"9aa7fdbe_3e3cb593","line":279,"in_reply_to":"9aa7fdbe_557cfc72","updated":"2014-10-18 13:13:50.000000000","message":"yeah, I\u0027m a little confused also.  Seems like the TS can only come from class DiskFileDeleted(DiskFileNotExist): which is always a TimeStamp class, no?","commit_id":"08567d80fe53f3aadd672e7da4d7b638eaf679d4"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"f2cc92ce575ad67590f503b4d9c26de06269661e","unresolved":false,"context_lines":[{"line_number":276,"context_line":"        Sends a DELETE subrequest with the given information."},{"line_number":277,"context_line":"        \"\"\""},{"line_number":278,"context_line":"        if isinstance(timestamp, Timestamp):"},{"line_number":279,"context_line":"            timestamp \u003d timestamp.normal"},{"line_number":280,"context_line":"        msg \u003d [\u0027DELETE \u0027 + url_path, \u0027X-Timestamp: \u0027 + timestamp]"},{"line_number":281,"context_line":"        msg \u003d \u0027\\r\\n\u0027.join(msg) + \u0027\\r\\n\\r\\n\u0027"},{"line_number":282,"context_line":"        with exceptions.MessageTimeout("}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_116615bb","line":279,"in_reply_to":"9aa7fdbe_d4ed338d","updated":"2014-12-15 14:40:59.000000000","message":"I\u0027d vote for making the tests do what the Sender class does i.e. pass a Timestamp object to send_delete()\n\nAlso I *think* we want to send timestamp.internal","commit_id":"08567d80fe53f3aadd672e7da4d7b638eaf679d4"}],"test/unit/obj/test_ssync_sender.py":[{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"f2cc92ce575ad67590f503b4d9c26de06269661e","unresolved":false,"context_lines":[{"line_number":819,"context_line":"        self.sender.daemon.node_timeout \u003d 0.01"},{"line_number":820,"context_line":"        exc \u003d None"},{"line_number":821,"context_line":"        try:"},{"line_number":822,"context_line":"            self.sender.send_delete(\u0027/a/c/o\u0027, \u00271381679759.90941\u0027)"},{"line_number":823,"context_line":"        except exceptions.MessageTimeout as err:"},{"line_number":824,"context_line":"            exc \u003d err"},{"line_number":825,"context_line":"        self.assertEqual(str(exc), \u00270.01 seconds: send_delete\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_b1df0168","line":822,"updated":"2014-12-15 14:40:59.000000000","message":"need to make this  Timestamp(\u00271381679759.90941\u0027)","commit_id":"08567d80fe53f3aadd672e7da4d7b638eaf679d4"}]}