)]}'
{"swift/common/ring/builder.py":[{"author":{"_account_id":2696,"name":"Darrell Bishop","email":"dbishop@nvidia.com","username":"darrellb"},"change_message_id":"50a2d455bb5f8710c3bcb2958e7d38fa56baaab4","unresolved":false,"context_lines":[{"line_number":227,"context_line":"        if \u0027id\u0027 not in dev:"},{"line_number":228,"context_line":"            dev[\u0027id\u0027] \u003d 0"},{"line_number":229,"context_line":"            if self.devs:"},{"line_number":230,"context_line":"                dev[\u0027id\u0027] \u003d max(d[\u0027id\u0027] for d in self.devs if d) + 1"},{"line_number":231,"context_line":"        if dev[\u0027id\u0027] \u003c len(self.devs) and self.devs[dev[\u0027id\u0027]] is not None:"},{"line_number":232,"context_line":"            raise exceptions.DuplicateDeviceError("},{"line_number":233,"context_line":"                \u0027Duplicate device id: %d\u0027 % dev[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2FYIQ%3D","line":230,"updated":"2012-09-17 19:33:35.000000000","message":"I\u0027d like to see a method which can utilize \"holes\" in the ID space (i.e. IDs freed when devices are removed and then the ring rebalanced).  So perhaps use the first id value for which self.devs[id] is None and fall back to len(self.devs) if there aren\u0027t any existing \"holes\".","commit_id":"c4f5761101892fa83823240eb4f878b5cabd02c3"}]}