)]}'
{"swift/common/middleware/message.py":[{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"c35aabd0f393251e2389fbce7c46502fa9b576b3","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":" X-Message-On: ALL"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"Event and On are optional flags and both default to ALL if not supplied."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"When you can add a message event, you can do it on 3 levels:"},{"line_number":33,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9aa7fdbe_298a2a6a","line":30,"updated":"2014-10-24 07:32:00.000000000","message":"that\u0027s a rather verbose choice for a default.\n\nAll this configurability is interesting, but deployer\u0027s are going to need a way to tweak it down.  I can\u0027t imagine I\u0027d want to let someone send a header that makes me jam a message down a queue for every successful HEAD on an object.\n\nMaybe some people will need something like that, but they can always write their own thing or extend this.  I\u0027d be more inclined to start with the use-cases and back into a minimum feature set which we can add too after we learn how to scale what we really think we need to cover for the use-cases we think are really important.","commit_id":"38ec55f714a3eb2c0be36dfcb2cadefcb601b0ee"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"c35aabd0f393251e2389fbce7c46502fa9b576b3","unresolved":false,"context_lines":[{"line_number":42,"context_line":"The manditory headers required to set a message event are:"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"  X-Message-Broker: \u003cname of broker\u003e"},{"line_number":45,"context_line":"  X-Message-Host: \u003chost or IP of broker server\u003e"},{"line_number":46,"context_line":"  X-Message-Port: \u003cport it\u0027s listening on\u003e (Might default this in driver)"},{"line_number":47,"context_line":"  X-Message-User: \u003cusername to authenticate to broker\u003e"},{"line_number":48,"context_line":"  X-Message-Password: \u003cpassword\u003e"}],"source_content_type":"text/x-python","patch_set":1,"id":"9aa7fdbe_a9129a54","line":45,"updated":"2014-10-24 07:32:00.000000000","message":"I don\u0027t think this idea that a swift cluster is connecting to any thousands of random messages queues super great for deployers or end-users...\n\nLike, does your message queue have to be on the internet if you\u0027re using a public offering?  Your.... *password*.  Does this extend to use a hosted cloud queue instead of rolling out your own rinky dink rabbit setup and trying to scale it.","commit_id":"38ec55f714a3eb2c0be36dfcb2cadefcb601b0ee"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"c35aabd0f393251e2389fbce7c46502fa9b576b3","unresolved":false,"context_lines":[{"line_number":69,"context_line":"MESSAGE_PUBLISHER_HEADER \u003d \u0027X-Message-Publisher\u0027"},{"line_number":70,"context_line":"MESSAGE_TOPIC_HEADER \u003d \u0027X-Message-Topic\u0027"},{"line_number":71,"context_line":"MESSAGE_EVENT_HEADER \u003d \u0027X-Message-Event\u0027"},{"line_number":72,"context_line":"MESSAGE_ON_HEADER \u003d \u0027X-Message-On\u0027"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"MESSAGE_REQUIRED_HEADERS \u003d (MESSAGE_BROKER_HEADER,"},{"line_number":75,"context_line":"                            MESSAGE_HOST_HEADER,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9aa7fdbe_297cea82","line":72,"updated":"2014-10-24 07:32:00.000000000","message":"nit: we\u0027ve tried constants for headers before with mixed success.  Mostly it seems to turn out by the time you end up spelling out all the different ways to reference a header in different contexts (e.g. HTTP_X_MESSAGE_ON and MESSAGE_ON_HEADER.lower()) you end up not really better off than just using the string literals, it gets particularly apparent when you\u0027re writing tests and your request stubs are mixing in a bunch of \u0027x-auth-token\u0027 and \u0027content-length\u0027 headers with these weird constants sticking out like a sore thumb.","commit_id":"38ec55f714a3eb2c0be36dfcb2cadefcb601b0ee"}]}