)]}'
{"swift/obj/diskfile.py":[{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"c03b0451bb64eb27e05c97f4b1004db62a358ba7","unresolved":false,"context_lines":[{"line_number":1411,"context_line":"                exc \u003d DiskFileDeleted(metadata\u003dmetadata)"},{"line_number":1412,"context_line":""},{"line_number":1413,"context_line":"                # But... if the tombstone\u0027s too old, call invalidate_hash."},{"line_number":1414,"context_line":"                ts \u003d os.path.basename(ts_file).rsplit(\u0027.\u0027, 1)[0]"},{"line_number":1415,"context_line":"                reclaim_age \u003d self._mgr.reclaim_age"},{"line_number":1416,"context_line":"                if (time.time() - float(Timestamp(ts))) \u003e reclaim_age * 1.1:"},{"line_number":1417,"context_line":"                    # Boy, does this warn() flood on an old cluster."}],"source_content_type":"text/x-python","patch_set":7,"id":"ba7be1f8_2ffe4a06","line":1414,"updated":"2015-02-26 22:39:53.000000000","message":"we already have the X-Timestamp in the metadata - do we really need to parse the file name?","commit_id":"5bd15c51a5601a7c2a828acf260f480153f251df"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"c03b0451bb64eb27e05c97f4b1004db62a358ba7","unresolved":false,"context_lines":[{"line_number":1412,"context_line":""},{"line_number":1413,"context_line":"                # But... if the tombstone\u0027s too old, call invalidate_hash."},{"line_number":1414,"context_line":"                ts \u003d os.path.basename(ts_file).rsplit(\u0027.\u0027, 1)[0]"},{"line_number":1415,"context_line":"                reclaim_age \u003d self._mgr.reclaim_age"},{"line_number":1416,"context_line":"                if (time.time() - float(Timestamp(ts))) \u003e reclaim_age * 1.1:"},{"line_number":1417,"context_line":"                    # Boy, does this warn() flood on an old cluster."},{"line_number":1418,"context_line":"                    # self._logger.warn(\"Old tombstone file: %s\" % (ts_file,))"}],"source_content_type":"text/x-python","patch_set":7,"id":"ba7be1f8_cf0e8e32","line":1415,"updated":"2015-02-26 22:39:53.000000000","message":"odd that the replicator\u0027s yeild_hashes and object_from_diskfile already added the reclaim age to the diskfile manager but didn\u0027t move the option to the DEFAULT section.  If Pete hand\u0027t been paying attention it seems like he could have used the attribute without realizing it\u0027s documented in the wrong spot - anyone who hands in a conf with the option was getting passed along to the manager already","commit_id":"5bd15c51a5601a7c2a828acf260f480153f251df"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"c03b0451bb64eb27e05c97f4b1004db62a358ba7","unresolved":false,"context_lines":[{"line_number":1415,"context_line":"                reclaim_age \u003d self._mgr.reclaim_age"},{"line_number":1416,"context_line":"                if (time.time() - float(Timestamp(ts))) \u003e reclaim_age * 1.1:"},{"line_number":1417,"context_line":"                    # Boy, does this warn() flood on an old cluster."},{"line_number":1418,"context_line":"                    # self._logger.warn(\"Old tombstone file: %s\" % (ts_file,))"},{"line_number":1419,"context_line":"                    suffix_dir \u003d dirname(dirname(ts_file))"},{"line_number":1420,"context_line":"                    invalidate_hash(suffix_dir)"},{"line_number":1421,"context_line":"                    # self._logger.increment(\u0027old_tss\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"ba7be1f8_1d30df06","line":1418,"updated":"2015-02-26 22:39:53.000000000","message":"this is a nice comment to have in the review, but I don\u0027t know if it and commented logger warn is useful to have in tree","commit_id":"5bd15c51a5601a7c2a828acf260f480153f251df"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"c03b0451bb64eb27e05c97f4b1004db62a358ba7","unresolved":false,"context_lines":[{"line_number":1418,"context_line":"                    # self._logger.warn(\"Old tombstone file: %s\" % (ts_file,))"},{"line_number":1419,"context_line":"                    suffix_dir \u003d dirname(dirname(ts_file))"},{"line_number":1420,"context_line":"                    invalidate_hash(suffix_dir)"},{"line_number":1421,"context_line":"                    # self._logger.increment(\u0027old_tss\u0027)"},{"line_number":1422,"context_line":""},{"line_number":1423,"context_line":"        return exc"},{"line_number":1424,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"ba7be1f8_8202ae6d","line":1421,"updated":"2015-02-26 22:39:53.000000000","message":"hrmm... dunno if this is useful","commit_id":"5bd15c51a5601a7c2a828acf260f480153f251df"}]}