)]}'
{"test/probe/test_object_metadata_replication.py":[{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"bd19ec8a71888f07f97d24368c076216f3a9be27","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    sync_methods \u003d set()"},{"line_number":39,"context_line":"    for config_path in object_server_config_paths:"},{"line_number":40,"context_line":"        options \u003d utils.readconf(config_path, \u0027object-replicator\u0027)"},{"line_number":41,"context_line":"        sync_methods.add(options[\u0027sync_method\u0027])"},{"line_number":42,"context_line":"    return sync_methods"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5a890539_4f1840d3","line":41,"updated":"2014-11-25 12:37:24.000000000","message":"I got a KeyError when conf file has no sync_method option, maybe use:\n\n options.get(\u0027sync_method\u0027, \u0027rsync\u0027)","commit_id":"51a7fd0cd64e14136612d1bab951a3edcd93b060"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"bd19ec8a71888f07f97d24368c076216f3a9be27","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    \"\"\""},{"line_number":49,"context_line":"    @functools.wraps(m)"},{"line_number":50,"context_line":"    def wrapper(self, *args, **kwargs):"},{"line_number":51,"context_line":"        sync_methods \u003d _sync_methods(self.configs[\u0027object-server\u0027].values())"},{"line_number":52,"context_line":"        failed \u003d False"},{"line_number":53,"context_line":"        try:"},{"line_number":54,"context_line":"            return m(self, *args, **kwargs)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a890539_d204bd19","line":51,"updated":"2014-11-25 12:37:24.000000000","message":"the test will only fail if the handoff nodes use ssync. If one handoff node uses rsync and the other ssync I fear the test outcome will depend upon a race between the handoff replicators :( ...hmm","commit_id":"51a7fd0cd64e14136612d1bab951a3edcd93b060"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"bd19ec8a71888f07f97d24368c076216f3a9be27","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        try:"},{"line_number":54,"context_line":"            return m(self, *args, **kwargs)"},{"line_number":55,"context_line":"        except AssertionError:"},{"line_number":56,"context_line":"            failed \u003d True"},{"line_number":57,"context_line":"        finally:"},{"line_number":58,"context_line":"            if \u0027ssync\u0027 in sync_methods and not failed:"},{"line_number":59,"context_line":"                self.fail(\u0027This test is expected to fail with ssync\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a890539_526c4d08","line":56,"updated":"2014-11-25 12:37:24.000000000","message":"if no ssync then should go ahead and raise the error","commit_id":"51a7fd0cd64e14136612d1bab951a3edcd93b060"}]}
