)]}'
{"swift/common/ring/utils.py":[{"author":{"_account_id":6968,"name":"Christian Schwede","email":"cschwede@nvidia.com","username":"cschwede"},"change_message_id":"6979d64fe71dc188690ed51b2973e62e857c7eb7","unresolved":false,"context_lines":[{"line_number":315,"context_line":""},{"line_number":316,"context_line":"        devs \u003d [d[\u0027id\u0027] for d in devs]"},{"line_number":317,"context_line":""},{"line_number":318,"context_line":"        if not devs or not builder._replica2part2dev:"},{"line_number":319,"context_line":"            return None"},{"line_number":320,"context_line":""},{"line_number":321,"context_line":"        partition_count \u003d {}"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a890539_a2d96486","line":318,"updated":"2014-12-05 07:48:24.000000000","message":"Maybe it\u0027s better to raise an exception here to inform the user? Something like this:\n\n if not builder._replica2part2dev:\n     raise ValueError(\u0027Please rebalance first\u0027)\n if not devs:\n     return None","commit_id":"bfc31794cc8f4ba57d2d1c49b2a91bd20d7424a8"},{"author":{"_account_id":12193,"name":"Hisashi Osanai","email":"osanai.hisashi@jp.fujitsu.com","username":"ho"},"change_message_id":"56e4ec504da5da82dd0b69e7c74cfc9af296620f","unresolved":false,"context_lines":[{"line_number":315,"context_line":""},{"line_number":316,"context_line":"        devs \u003d [d[\u0027id\u0027] for d in devs]"},{"line_number":317,"context_line":""},{"line_number":318,"context_line":"        if not devs or not builder._replica2part2dev:"},{"line_number":319,"context_line":"            return None"},{"line_number":320,"context_line":""},{"line_number":321,"context_line":"        partition_count \u003d {}"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a890539_96b82d77","line":318,"in_reply_to":"5a890539_a2d96486","updated":"2014-12-05 08:52:28.000000000","message":"Thank you for the review. You are right. I moved this check in list_parts in ringbuilder because it can check before execution of find_parts.","commit_id":"bfc31794cc8f4ba57d2d1c49b2a91bd20d7424a8"}]}