)]}'
{"swift/common/ring/builder.py":[{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"7791ebb36b01f4da07c1332141e366aaabb611d3","unresolved":false,"context_lines":[{"line_number":728,"context_line":""},{"line_number":729,"context_line":"                    full_sibling_tiers \u003d ["},{"line_number":730,"context_line":"                        t for (t, r) in replicas_at_tier.items()"},{"line_number":731,"context_line":"                        if t[:-1] \u003d\u003d tier[:-1] and t !\u003d tier  # sibling"},{"line_number":732,"context_line":"                        and max_allowed_replicas[t] \u003d\u003d r  # full"},{"line_number":733,"context_line":"                    ]"},{"line_number":734,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_c075c332","line":731,"updated":"2014-12-12 19:09:57.000000000","message":"I dont\u0027 think I really understand this sibling stuff, but when I did some debugging I\u0027m pretty sure this isn\u0027t quite correct?  What about when t is (0, 0, \u002710.0.0.1\u0027) and t is (0,)?","commit_id":"51c4e94f2bad56122dfaed5db4326f1c00f0519d"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"7791ebb36b01f4da07c1332141e366aaabb611d3","unresolved":false,"context_lines":[{"line_number":729,"context_line":"                    full_sibling_tiers \u003d ["},{"line_number":730,"context_line":"                        t for (t, r) in replicas_at_tier.items()"},{"line_number":731,"context_line":"                        if t[:-1] \u003d\u003d tier[:-1] and t !\u003d tier  # sibling"},{"line_number":732,"context_line":"                        and max_allowed_replicas[t] \u003d\u003d r  # full"},{"line_number":733,"context_line":"                    ]"},{"line_number":734,"context_line":""},{"line_number":735,"context_line":"                    available_parts_for_tier \u003d wanted_parts_total - \\"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_cac8a857","line":732,"updated":"2014-12-12 19:09:57.000000000","message":"why isn\u0027t this \u003e\u003d ?","commit_id":"51c4e94f2bad56122dfaed5db4326f1c00f0519d"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"7791ebb36b01f4da07c1332141e366aaabb611d3","unresolved":false,"context_lines":[{"line_number":753,"context_line":"                        # parts_wanted. This can lead to a replica that"},{"line_number":754,"context_line":"                        # sticks to a zero-weight device no matter how often"},{"line_number":755,"context_line":"                        # the ring is rebalanced."},{"line_number":756,"context_line":"                        available_parts_for_tier -\u003d wanted_parts_for_tier[tier]"},{"line_number":757,"context_line":""},{"line_number":758,"context_line":"                    # Only allow a part to be gathered if there are wanted"},{"line_number":759,"context_line":"                    # parts on other tiers."}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_ca87c8b3","line":756,"updated":"2014-12-12 19:09:57.000000000","message":"should this be t?  like if a tier t already has this as many (or more?) replicas of the part than it wants you don\u0027t really want to consider any parts_wanted from *that* tier.  So before you just looked at all the weight in the cluster less the weight in *this* tier less any weight you\u0027ve already moved, so now we\u0027d subtract weights for sibling tiers for the same reason we subtracted this one - that tier already has a copy.","commit_id":"51c4e94f2bad56122dfaed5db4326f1c00f0519d"},{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"7f6d7298edb15fe576f44a3c1bb6ee862d032211","unresolved":false,"context_lines":[{"line_number":685,"context_line":"        sibling_tiers \u003d {}"},{"line_number":686,"context_line":"        for length, tiers in tiers_by_len.items():"},{"line_number":687,"context_line":"            for i, tier in enumerate(tiers):"},{"line_number":688,"context_line":"                sibling_tiers[tier] \u003d [t for t in (tiers[:i] + tiers[i:])"},{"line_number":689,"context_line":"                                       if t[:-1] \u003d\u003d tier[:-1]]"},{"line_number":690,"context_line":""},{"line_number":691,"context_line":"        # First we gather partitions from removed devices. Since removed"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a961159_72c7c545","line":688,"updated":"2015-01-06 01:29:30.000000000","message":"you are doing:\n\n  tiers[:i] + tiers[i:]\n\nWhich is equivalent to just \u0027teirs\u0027:\n\n   tiers[:i] + tiers[i:] \u003d\u003d tiers\n\nI assume you want to remove the current tier from the list, which means you need to do something like:\n\n  sibling_tiers \u003d {}\n  for length, tiers in tiers_by_len.items():\n      for tier in tiers:\n          sibling_tiers[tier] \u003d [t for t in (x for x in tiers\n                                             if x !\u003d tier)\n                                 if t[:-1] \u003d\u003d tier[:-1]]","commit_id":"d80e26fe14fe6357de36da7fa0b4a57f62fd8a1b"},{"author":{"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},"change_message_id":"9810be8366f4cc2719b385a464fbb0183ec00cf8","unresolved":false,"context_lines":[{"line_number":685,"context_line":"        sibling_tiers \u003d {}"},{"line_number":686,"context_line":"        for length, tiers in tiers_by_len.items():"},{"line_number":687,"context_line":"            for i, tier in enumerate(tiers):"},{"line_number":688,"context_line":"                sibling_tiers[tier] \u003d [t for t in (tiers[:i] + tiers[i:])"},{"line_number":689,"context_line":"                                       if t[:-1] \u003d\u003d tier[:-1]]"},{"line_number":690,"context_line":""},{"line_number":691,"context_line":"        # First we gather partitions from removed devices. Since removed"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a961159_9a051112","line":688,"in_reply_to":"3a961159_72c7c545","updated":"2015-01-06 18:38:14.000000000","message":"Done","commit_id":"d80e26fe14fe6357de36da7fa0b4a57f62fd8a1b"}],"test/unit/common/ring/test_builder.py":[{"author":{"_account_id":6968,"name":"Christian Schwede","email":"cschwede@nvidia.com","username":"cschwede"},"change_message_id":"f1eb669827caa34365c30e546224c597fcbe0e5a","unresolved":false,"context_lines":[{"line_number":697,"context_line":"        rb.set_dev_weight(zero_weight_dev, 0.0)"},{"line_number":698,"context_line":"        rb.pretend_min_part_hours_passed()"},{"line_number":699,"context_line":"        rb.rebalance(seed\u003d1)"},{"line_number":700,"context_line":""},{"line_number":701,"context_line":"        node_counts \u003d defaultdict(int)"},{"line_number":702,"context_line":"        for part2dev_id in rb._replica2part2dev:"},{"line_number":703,"context_line":"            for dev_id in part2dev_id:"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a961159_c9bc6bde","line":700,"updated":"2015-01-05 11:23:45.000000000","message":"I would like to have another check here with a second rebalance  to verify no partitions are moved again, something like this:\n\n rb.pretend_min_part_hours_passed()\n (nr_of_partitions_altered, resulting_balance) \u003d rb.rebalance(seed\u003d1)\n self.assertEqual(nr_of_partitions_altered, 0)\n\nThis fails on master and succeeds with this patch.","commit_id":"733c25167933ca247d49a10151cd967ff5f1200c"}]}
