)]}'
{"swift/cli/ringbuilder.py":[{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"947c5e3f09fb63634b140298ce4861a5da7e7578","unresolved":false,"context_lines":[{"line_number":802,"context_line":"    A rebalance is needed to make the change take effect."},{"line_number":803,"context_line":"    \"\"\""},{"line_number":804,"context_line":"        if len(argv) \u003c 4:"},{"line_number":805,"context_line":"            print Commands.set_replicas.__doc__.strip()"},{"line_number":806,"context_line":"            exit(EXIT_ERROR)"},{"line_number":807,"context_line":""},{"line_number":808,"context_line":"        new_overload \u003d argv[3]"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a961159_e846c54e","line":805,"updated":"2014-12-29 22:04:31.000000000","message":"so close...","commit_id":"1922a2bafcf74c7161a90fbe17bd51bcb7e8e25e"},{"author":{"_account_id":6968,"name":"Christian Schwede","email":"cschwede@nvidia.com","username":"cschwede"},"change_message_id":"db5400c299b43bb74d4e731e13338727569c44e4","unresolved":false,"context_lines":[{"line_number":816,"context_line":"        if new_overload \u003c 0:"},{"line_number":817,"context_line":"            print \"Overload must be non-negative.\""},{"line_number":818,"context_line":"            exit(EXIT_ERROR)"},{"line_number":819,"context_line":""},{"line_number":820,"context_line":"        builder.set_overload(new_overload)"},{"line_number":821,"context_line":"        print \u0027The overload is now %.6f.\u0027 % builder.overload"},{"line_number":822,"context_line":"        print \u0027The change will take effect after the next rebalance.\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a961159_44499231","line":819,"updated":"2014-12-29 08:28:10.000000000","message":"Do we need a check that overload is actually 0 \u003c overload \u003c 1? Or a warning if overload \u003e 1?\n\nFor example, if a user wants to set the overload to 10%, but instead of setting it to 0.1 sets it to 10 - then there might be a lot of unwanted data movement.","commit_id":"1922a2bafcf74c7161a90fbe17bd51bcb7e8e25e"}]}