)]}'
{"swift/common/utils.py":[{"author":{"_account_id":2696,"name":"Darrell Bishop","email":"dbishop@nvidia.com","username":"darrellb"},"change_message_id":"4c458009c393c5f3c115fb64af88e7f76f54da2c","unresolved":false,"context_lines":[{"line_number":400,"context_line":""},{"line_number":401,"context_line":"class StatsdClient(object):"},{"line_number":402,"context_line":"    def __init__(self, host, port, base_prefix\u003d\u0027\u0027, tail_prefix\u003d\u0027\u0027,"},{"line_number":403,"context_line":"                 default_sample_rate\u003d1, random\u003drandom):"},{"line_number":404,"context_line":"        self._host \u003d host"},{"line_number":405,"context_line":"        self._port \u003d port"},{"line_number":406,"context_line":"        self._base_prefix \u003d base_prefix"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2FI5w%3D","line":403,"updated":"2012-10-12 00:29:48.000000000","message":"Since the only place random shouldn\u0027t be random.random() is the tests, and they just assign over the logger\u0027s StatsdClient\u0027s self.random, you could probably just ditch this defaulted kwarg and keep the self.random assignment below.\n\n...unless there\u0027s some Pythony reason that the assigned random wouldn\u0027t be the imported random from the \"random\" module.","commit_id":"0427afa385935db89b53e3e3c6bb17c64ab91b71"},{"author":{"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},"change_message_id":"3bcabe820f812e7ecb3ac83e778429ae64547be5","unresolved":false,"context_lines":[{"line_number":400,"context_line":""},{"line_number":401,"context_line":"class StatsdClient(object):"},{"line_number":402,"context_line":"    def __init__(self, host, port, base_prefix\u003d\u0027\u0027, tail_prefix\u003d\u0027\u0027,"},{"line_number":403,"context_line":"                 default_sample_rate\u003d1, random\u003drandom):"},{"line_number":404,"context_line":"        self._host \u003d host"},{"line_number":405,"context_line":"        self._port \u003d port"},{"line_number":406,"context_line":"        self._base_prefix \u003d base_prefix"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2FIeE%3D","line":403,"in_reply_to":"AAAALH%2F%2FI5w%3D","updated":"2012-10-12 18:38:47.000000000","message":"Done","commit_id":"0427afa385935db89b53e3e3c6bb17c64ab91b71"}],"test/unit/common/test_utils.py":[{"author":{"_account_id":2696,"name":"Darrell Bishop","email":"dbishop@nvidia.com","username":"darrellb"},"change_message_id":"389b644393fa03d7be5117e66cde7666dc86f00a","unresolved":false,"context_lines":[{"line_number":954,"context_line":"        # encapsulation? what\u0027s that?"},{"line_number":955,"context_line":"        statsd_client \u003d logger.logger.statsd_client"},{"line_number":956,"context_line":"        statsd_client._open_socket \u003d lambda *_: mock_socket"},{"line_number":957,"context_line":"        statsd_client.random \u003d lambda: 0.50001"},{"line_number":958,"context_line":""},{"line_number":959,"context_line":"        logger.increment(\u0027tribbles\u0027, sample_rate \u003d 0.5)"},{"line_number":960,"context_line":"        self.assertEqual(len(mock_socket.sent), 0)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2FI58%3D","line":957,"updated":"2012-10-12 00:26:10.000000000","message":"Can you test that statsd_client.random \"is\" (or \u003d\u003d maybe?) random.random() prior to assigning the mock, here?","commit_id":"0427afa385935db89b53e3e3c6bb17c64ab91b71"},{"author":{"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},"change_message_id":"3bcabe820f812e7ecb3ac83e778429ae64547be5","unresolved":false,"context_lines":[{"line_number":954,"context_line":"        # encapsulation? what\u0027s that?"},{"line_number":955,"context_line":"        statsd_client \u003d logger.logger.statsd_client"},{"line_number":956,"context_line":"        statsd_client._open_socket \u003d lambda *_: mock_socket"},{"line_number":957,"context_line":"        statsd_client.random \u003d lambda: 0.50001"},{"line_number":958,"context_line":""},{"line_number":959,"context_line":"        logger.increment(\u0027tribbles\u0027, sample_rate \u003d 0.5)"},{"line_number":960,"context_line":"        self.assertEqual(len(mock_socket.sent), 0)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2FIeI%3D","line":957,"in_reply_to":"AAAALH%2F%2FI58%3D","updated":"2012-10-12 18:38:47.000000000","message":"Done","commit_id":"0427afa385935db89b53e3e3c6bb17c64ab91b71"},{"author":{"_account_id":330,"name":"John Dickinson","email":"me@not.mn","username":"notmyname"},"change_message_id":"d96782f3f4579fe2bba43b4a02ea601a63ed9233","unresolved":false,"context_lines":[{"line_number":954,"context_line":"        mock_socket \u003d MockUdpSocket()"},{"line_number":955,"context_line":"        # encapsulation? what\u0027s that?"},{"line_number":956,"context_line":"        statsd_client \u003d logger.logger.statsd_client"},{"line_number":957,"context_line":"        self.assertIs(statsd_client.random, random.random)"},{"line_number":958,"context_line":""},{"line_number":959,"context_line":"        statsd_client._open_socket \u003d lambda *_: mock_socket"},{"line_number":960,"context_line":"        statsd_client.random \u003d lambda: 0.50001"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALH%2F%2FIcc%3D","line":957,"updated":"2012-10-12 19:06:49.000000000","message":"change to self.assertTrue(statsd_client.random is random.random)","commit_id":"1ac2aefb81980605a5f07cca4d9befb81901f2f0"},{"author":{"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},"change_message_id":"e43057d9a3215ef7f047633d7336c833dfac1abb","unresolved":false,"context_lines":[{"line_number":954,"context_line":"        mock_socket \u003d MockUdpSocket()"},{"line_number":955,"context_line":"        # encapsulation? what\u0027s that?"},{"line_number":956,"context_line":"        statsd_client \u003d logger.logger.statsd_client"},{"line_number":957,"context_line":"        self.assertIs(statsd_client.random, random.random)"},{"line_number":958,"context_line":""},{"line_number":959,"context_line":"        statsd_client._open_socket \u003d lambda *_: mock_socket"},{"line_number":960,"context_line":"        statsd_client.random \u003d lambda: 0.50001"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALH%2F%2FIcQ%3D","line":957,"in_reply_to":"AAAALH%2F%2FIcc%3D","updated":"2012-10-12 19:28:57.000000000","message":"Seriously, who uses Python 2.6 any more? ;)","commit_id":"1ac2aefb81980605a5f07cca4d9befb81901f2f0"}]}