)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"0c62e91a0ef702dacc0a3f0241d54a656ea3c603","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Signed-off-by: Yuan Zhou \u003cyuan.zhou@intel.com\u003e"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"DoCImpact"},{"line_number":25,"context_line":"Change-Id: I91952bc9337f354ce6024bf8392046a1ecf6ecc9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"1a6ced46_42aa13d5","line":24,"updated":"2015-03-25 00:56:43.000000000","message":"s/DoCImpact/DocImpact/\n\n(in case the trigger is case sensitive)","commit_id":"f0117aee7ec38b3788a51481deea18e1424a87d7"}],"swift/container/sync.py":[{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"0c62e91a0ef702dacc0a3f0241d54a656ea3c603","unresolved":false,"context_lines":[{"line_number":212,"context_line":"        if not internal_client_conf_path:"},{"line_number":213,"context_line":"            self.logger.warning("},{"line_number":214,"context_line":"                _(\u0027Please set internal_client_conf_path option. \u0027"},{"line_number":215,"context_line":"                  \u0027See internal-client.conf-sample for options\u0027))"},{"line_number":216,"context_line":"            internal_client_conf \u003d ConfigString(ic_conf_body)"},{"line_number":217,"context_line":"        else:"},{"line_number":218,"context_line":"            internal_client_conf \u003d internal_client_conf_path"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a6ced46_425db3e8","line":215,"updated":"2015-03-25 00:56:43.000000000","message":"Based on this log message a user may assume that the internal_client will fail to work until this option has been configured.. but it will actually use the default configuration you specified above (ic_conf_body).\n\nMaybe we should indicate this in the log message, e.g:\n\n  _(\u0027Configuration option internal_client_conf_path not defined. \u0027\n    \u0027Using default configuration, see internal-client.conf-sample for options\u0027))","commit_id":"f0117aee7ec38b3788a51481deea18e1424a87d7"},{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"1b4a3df7bb159d93f720d26c90ef1f0845bb52f0","unresolved":false,"context_lines":[{"line_number":211,"context_line":"        internal_client_conf_path \u003d conf.get(\u0027internal_client_conf_path\u0027)"},{"line_number":212,"context_line":"        if not internal_client_conf_path:"},{"line_number":213,"context_line":"            self.logger.warning("},{"line_number":214,"context_line":"                _(\u0027Configuration option internal_client_conf_path not defined.\u0027"},{"line_number":215,"context_line":"                  \u0027Using default configuration, See \u0027"},{"line_number":216,"context_line":"                  \u0027internal-client.conf-sample for options\u0027))"},{"line_number":217,"context_line":"            internal_client_conf \u003d ConfigString(ic_conf_body)"}],"source_content_type":"text/x-python","patch_set":8,"id":"da9b358b_5dff2167","line":214,"updated":"2015-04-01 05:14:08.000000000","message":"Needs a space after \u0027defined.\u0027:\n\n  _(\u0027Configuration option internal_client_conf_path not defined. \u0027\n\nTo keep it readable in logs, e.g.: \n\n  Apr  1 04:34:13 ec-saio container-sync: Configuration option internal_client_conf_path not defined.Using default configuration...","commit_id":"edc51b17303cd2b70f2bc666ccef8c561a01e6a3"}],"test/unit/container/test_sync.py":[{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"7b9bcb03722faec517e529ba72bc08ccd46d3e1c","unresolved":false,"context_lines":[{"line_number":856,"context_line":"                        \u0027content-type\u0027: \u0027text/plain; swift_bytes\u003d123\u0027},"},{"line_number":857,"context_line":"                        iter(\u0027contents\u0027))"},{"line_number":858,"context_line":""},{"line_number":859,"context_line":"            cs.swift.get_object \u003d fake_get_object"},{"line_number":860,"context_line":"            # Success as everything says it worked"},{"line_number":861,"context_line":"            self.assertTrue(cs.container_sync_row("},{"line_number":862,"context_line":"                {\u0027deleted\u0027: False,"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a80dd14_cfb3cc08","line":859,"updated":"2015-03-11 09:01:07.000000000","message":"the reconciler uses the internal client and it took the approach of creating a FakeInteralClient based off the middleware.helpers.FakeSwift\n\nDepending on how much control you need over headers you may find it harder or easier to use than faking the individual InternalClient calls","commit_id":"98efd55dc42468458ad0ce0c295d7cc77354ef6a"},{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"0c62e91a0ef702dacc0a3f0241d54a656ea3c603","unresolved":false,"context_lines":[{"line_number":119,"context_line":"            cs \u003d sync.ContainerSync({}, container_ring\u003dcring)"},{"line_number":120,"context_line":"        self.assertTrue(cs.container_ring is cring)"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"        # specified but not eixts will not start"},{"line_number":123,"context_line":"        conf \u003d {\u0027internal_client_conf_path\u0027: ic_conf_path}"},{"line_number":124,"context_line":"        self.assertRaises(SystemExit, sync.ContainerSync, conf,"},{"line_number":125,"context_line":"                          container_ring\u003dcring, logger\u003dself.logger)"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a6ced46_627d4f1c","line":122,"updated":"2015-03-25 00:56:43.000000000","message":"s/eixts/exists/","commit_id":"f0117aee7ec38b3788a51481deea18e1424a87d7"}]}